Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Migrate training into Celery #1136

Closed
andrewpeng02 opened this issue Feb 21, 2024 · 2 comments
Closed

[FEATURE]: Migrate training into Celery #1136

andrewpeng02 opened this issue Feb 21, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@andrewpeng02
Copy link
Contributor

Feature Name

Migrate training into Celery

Your Name

Andrew Peng

Description

Currently, we do the training during the HTTP request. I plan on changing the train HTTP endpoints by scheduling a train job via Celery and returning the job id in the request. This offers numerous advantages

  • Long training tasks (>2 min) shouldn't be done in an HTTP request. Scheduling the training job will allow the endpoint to return quickly
  • Eventually, we can decouple the backend with the training, so that we can use cheaper EC2 instances for the Django backend, and GPU instances for the actual training

Notifying the user will be done in websockets in this issue (#920 (comment)), for now I'll create an HTTP endpoint to retrieve the training results that the user can ping.

@andrewpeng02 andrewpeng02 added the enhancement New feature or request label Feb 21, 2024
@andrewpeng02 andrewpeng02 self-assigned this Feb 21, 2024
Copy link
Contributor

Hello @andrewpeng02! Thank you for submitting the Feature Request Form. We appreciate your contribution. 👋

We will look into it and provide a response as soon as possible.

To work on this feature request, you can follow these branch setup instructions:

  1. Checkout the main branch:
```
 git checkout nextjs
```
  1. Pull the latest changes from the remote main branch:
```
 git pull origin nextjs
```
  1. Create a new branch specific to this feature request using the issue number:
```
 git checkout -b feature-1136
```

Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

Best regards,
Deep Learning Playground (DLP) Team

@karkir0003
Copy link
Member

@andrewpeng02 thanks for writing this issue. Is this docs on celery the updated ones: https://docs.celeryq.dev/en/stable/django/first-steps-with-django.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants