Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative soil NO3, NH4 and UREA in SOILNI.for #335

Open
thiagoferreira53 opened this issue Jul 7, 2023 · 3 comments
Open

Negative soil NO3, NH4 and UREA in SOILNI.for #335

thiagoferreira53 opened this issue Jul 7, 2023 · 3 comments

Comments

@thiagoferreira53
Copy link
Contributor

thiagoferreira53 commented Jul 7, 2023

File: SOILNI.for.
Lines:
SNO3(L) = SNO3(L) + DLTSNO3(L)
SNH4(L) = SNH4(L) + DLTSNH4(L)
UREA(L) = UREA(L) + DLTUREA(L)

In some cases, SNO3, SNH4 and UREA in the soil layers are getting negative values. This is happening because calculated values of DLTSNO3, DLTSNH4, and DLTUREA are negative (which is acceptable), but these calculated values sometimes exceed the actual values of SNO3, SNH4, and UREA in the soil layer (which is incorrect). It is necessary to Identify what is happening with DLTSNO3, DLTSNH4 and DLTUREA.

@fabiooliveira72
Copy link
Contributor

Hi @thiagoferreira53!

Is this issue refers to PR #337 ?

Thank you.

@thiagoferreira53
Copy link
Contributor Author

Hello,

Yes, it is related to it but we still need to conduct a further investigation on DLTSNO3, DLTSNH4, and DLTUREA. We are planning to do that during the DSSAT Sprint.

@fabiooliveira72
Copy link
Contributor

Oh Ok. Gracias!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants