Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Descender impacts padding on text layers #128

Open
raphaelloder opened this issue Aug 1, 2018 · 4 comments
Open

[Bug report] Descender impacts padding on text layers #128

raphaelloder opened this issue Aug 1, 2018 · 4 comments

Comments

@raphaelloder
Copy link

raphaelloder commented Aug 1, 2018

Bug report

Expected behavior:

When padding is dependent on text layers on a vertical axis (such as a symbol with only text layer and a rectangle with "[0 x]"), the height of the symbol should stay flexible depending on the line-height of the text layer, but independent of the actual content of the text override.

Actual behavior:

The height of the symbol changes depending on if the override text contains letters that have descenders. Only if a descender is present in the override, the height is calculated correctly (irregardless if the original placeholder contains a descender or not). This is also affecting multiple lines. If the last line doesn't have a descender it's wrong again.

Steps to reproduce:

screenshot 2018-08-01 15 14 14

descender-paddy-bug.sketch.zip

@fancymans
Copy link

I have the same issue described here with descenders. I figured I would give Paddy2 Beta a shot and the problem seems to be fixed. However, it also seems like ignoring padding doesn't work in Paddy2 at this point.

@blaskotron
Copy link

blaskotron commented Sep 5, 2018

I think this may be fixed. As soon as I open your file and click the symbol text and click away, all the instance heights update to match.
i.e. 40 40, 80 80 80, 120 120
screen shot 2018-09-05 at 8 26 27 am

@raphaelloder
Copy link
Author

Are you using Paddy 2?
Because there hasn't been an update in a few months for Paddy.

@blaskotron
Copy link

Ah you're right. I was looking at wrong github.

I was assuming every one moved on from 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants