Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r_measureOverdraw is broken #1360

Open
VReaperV opened this issue Oct 16, 2024 · 1 comment
Open

r_measureOverdraw is broken #1360

VReaperV opened this issue Oct 16, 2024 · 1 comment

Comments

@VReaperV
Copy link
Contributor

It reads back a stencil buffer value and adds it to backEnd.pc.c_overDraw, but it's then never used. It might be better to do this in a different manner anyway, since this would mess with portals (or the other way around).

@VReaperV
Copy link
Contributor Author

VReaperV commented Jan 9, 2025

This is also not too useful with how it was implemented, since it will just give the amount of times pixels were modified, whether through depth pre-pass, or blended surfaces. A more useful approach would be to instead just add some constant value to the colour buffer using blend func add. For depth pre-pass we can just have a 2nd mode, which writes colour values during depth pre-pass as well (similar to how I've done with the subgroup profiler).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant