The following sections list the changes in reva 1.24.0 relevant to reva users. The changes are ordered by importance.
- Fix #3805: Apps: fixed viewMode resolution
- Fix #3771: Fix files sharing capabilities
- Fix #3749: Fix persisting updates of received shares in json driver
- Fix #3723: Fix revad docker images by enabling CGO
- Fix #3765: Fix create version folder in EOS driver
- Fix #3786: Fix listing directory for a read-only shares for EOS storage driver
- Fix #3787: Fix application flag for EOS binary
- Fix #3780: Fix Makefile error on Ubuntu
- Fix #3873: Fix parsing of grappa response
- Fix #3794: Fix unshare for EOS storage driver
- Fix #3838: Fix upload in a single file share for lightweight accounts
- Fix #3878: Fix creator/initiator in public and user shares
- Fix #3813: Fix propfind URL for OCM shares
- Fix #3770: Fixed default protocol on ocm-share-create
- Fix #3852: Pass remote share id and shared secret in OCM call
- Fix #3859: Fix inconsistency between data transfer protocol naming
- Enh #3847: Update data transfers for current OCM shares implementation
- Enh #3869: Datatx tutorial
- Enh #3762: Denial and Resharing Default capabilities
- Enh #3717: Disable sharing on low level paths
- Enh #3766: Download file revisions
- Enh #3733: Add support for static linking
- Enh #3778: Add support to tag eos traffic
- Enh #3868: Implement historical way of constructing OCM WebDAV URL
- Enh #3719: Skip computing groups when fetching all groups from grappa
- Enh #3783: Updated OCM tutorial
- Enh #3750: New metadata flags
- Enh #3839: Support multiple issuer in OIDC auth driver
- Enh #3772: New OCM discovery endpoint
- Enh #3619: Tests for invitation manager SQL driver
- Enh #3757: Support OCM v1.0 schema
- Enh #3695: Create OCM share from sciencemesh service
- Enh #3722: List only valid OCM tokens
- Enh #3821: Revamp user/group drivers and fix user type
- Enh #3724: Send invitation link from mesh directory
- Enh #3824: Serverless Services
-
Bugfix #3805: Apps: fixed viewMode resolution
Currently, the viewMode passed on /app/open is taken without validating the actual user's permissions. This PR fixes this.
-
Bugfix #3771: Fix files sharing capabilities
A bug was preventing setting some capabilities (ResharingDefault and DenyAccess) for files sharing from the configuration file
-
Bugfix #3749: Fix persisting updates of received shares in json driver
-
Bugfix #3723: Fix revad docker images by enabling CGO
-
Bugfix #3765: Fix create version folder in EOS driver
In a read only share, a stat could fail, beacause the EOS storage driver was not able to create the version folder for a file in case this did not exist. This fixes this bug impersonating the owner of the file when creating the version folder.
-
Bugfix #3786: Fix listing directory for a read-only shares for EOS storage driver
In a read-only share, while listing a folder, for resources not having a version folder, the returned resource id was wrongly the one of the original file, instead of the version folder. This behavior has been fixed, where the version folder is always created on behalf of the resource owner.
-
Bugfix #3787: Fix application flag for EOS binary
-
Bugfix #3780: Fix Makefile error on Ubuntu
I've fixed Makefile using sh which is defaulted to dash in ubuntu, dash doesn't support
[[ ... ]]syntax and Makefile would throw/bin/sh: 1: [[: not founderrors. -
Bugfix #3873: Fix parsing of grappa response
-
Bugfix #3794: Fix unshare for EOS storage driver
In the EOS storage driver, the remove acl operation was a no-op. After removing a share, the recipient of the share was still able to operate on the shared resource. Now this has been fixed, removing correctly the ACL from the shared resource.
-
Bugfix #3838: Fix upload in a single file share for lightweight accounts
-
Bugfix #3878: Fix creator/initiator in public and user shares
-
Bugfix #3813: Fix propfind URL for OCM shares
-
Bugfix #3770: Fixed default protocol on ocm-share-create
-
Bugfix #3852: Pass remote share id and shared secret in OCM call
-
Bugfix #3859: Fix inconsistency between data transfer protocol naming
-
Enhancement #3847: Update data transfers for current OCM shares implementation
-
Enhancement #3869: Datatx tutorial
-
Enhancement #3762: Denial and Resharing Default capabilities
-
Enhancement #3717: Disable sharing on low level paths
Sharing can be disable in the user share provider for some paths, but the storage provider was still sending the sharing permissions for those paths. This adds a config option in the storage provider,
minimum_allowed_path_level_for_share, to disable sharing permissions for resources up to a defined path level. -
Enhancement #3766: Download file revisions
Currently it is only possible to restore a file version, replacing the actual file with the selected version. This allows an user to download a version file, without touching/replacing the last version of the file
-
Enhancement #3733: Add support for static linking
We've added support for compiling reva with static linking enabled. It's possible to do so with the
STATICflag:make revad STATIC=true -
Enhancement #3778: Add support to tag eos traffic
We've added support to tag eos traffic
-
Enhancement #3868: Implement historical way of constructing OCM WebDAV URL
Expose the expected WebDAV endpoint for OCM by OC10 and Nextcloud as described in cs3org/OCM-API#70 (comment) to allow reva providers to participate to mesh.
-
Enhancement #3719: Skip computing groups when fetching all groups from grappa
-
Enhancement #3783: Updated OCM tutorial
The OCM tutorial in the doc was missing the example on how to access the received resources. Now the tutorial contains all the steps to access a received resource using the WebDAV protocol.
-
Enhancement #3750: New metadata flags
Several new flags, like site infrastructure and service status, are now gathered and exposed by Mentix.
-
Enhancement #3839: Support multiple issuer in OIDC auth driver
The OIDC auth driver supports now multiple issuers. Users of external providers are then mapped to a local user by a mapping files. Only the main issuer (defined in the config with
issuer) and the ones defined in the mapping are allowed for the verification of the OIDC token. -
Enhancement #3772: New OCM discovery endpoint
This PR implements the new OCM v1.1 specifications for the /ocm-provider endpoint.
-
Enhancement #3619: Tests for invitation manager SQL driver
-
Enhancement #3757: Support OCM v1.0 schema
Following cs3org/cs3apis#206, we add the fields to ensure backwards compatibility with OCM v1.0. However, if the
protocol.optionsundocumented object is not empty, we bail out for now. Supporting interoperability with OCM v1.0 implementations (notably Nextcloud 25) may come in the future if the undocumented options are fully reverse engineered. This is reflected in the unit tests as well.Also, added viewMode to webapp protocol options (cs3org/cs3apis#207) and adapted all SQL code and unit tests.
-
Enhancement #3695: Create OCM share from sciencemesh service
-
Enhancement #3722: List only valid OCM tokens
-
Enhancement #3821: Revamp user/group drivers and fix user type
For lightweight accounts
- Fix the user type for lightweight accounts, using the source field to differentiate between a
primary and lw account * Remove all the code with manual parsing of the json returned by the CERN
provider * Introduce pagination for
GetMembersmethod in the group driver * Reduced network transfer size by requesting only needed fields forGetMembersmethod
- Fix the user type for lightweight accounts, using the source field to differentiate between a
primary and lw account * Remove all the code with manual parsing of the json returned by the CERN
provider * Introduce pagination for
-
Enhancement #3724: Send invitation link from mesh directory
When generating and listing OCM tokens
To enhance user expirience, instead of only sending the token, we send directly the URL for accepting the invitation workflow.
-
Enhancement #3824: Serverless Services
New type of service (along with http and grpc) which does not have a listening server. Useful for the notifications service and others in the future.
The following sections list the changes in reva 1.23.0 relevant to reva users. The changes are ordered by importance.
- Fix #3621: Use 2700 as permission when creating EOS home folder
- Fix #3551: Fixes implementation omission of #3526
- Fix #3706: Fix revad-eos docker image which was failing to build
- Fix #3626: Fix open in app for lightweight accounts
- Fix #3613: Use subject from oidc userinfo when quering the user provider
- Fix #3633: Fix litmus and acceptance tests in GitHub Actions
- Fix #3694: Updated public links URLs and users' display names in WOPI apps
- Chg #3553: Rename PullTransfer to CreateTransfer
- Enh #3584: Bump the Copyright date to 2023
- Enh #3640: Migrate acceptance tests from Drone to GitHub Actions
- Enh #3629: Use cs3org/behat:latest docker image for tests
- Enh #3608: Add Golang test coverage report for Codacy
- Enh #3599: Add latest tag to revad Docker image with GitHub Actions
- Enh #3713: Streamline EOS SSS and UNIX modes
- Enh #3566: Migrate the litmusOcisSpacesDav test from Drone to GitHub Actions
- Enh #3712: Improve Docker build speed and Docker Compose test speed
- Enh #3630: Migrate the virtualViews test from Drone to GitHub Actions
- Enh #3675: Cleanup unused configs in OCM HTTP service
- Enh #3692: Create and list OCM shares in OCS layer
- Enh #3666: Search OCM accepted users
- Enh #3665: List valid OCM invite tokens
- Enh #3617: SQL driver for OCM invitation manager
- Enh #3667: List OCM providers
- Enh #3668: Expose OCM received shares as a local mount
- Enh #3683: Remote open in app in OCM
- Enh #3654: SQL driver for OCM shares
- Enh #3646: Update OCM shares to last version of CS3APIs
- Enh #3687: Specify recipient as a query param when sending OCM token by email
- Enh #3691: Add OCM scope and webdav endpoint
- Enh #3611: Revamp OCM invitation workflow
- Enh #3703: Bump reva(d) base image to alpine 3.17
-
Bugfix #3621: Use 2700 as permission when creating EOS home folder
-
Bugfix #3551: Fixes implementation omission of #3526
In #3526 a new value format of the owner parameter of the ocm share request was introduced. This change was not implemented in the json driver. This change fixes that.
-
Bugfix #3706: Fix revad-eos docker image which was failing to build
-
Bugfix #3626: Fix open in app for lightweight accounts
-
Bugfix #3613: Use subject from oidc userinfo when quering the user provider
-
Bugfix #3633: Fix litmus and acceptance tests in GitHub Actions
-
Bugfix #3694: Updated public links URLs and users' display names in WOPI apps
Public links have changed in the frontend and are reflected in folderurl query parameter. Additionally, OCM shares are supported for the folderurl and OCM users are decorated with their ID provider.
-
Change #3553: Rename PullTransfer to CreateTransfer
This change implements a CS3APIs name change in the datatx module (PullTransfer to CreateTransfer)
-
Enhancement #3584: Bump the Copyright date to 2023
-
Enhancement #3640: Migrate acceptance tests from Drone to GitHub Actions
Migrate ocisIntegrationTests and s3ngIntegrationTests to GitHub Actions
-
Enhancement #3629: Use cs3org/behat:latest docker image for tests
-
Enhancement #3608: Add Golang test coverage report for Codacy
-
Enhancement #3599: Add latest tag to revad Docker image with GitHub Actions
-
Enhancement #3713: Streamline EOS SSS and UNIX modes
-
Enhancement #3566: Migrate the litmusOcisSpacesDav test from Drone to GitHub Actions
-
Enhancement #3712: Improve Docker build speed and Docker Compose test speed
-
Enhancement #3630: Migrate the virtualViews test from Drone to GitHub Actions
-
Enhancement #3675: Cleanup unused configs in OCM HTTP service
-
Enhancement #3692: Create and list OCM shares in OCS layer
-
Enhancement #3666: Search OCM accepted users
Adds the prefix
sm:to the FindUser endpoint, to filter only the OCM accepted users. -
Enhancement #3665: List valid OCM invite tokens
Adds the endpoint
/list-invitein the sciencemesh service, to get the list of valid OCM invite tokens. -
Enhancement #3617: SQL driver for OCM invitation manager
-
Enhancement #3667: List OCM providers
Adds the endpoint
/list-providersin the sciencemesh service, to get a filtered list of the OCM providers. The filter can be specified with thesearchquery parameters, and filters by domain and full name of the provider. -
Enhancement #3668: Expose OCM received shares as a local mount
-
Enhancement #3683: Remote open in app in OCM
-
Enhancement #3654: SQL driver for OCM shares
-
Enhancement #3646: Update OCM shares to last version of CS3APIs
-
Enhancement #3687: Specify recipient as a query param when sending OCM token by email
Before the email recipient when sending the OCM token was specified as a form parameter. Now as a query parameter, as some clients does not allow in a GET request to set form values. It also add the possibility to specify a template for the subject and the body for the token email.
-
Enhancement #3691: Add OCM scope and webdav endpoint
Adds the OCM scope and the ocmshares authentication, to authenticate the federated user to use the OCM shared resources. It also adds the (unprotected) webdav endpoint used to interact with the shared resources.
-
Enhancement #3611: Revamp OCM invitation workflow
-
Enhancement #3703: Bump reva(d) base image to alpine 3.17
Prevents several vulnerabilities from the base image itself: https://artifacthub.io/packages/helm/cs3org/revad?modal=security-report
The following sections list the changes in reva 1.22.0 relevant to reva users. The changes are ordered by importance.
- Fix #3528: Fix expired authenticated public link error code
- Fix #3121: Add missing domain normalization to mentix provider authorizer
- Enh #3565: Migrate the litmus tests from Drone to GitHub Actions
-
Bugfix #3528: Fix expired authenticated public link error code
On an expired authenticated public link, the error returned was 401 unauthorized, behaving differently from a not-authenticated one, that returns 404 not found. This has been fixed, returning 404 not found.
-
Bugfix #3121: Add missing domain normalization to mentix provider authorizer
The Mentix OCM Provider authorizer lacked provider domain normalization. This led to incorrect provider domain matching when authorizing OCM providers.
-
Enhancement #3565: Migrate the litmus tests from Drone to GitHub Actions
We've migrated the litmusOcisOldWebdav and the litmusOcisNewWebdav tests from Drone to GitHub Actions.
The following sections list the changes in reva 1.21.0 relevant to reva users. The changes are ordered by importance.
- Fix #3492: Fixes the DefaultQuotaBytes in EOS
- Fix #3420: EOS grpc fixes
- Fix #3501: Fix errors of public share provider according to cs3apis
- Fix #3504: Fix RefreshLock method for cephfs storage driver
- Enh #3502: Appproviders: pass other query parameters as Opaque
- Enh #3028: Access directly auth registry rules map when getting provider
- Enh #3197: Bring back multi-stage build to save on image size
- Enh #3506: Migrate the buildAndPublishDocker job from Drone to GitHub Actions
- Enh #3500: Migrate the BuildOnly job from Drone to GitHub Actions
- Enh #3513: Migrate the testIntegration job from Drone to GitHub Actions
- Enh #3494: Implemented folderurl for WOPI apps
- Enh #3507: Get user preferred language
- Enh #3530: Improve error logging in ocmd flow
- Enh #3491: Implement rclone third-party copy push option
- Enh #3508: Allow an user to set a preferred language
-
Bugfix #3492: Fixes the DefaultQuotaBytes in EOS
We were setting the default logical quota to 1T, resulting on only 500GB available to the user.
-
Bugfix #3420: EOS grpc fixes
The shares and the applications were not working with the EOS grpc storage driver. This fixes both.
-
Bugfix #3501: Fix errors of public share provider according to cs3apis
All the errors returned by the public share provider where internal errors. Now this has been fixed and the returned errors are the one defined in the cs3apis.
-
Bugfix #3504: Fix RefreshLock method for cephfs storage driver
-
Enhancement #3502: Appproviders: pass other query parameters as Opaque
This allows to send any other HTTP query parameter passed to /app/open to the underlying appprovider drivers via GRPC
-
Enhancement #3028: Access directly auth registry rules map when getting provider
-
Enhancement #3197: Bring back multi-stage build to save on image size
- Use EOS 4.8.91 as base image - Bring back multi-stage build - Build revad on the eos 4.8.91 image
due to missing dependency (
ld-musl-x86_64.so.1, typical of alpine) - Copy the resulting revad from the builder container
Resulting image size (unpacked on disk) is 2.59GB - eos-all:4.8.91 is 2.47GB - existing revad:latest-eos is 6.18GB
- Use EOS 4.8.91 as base image - Bring back multi-stage build - Build revad on the eos 4.8.91 image
due to missing dependency (
-
Enhancement #3506: Migrate the buildAndPublishDocker job from Drone to GitHub Actions
We've migrated the buildAndPublishDocker job from Drone to GitHub Actions workflow. We've updated the Golang version used to build the Docker images to go1.19. We've fixed the Cephfs storage module. We've improved the Makefile. We've refactored the build-docker workflow.
-
Enhancement #3500: Migrate the BuildOnly job from Drone to GitHub Actions
We've migrated the BuildOnly job from Drone to GitHub Actions workflow. The Workflow builds and Tests Reva, builds a Revad Docker Image and checks the license headers. The license header tools was removed since the goheader linter provides the same functionality.
-
Enhancement #3513: Migrate the testIntegration job from Drone to GitHub Actions
-
Enhancement #3494: Implemented folderurl for WOPI apps
The folderurl is now populated for WOPI apps, such that for owners and named shares it points to the containing folder, and for public links it points to the appropriate public link URL.
On the way, functions to manipulate the user's scope and extract the eventual public link token(s) have been added, coauthored with @gmgigi96.
-
Enhancement #3507: Get user preferred language
The only way for an OCIS web user to change language was to set it into the browser settings. In the ocs user info response, a field
languageis added, to change their language in the UI, regardless of the browser settings. -
Enhancement #3530: Improve error logging in ocmd flow
-
Enhancement #3491: Implement rclone third-party copy push option
This enhancement gives the option to use third-party copy push with rclone between two different user accounts.
-
Enhancement #3508: Allow an user to set a preferred language
The following sections list the changes in reva 1.20.0 relevant to reva users. The changes are ordered by importance.
- Sec #3316: Mitigate XSS
- Fix #3455: Fixes panic in case of empty configuration
- Fix #3311: Remove FIXME
- Fix #3396: Fix the Ceph Docker image repository URL
- Fix #3055: Fix quota for LW accounts
- Fix #3361: Use custom reva logger in ocs
- Fix #3344: Fix quota percentage
- Fix #2979: Removed unused datatx code
- Fix #2973: Fix datatxtarget uri when prefix is used
- Fix #3319: Fix oidc provider crash when custom claims are provided
- Fix #3481: OIDC: resolve users with no uid/gid by username
- Fix #3055: Get user from user provider in oidc driver
- Fix #3053: Temporary read user acl instead of sys acl
- Enh #3401: Make WOPI bridged apps (CodiMD) configuration non hard-coded
- Enh #3402: Block users
- Enh #3098: App provider http endpoint uses Form instead of Query
- Enh #3116: Implementation of cback storage driver for REVA
- Enh #3422: Migrate Codacy from Drone to Codacy/GitHub integration
- Enh #3412: Migrate Fossa from Drone to Github Integration
- Enh #3367: Update go version
- Enh #3467: Enable gocritic linter in golangci-lint and solve issues
- Enh #3463: Enable gofmt linter in golangci-lint and apply gofmt
- Enh #3471: Enable goimports and usestdlibvars in golangci-lint
- Enh #3466: Migrate golangci-lint from Drone to GitHub Actions
- Enh #3465: Enable revive linter in golangci-lint and solve issues
- Enh #3487: Enable staticcheck linter in golangci-lint and solve issues
- Enh #3475: Enable the style linters
- Enh #3070: Allow http service to expose prefixes containing /
- Enh #2986: Better display name in apps for all user types
- Enh #3303: Added support for configuring language locales in apps
- Enh #3348: Revamp lightweigth accounts
- Enh #3304: Add http service to send email for shares
- Enh #3072: Mesh meta data operators
- Enh #3313: Fix content-type for OCM sharing
- Enh #3234: Add post create home hook for eos storage driver
- Enh #3347: Implemented PROPFIND with 0 depth
- Enh #3056: Add public share auth provider
- Enh #3305: Add description to public link
- Enh #3163: Add support for quicklinks for public shares
- Enh #3289: Make Refresh Lock operation WOPI compliant
- Enh #3315: Accept reva token as a bearer authentication
- Enh #3438: Sanitize non-utf8 characters in xattr values in EOS
- Enh #3221: Site Accounts improvements
- Enh #3404: Site accounts & Mentix updates
- Enh #3424: Expire tokens on sunday
- Enh #2986: Use email as display name for external users opening WOPI apps
-
Security #3316: Mitigate XSS
We've mitigated an XSS vulnerability resulting from unescaped HTTP responses containing user-provided values in pkg/siteacc/siteacc.go and internal/http/services/ocmd/invites.go. This patch uses html.EscapeString to escape the user-provided values in the HTTP responses of pkg/siteacc/siteacc.go and internal/http/services/ocmd/invites.go.
-
Bugfix #3455: Fixes panic in case of empty configuration
Makes sure the config map is allocated prior to setting it
-
Bugfix #3311: Remove FIXME
Issue cs3org#2402 is closed.
-
Bugfix #3396: Fix the Ceph Docker image repository URL
-
Bugfix #3055: Fix quota for LW accounts
LW accounts do not have quota assigned.
-
Bugfix #3361: Use custom reva logger in ocs
-
Bugfix #3344: Fix quota percentage
-
Bugfix #2979: Removed unused datatx code
An OCM reference is not created for a data transfer type share.
-
Bugfix #2973: Fix datatxtarget uri when prefix is used
When a webdav prefix is used it appears in both host and name parameter of the target uri for data transfer. This PR fixes that.
-
Bugfix #3319: Fix oidc provider crash when custom claims are provided
-
Bugfix #3481: OIDC: resolve users with no uid/gid by username
Previously we resolved such users (so called "lightweight" or "external" accounts in the CERN realm) by email, but it turns out that the same email may have multiple accounts associated to it.
Therefore we now resolve them by username, that is the upn, which is unique.
-
Bugfix #3055: Get user from user provider in oidc driver
For oidc providers that only respond with standard claims, use the user provider to get the user.
-
Bugfix #3053: Temporary read user acl instead of sys acl
We read the user acl in EOS until the migration of all user acls to sys acls are done
-
Enhancement #3401: Make WOPI bridged apps (CodiMD) configuration non hard-coded
The configuration of the custom mimetypes has been moved to the AppProvider, and the given mimetypes are used to configure bridged apps by sharing the corresponding config item to the drivers.
-
Enhancement #3402: Block users
Allows an operator to set a list of users that are banned for every operation in reva.
-
Enhancement #3098: App provider http endpoint uses Form instead of Query
We've improved the http endpoint now uses the Form instead of Query to also support
application/x-www-form-urlencodedparameters on the app provider http endpoint. -
Enhancement #3116: Implementation of cback storage driver for REVA
This is a read only fs interface.
-
Enhancement #3422: Migrate Codacy from Drone to Codacy/GitHub integration
-
Enhancement #3412: Migrate Fossa from Drone to Github Integration
-
Enhancement #3367: Update go version
Update go version to 1.19 in go.mod
-
Enhancement #3467: Enable gocritic linter in golangci-lint and solve issues
-
Enhancement #3463: Enable gofmt linter in golangci-lint and apply gofmt
-
Enhancement #3471: Enable goimports and usestdlibvars in golangci-lint
We've enabled the goimports and usestdlibvars linters in golangci-lint and solved the related issues.
-
Enhancement #3466: Migrate golangci-lint from Drone to GitHub Actions
-
Enhancement #3465: Enable revive linter in golangci-lint and solve issues
-
Enhancement #3487: Enable staticcheck linter in golangci-lint and solve issues
-
Enhancement #3475: Enable the style linters
We've enabled the stylecheck, whitespace, dupword, godot and dogsled linters in golangci-lint and solved the related issues.
-
Enhancement #3070: Allow http service to expose prefixes containing /
-
Enhancement #2986: Better display name in apps for all user types
This includes a
FirstName FamilyName (domain)format for non-primary accounts, and a sanitization of the email address claim for such non-primary accounts. -
Enhancement #3303: Added support for configuring language locales in apps
This is a partial backport from edge: we introduce a language option in the appprovider, which if set is passed as appropriate parameter to the external apps in order to force a given localization. In particular, for Microsoft Office 365 the DC_LLCC option is set as well. The default behavior is unset, where apps try and resolve the localization from the browser headers.
-
Enhancement #3348: Revamp lightweigth accounts
Re-implements the lighweight account scope check, making it more efficient. Also, the ACLs for the EOS storage driver for the lw accounts are set atomically.
-
Enhancement #3304: Add http service to send email for shares
-
Enhancement #3072: Mesh meta data operators
To better support sites that run multiple instances, the meta data have been extended to include a new hierarchy layer called 'operators'. This PR brings all necessary changes in the Mentix and site accounts services.
-
Enhancement #3313: Fix content-type for OCM sharing
This fix change the content type to just "application/json"
-
Enhancement #3234: Add post create home hook for eos storage driver
-
Enhancement #3347: Implemented PROPFIND with 0 depth
-
Enhancement #3056: Add public share auth provider
Add a public share auth middleware
-
Enhancement #3305: Add description to public link
-
Enhancement #3163: Add support for quicklinks for public shares
-
Enhancement #3289: Make Refresh Lock operation WOPI compliant
We now support the WOPI compliant
UnlockAndRelockoperation. This has been implemented in the Eos FS. To make use of it, we need a compatible WOPI server.cs3org#3289 https://learn.microsoft.com/en-us/microsoft-365/cloud-storage-partner-program/rest/files/unlockandrelock
-
Enhancement #3315: Accept reva token as a bearer authentication
-
Enhancement #3438: Sanitize non-utf8 characters in xattr values in EOS
-
Enhancement #3221: Site Accounts improvements
The site accounts admin panel has been reworked and now also shows which sites aren't configured properly yet. Furthermore, a bug that prevented users from changing site configurations has been fixed.
-
Enhancement #3404: Site accounts & Mentix updates
Some small improvements to the Site Accounts and Mentix services, including normalization of data exposed at the
/cs3endpoint of Mentix. -
Enhancement #3424: Expire tokens on sunday
-
Enhancement #2986: Use email as display name for external users opening WOPI apps
We use now the email claim for external/federated accounts as the
usernamethat is then passed to the wopiserver and used asdisplayNamein the WOPI context.
The following sections list the changes in reva 1.19.0 relevant to reva users. The changes are ordered by importance.
- Fix #2693: Support editnew actions from MS Office
- Fix #2588: Dockerfile.revad-ceph to use the right base image
- Fix #2216: Make hardcoded HTTP "insecure" options configurable
- Fix #2860: Use
eos-allparent image - Fix #2499: Removed check DenyGrant in resource permission
- Fix #2712: Update Dockerfile.revad.eos to not break the image
- Fix #2789: Minor fixes in cephfs and eosfs
- Fix #2285: Accept new userid idp format
- Fix #2608: Respect the tracing_service_name config variable
- Fix #2841: Refactors logger to have ctx
- Fix #2759: Made uid, gid claims parsing more robust in OIDC auth provider
- Fix #2842: Fix download action in SDK
- Fix #2555: Fix site accounts endpoints
- Fix #2675: Updates Makefile according to latest go standards
- Fix #2572: Wait for nats server on middleware start
- Chg #2596: Remove hash from public link urls
- Chg #2559: Do not encode webDAV ids to base64
- Chg #2561: Merge oidcmapping auth manager into oidc
- Enh #2698: Make capabilities endpoint public, authenticate users is present
- Enh #2813: Support custom mimetypes in the WOPI appprovider driver
- Enh #2515: Enabling tracing by default if not explicitly disabled
- Enh #160: Implement the CS3 Lock API in the EOS storage driver
- Enh #2686: Features for favorites xattrs in EOS, cache for scope expansion
- Enh #2494: Use sys ACLs for file permissions
- Enh #2522: Introduce events
- Enh #2685: Enable federated account access
- Enh #2801: Use functional options for client gRPC connections
- Enh #2921: Use standard header for checksums
- Enh #2480: Group based capabilities
- Enh #1787: Add support for HTTP TPC
- Enh #2560: Mentix PromSD extensions
- Enh #2613: Externalize custom mime types configuration for storage providers
- Enh #2163: Nextcloud-based share manager for pkg/ocm/share
- Enh #2696: Preferences driver refactor and cbox sql implementation
- Enh #2052: New CS3API datatx methods
- Enh #2738: Site accounts site-global settings
- Enh #2672: Further Site Accounts improvements
- Enh #2549: Site accounts improvements
- Enh #2488: Cephfs support keyrings with IDs
- Enh #2514: Reuse ocs role objects in other drivers
- Enh #2752: Refactor the rest user and group provider drivers
- Enh #2946: Make user share indicators read from the share provider service
-
Bugfix #2693: Support editnew actions from MS Office
This fixes the incorrect behavior when creating new xlsx and pptx files, as MS Office supports the editnew action and it must be used for newly created files instead of the normal edit action.
-
Bugfix #2588: Dockerfile.revad-ceph to use the right base image
In Aug2021 https://hub.docker.com/r/ceph/daemon-base was moved to quay.ceph.io and the builds for this image were failing for some weeks after January.
-
Bugfix #2216: Make hardcoded HTTP "insecure" options configurable
HTTP "insecure" options must be configurable and default to false.
-
Bugfix #2860: Use
eos-allparent image -
Bugfix #2499: Removed check DenyGrant in resource permission
When adding a denial permission
-
Bugfix #2712: Update Dockerfile.revad.eos to not break the image
-
Bugfix #2789: Minor fixes in cephfs and eosfs
-
Bugfix #2285: Accept new userid idp format
The format for userid idp changed and this broke the ocmd tutorial This PR makes the provider authorizer interceptor accept both the old and the new string format.
cs3org#2285 cs3org#2285 See and
-
Bugfix #2608: Respect the tracing_service_name config variable
-
Bugfix #2841: Refactors logger to have ctx
This fixes the native library loggers which are not associated with the context and thus are not handled properly in the reva runtime.
-
Bugfix #2759: Made uid, gid claims parsing more robust in OIDC auth provider
This fix makes sure the uid and gid claims are defined at init time, and that the necessary typecasts are performed correctly when authenticating users. A comment was added that in case the uid/gid claims are missing AND that no mapping takes place, a user entity is returned with uid = gid = 0.
-
Bugfix #2842: Fix download action in SDK
The download action was no longer working in the SDK (used by our testing probes); this PR fixes the underlying issue.
-
Bugfix #2555: Fix site accounts endpoints
This PR fixes small bugs in the site accounts endpoints.
-
Bugfix #2675: Updates Makefile according to latest go standards
Earlier, we were using go get to install packages. Now, we are using go install to install packages
-
Bugfix #2572: Wait for nats server on middleware start
Use a retry mechanism to connect to the nats server when it is not ready yet
-
Change #2596: Remove hash from public link urls
Public link urls do not contain the hash anymore, this is needed to support the ocis and web history mode.
-
Change #2559: Do not encode webDAV ids to base64
We removed the base64 encoding of the IDs and use the format ! with a
!delimiter. As a reserved delimiter it is URL safe. The IDs will be XML and JSON encoded as necessary. -
Change #2561: Merge oidcmapping auth manager into oidc
The oidcmapping auth manager was created as a separate package to ease testing. As it has now been tested also as a pure OIDC auth provider without mapping, and as the code is largely refactored, it makes sense to merge it back so to maintain a single OIDC manager.
-
Enhancement #2698: Make capabilities endpoint public, authenticate users is present
-
Enhancement #2813: Support custom mimetypes in the WOPI appprovider driver
Similarly to the storage provider, also the WOPI appprovider driver now supports custom mime types. Also fixed a small typo.
-
Enhancement #2515: Enabling tracing by default if not explicitly disabled
-
Enhancement #160: Implement the CS3 Lock API in the EOS storage driver
-
Enhancement #2686: Features for favorites xattrs in EOS, cache for scope expansion
-
Enhancement #2494: Use sys ACLs for file permissions
-
Enhancement #2522: Introduce events
This will introduce events into the system. Events are a simple way to bring information from one service to another. Read
pkg/events/exampleand subfolders for more information -
Enhancement #2685: Enable federated account access
-
Enhancement #2801: Use functional options for client gRPC connections
This will add more ability to configure the client side gRPC connections.
-
Enhancement #2921: Use standard header for checksums
On HEAD requests, we currently expose checksums (when available) using the ownCloud-specific header, which is typically consumed by the sync clients.
This patch adds the standard Digest header using the standard format detailed at https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Digest. This is e.g. used by GFAL/Rucio clients in the context of managed transfers of datasets.
-
Enhancement #2480: Group based capabilities
We can now return specific capabilities for users who belong to certain configured groups.
-
Enhancement #1787: Add support for HTTP TPC
We have added support for HTTP Third Party Copy. This allows remote data transfers between storages managed by either two different reva servers, or a reva server and a Grid (WLCG/ESCAPE) site server.
Such remote transfers are expected to be driven by GFAL, the underlying library used by FTS, and Rucio.
In addition, the oidcmapping package has been refactored to support the standard OIDC use cases as well when no mapping is defined.
-
Enhancement #2560: Mentix PromSD extensions
The Mentix Prometheus SD scrape targets are now split into one file per service type, making health checks configuration easier. Furthermore, the local file connector for mesh data and the site registration endpoint have been dropped, as they aren't needed anymore.
-
Enhancement #2613: Externalize custom mime types configuration for storage providers
Added ability to configure custom mime types in an external JSON file, such that it can be reused when many storage providers are deployed at the same time.
-
Enhancement #2163: Nextcloud-based share manager for pkg/ocm/share
Note that pkg/ocm/share is very similar to pkg/share, but it deals with cs3/sharing/ocm whereas pkg/share deals with cs3/sharing/collaboration
-
Enhancement #2696: Preferences driver refactor and cbox sql implementation
This PR uses the updated CS3APIs which accepts a namespace in addition to a single string key to recognize a user preference. It also refactors the GRPC service to support multiple drivers and adds the cbox SQL implementation.
-
Enhancement #2052: New CS3API datatx methods
CS3 datatx pull model methods: PullTransfer, RetryTransfer, ListTransfers Method CreateTransfer removed.
-
Enhancement #2738: Site accounts site-global settings
This PR extends the site accounts service by adding site-global settings. These are used to store test user credentials that are in return used by our BBE port to perform CS3API-specific health checks.
-
Enhancement #2672: Further Site Accounts improvements
Yet another PR to update the site accounts (and Mentix): New default site ID; Include service type in alerts; Naming unified; Remove obsolete stuff.
-
Enhancement #2549: Site accounts improvements
This PR improves the site accounts: - Removed/hid API key stuff - Added quick links to the main panel - Made alert notifications mandatory
-
Enhancement #2488: Cephfs support keyrings with IDs
-
Enhancement #2514: Reuse ocs role objects in other drivers
-
Enhancement #2752: Refactor the rest user and group provider drivers
We now maintain our own cache for all user and group data, and periodically refresh it. A redis server now becomes a necessary dependency, whereas it was optional previously.
-
Enhancement #2946: Make user share indicators read from the share provider service
The following sections list the changes in reva 1.18.0 relevant to reva users. The changes are ordered by importance.
- Fix #2370: Fixes for apps in public shares, project spaces for EOS driver
- Fix #2374: Fix webdav copy of zero byte files
- Fix #2478: Use ocs permission objects in the reva GRPC client
- Fix #2368: Return wrapped paths for recycled items in storage provider
- Chg #2354: Return not found when updating non existent space
- Enh #1209: Reva CephFS module v0.2.1
- Enh #2341: Use CS3 permissions API
- Enh #2350: Add file locking methods to the storage and filesystem interfaces
- Enh #2379: Add new file url of the app provider to the ocs capabilities
- Enh #2369: Implement TouchFile from the CS3apis
- Enh #2385: Allow to create new files with the app provider on public links
- Enh #2397: Product field in OCS version
- Enh #2393: Update tus/tusd to version 1.8.0
- Enh #2205: Modify group and user managers to skip fetching specified metadata
- Enh #2232: Make ocs resource info cache interoperable across drivers
- Enh #2278: OIDC driver changes for lightweight users
-
Bugfix #2370: Fixes for apps in public shares, project spaces for EOS driver
-
Bugfix #2374: Fix webdav copy of zero byte files
We've fixed the webdav copy action of zero byte files, which was not performed because the webdav api assumed, that zero byte uploads are created when initiating the upload, which was recently removed from all storage drivers. Therefore the webdav api also uploads zero byte files after initiating the upload.
-
Bugfix #2478: Use ocs permission objects in the reva GRPC client
There was a bug introduced by differing CS3APIs permission definitions for the same role across services. This is a first step in making all services use consistent definitions.
-
Bugfix #2368: Return wrapped paths for recycled items in storage provider
-
Change #2354: Return not found when updating non existent space
If a spaceid of a space which is updated doesn't exist, handle it as a not found error.
-
Enhancement #1209: Reva CephFS module v0.2.1
-
Enhancement #2341: Use CS3 permissions API
Added calls to the CS3 permissions API to the decomposedfs in order to check the user permissions.
-
Enhancement #2350: Add file locking methods to the storage and filesystem interfaces
We've added the file locking methods from the CS3apis to the storage and filesystem interfaces. As of now they are dummy implementations and will only return "unimplemented" errors.
-
Enhancement #2379: Add new file url of the app provider to the ocs capabilities
We've added the new file capability of the app provider to the ocs capabilities, so that clients can discover this url analogous to the app list and file open urls.
-
Enhancement #2369: Implement TouchFile from the CS3apis
We've updated the CS3apis and implemented the TouchFile method.
-
Enhancement #2385: Allow to create new files with the app provider on public links
We've added the option to create files with the app provider on public links.
-
Enhancement #2397: Product field in OCS version
We've added a new field to the OCS Version, which is supposed to announce the product name. The web ui as a client will make use of it to make the backend product and version available (e.g. for easier bug reports).
-
Enhancement #2393: Update tus/tusd to version 1.8.0
We've update tus/tusd to version 1.8.0.
-
Enhancement #2205: Modify group and user managers to skip fetching specified metadata
-
Enhancement #2232: Make ocs resource info cache interoperable across drivers
-
Enhancement #2278: OIDC driver changes for lightweight users
The following sections list the changes in reva 1.17.0 relevant to reva users. The changes are ordered by importance.
- Fix #2305: Make sure /app/new takes
targetas absolute path - Fix #2303: Fix content disposition header for public links files
- Fix #2316: Fix the share types in propfinds
- Fix #2803: Fix app provider for editor public links
- Fix #2298: Remove share refs from trashbin
- Fix #2309: Remove early finish for zero byte file uploads
- Fix #1941: Fix TUS uploads with transfer token only
- Chg #2210: Fix app provider new file creation and improved error codes
- Enh #2217: OIDC auth driver for ESCAPE IAM
- Enh #2256: Return user type in the response of the ocs GET user call
- Enh #2315: Add new attributes to public link propfinds
- Enh #2740: Implement space membership endpoints
- Enh #2252: Add the xattr sys.acl to SysACL (eosgrpc)
- Enh #2314: OIDC: fallback if IDP doesn't provide "preferred_username" claim
-
Bugfix #2305: Make sure /app/new takes
targetas absolute pathA mini-PR to make the
targetparameter absolute (by prepending/if missing). -
Bugfix #2303: Fix content disposition header for public links files
-
Bugfix #2316: Fix the share types in propfinds
The share types for public links were not correctly added to propfinds.
-
Bugfix #2803: Fix app provider for editor public links
Fixed opening the app provider in public links with the editor permission. The app provider failed to open the file in read write mode.
-
Bugfix #2298: Remove share refs from trashbin
-
Bugfix #2309: Remove early finish for zero byte file uploads
We've fixed the upload of zero byte files by removing the early upload finishing mechanism.
-
Bugfix #1941: Fix TUS uploads with transfer token only
TUS uploads had been stopped when the user JWT token expired, even if only the transfer token should be validated. Now uploads will continue as intended.
-
Change #2210: Fix app provider new file creation and improved error codes
We've fixed the behavior for the app provider when creating new files. Previously the app provider would overwrite already existing files when creating a new file, this is now handled and prevented. The new file endpoint accepted a path to a file, but this does not work for spaces. Therefore we now use the resource id of the folder where the file should be created and a filename to create the new file. Also the app provider returns more useful error codes in a lot of cases.
-
Enhancement #2217: OIDC auth driver for ESCAPE IAM
This enhancement allows for oidc token authentication via the ESCAPE IAM service. Authentication relies on mappings of ESCAPE IAM groups to REVA users. For a valid token, if at the most one group from the groups claim is mapped to one REVA user, authentication can take place.
-
Enhancement #2256: Return user type in the response of the ocs GET user call
-
Enhancement #2315: Add new attributes to public link propfinds
Added a new property "oc:signature-auth" to public link propfinds. This is a necessary change to be able to support archive downloads in password protected public links.
-
Enhancement #2740: Implement space membership endpoints
Implemented endpoints to add and remove members to spaces.
-
Enhancement #2252: Add the xattr sys.acl to SysACL (eosgrpc)
-
Enhancement #2314: OIDC: fallback if IDP doesn't provide "preferred_username" claim
Some IDPs don't support the "preferred_username" claim. Fallback to the "email" claim in that case.
The following sections list the changes in reva 1.16.0 relevant to reva users. The changes are ordered by importance.
- Fix #2245: Don't announce search-files capability
- Fix #2247: Merge user ACLs from EOS to sys ACLs
- Fix #2279: Return the inode of the version folder for files when listing in EOS
- Fix #2294: Fix HTTP return code when path is invalid
- Fix #2231: Fix share permission on a single file in sql share driver (cbox pkg)
- Fix #2230: Fix open by default app and expose default app
- Fix #2265: Fix nil pointer exception when resolving members of a group (rest driver)
- Fix #1214: Fix restoring versions
- Fix #2254: Fix spaces propfind
- Fix #2260: Fix unset quota xattr on darwin
- Fix #5776: Enforce permissions in public share apps
- Fix #2767: Fix status code for WebDAV mkcol requests where an ancestor is missing
- Fix #2287: Add public link access via mount-ID:token/relative-path to the scope
- Fix #2244: Fix the permissions response for shared files in the cbox sql driver
- Enh #2219: Add virtual view tests
- Enh #2230: Add priority to app providers
- Enh #2258: Improved error messages from the AppProviders
- Enh #2119: Add authprovider owncloudsql
- Enh #2211: Enhance the cbox share sql driver to store accepted group shares
- Enh #2212: Filter root path according to the agent that makes the request
- Enh #2237: Skip get user call in eosfs in case previous ones also failed
- Enh #2266: Callback for the EOS UID cache to retry fetch for failed keys
- Enh #2215: Aggregrate resource info properties for virtual views
- Enh #2271: Revamp the favorite manager and add the cbox sql driver
- Enh #2248: Cache whether a user home was created or not
- Enh #2282: Return a proper NOT_FOUND error when a user or group is not found
- Enh #2268: Add the reverseproxy http service
- Enh #2207: Enable users to list all spaces
- Enh #2286: Add trace ID to middleware loggers
- Enh #2251: Mentix service inference
- Enh #2218: Allow filtering of mime types supported by app providers
- Enh #2213: Add public link share type to propfind response
- Enh #2253: Support the file editor role for public links
- Enh #2208: Reduce redundant stat calls when statting by resource ID
- Enh #2235: Specify a list of allowed folders/files to be archived
- Enh #2267: Restrict the paths where share creation is allowed
- Enh #2252: Add the xattr sys.acl to SysACL (eosgrpc)
- Enh #2239: Update toml configs
-
Bugfix #2245: Don't announce search-files capability
The
dav.reportscapability contained asearch-filesreport which is currently not implemented. We removed it from the defaults. -
Bugfix #2247: Merge user ACLs from EOS to sys ACLs
-
Bugfix #2279: Return the inode of the version folder for files when listing in EOS
-
Bugfix #2294: Fix HTTP return code when path is invalid
Before when a path was invalid, the archiver returned a 500 error code. Now this is fixed and returns a 404 code.
-
Bugfix #2231: Fix share permission on a single file in sql share driver (cbox pkg)
-
Bugfix #2230: Fix open by default app and expose default app
We've fixed the open by default app name behaviour which previously only worked, if the default app was configured by the provider address. We also now expose the default app on the
/app/listendpoint to clients. -
Bugfix #2265: Fix nil pointer exception when resolving members of a group (rest driver)
-
Bugfix #1214: Fix restoring versions
Restoring a version would not remove that version from the version list. Now the behavior is compatible to ownCloud 10.
-
Bugfix #2254: Fix spaces propfind
Fixed the deep listing of spaces.
-
Bugfix #2260: Fix unset quota xattr on darwin
Unset quota attributes were creating errors in the logfile on darwin.
-
Bugfix #5776: Enforce permissions in public share apps
A receiver of a read-only public share could still edit files via apps like Collabora. These changes enforce the share permissions in apps used on publicly shared resources.
owncloud/web#5776 owncloud/ocis#2479 https://github.com/cs3org/reva/pull/22142214
-
Bugfix #2767: Fix status code for WebDAV mkcol requests where an ancestor is missing
We've fixed the status code to 409 according to the WebDAV standard for MKCOL requests where an ancestor is missing. Previously these requests would fail with an different error code (eg. 500) because of storage driver limitations (eg. oCIS FS cannot handle recursive creation of directories).
-
Bugfix #2287: Add public link access via mount-ID:token/relative-path to the scope
-
Bugfix #2244: Fix the permissions response for shared files in the cbox sql driver
-
Enhancement #2219: Add virtual view tests
-
Enhancement #2230: Add priority to app providers
Before the order of the list returned by the method FindProviders of app providers depended from the order in which the app provider registered themselves. Now, it is possible to specify a priority for each app provider, and even if an app provider re-register itself (for example after a restart), the order is kept.
-
Enhancement #2258: Improved error messages from the AppProviders
Some rather cryptic messages are now hidden to users, and some others are made more user-friendly. Support for multiple locales is still missing and out of scope for now.
-
Enhancement #2119: Add authprovider owncloudsql
We added an authprovider that can be configured to authenticate against an owncloud classic mysql database. It verifies the password from the oc_users table.
-
Enhancement #2211: Enhance the cbox share sql driver to store accepted group shares
-
Enhancement #2212: Filter root path according to the agent that makes the request
-
Enhancement #2237: Skip get user call in eosfs in case previous ones also failed
-
Enhancement #2266: Callback for the EOS UID cache to retry fetch for failed keys
-
Enhancement #2215: Aggregrate resource info properties for virtual views
-
Enhancement #2271: Revamp the favorite manager and add the cbox sql driver
-
Enhancement #2248: Cache whether a user home was created or not
Previously, on every call, we used to stat the user home to make sure that it existed. Now we cache it for a given amount of time so as to avoid repeated calls.
-
Enhancement #2282: Return a proper NOT_FOUND error when a user or group is not found
-
Enhancement #2268: Add the reverseproxy http service
This PR adds an HTTP service which does the job of authenticating incoming requests via the reva middleware before forwarding them to the respective backends. This is useful for extensions which do not have the auth mechanisms.
-
Enhancement #2207: Enable users to list all spaces
Added a permission check if the user has the
list-all-spacespermission. This enables users to list all spaces, even those which they are not members of. -
Enhancement #2286: Add trace ID to middleware loggers
-
Enhancement #2251: Mentix service inference
Previously, 4 different services per site had to be created in the GOCDB. This PR removes this redundancy by infering all endpoints from a single service entity, making site administration a lot easier.
-
Enhancement #2218: Allow filtering of mime types supported by app providers
-
Enhancement #2213: Add public link share type to propfind response
Added share type for public links to propfind responses.
-
Enhancement #2253: Support the file editor role for public links
-
Enhancement #2208: Reduce redundant stat calls when statting by resource ID
-
Enhancement #2235: Specify a list of allowed folders/files to be archived
Adds a configuration to the archiver service in order to specify a list of folders (as regex) that can be archived.
-
Enhancement #2267: Restrict the paths where share creation is allowed
This PR limits share creation to certain specified paths. These can be useful when users have access to global spaces and virtual views but these should not be sharable.
-
Enhancement #2252: Add the xattr sys.acl to SysACL (eosgrpc)
-
Enhancement #2239: Update toml configs
We updated the local and drone configurations, cleanad up the example configs and removed the reva gen subcommand which was generating outdated config.
The following sections list the changes in reva 1.15.0 relevant to reva users. The changes are ordered by importance.
- Fix #2168: Override provider if was previously registered
- Fix #2173: Fix archiver max size reached error
- Fix #2167: Handle nil quota in decomposedfs
- Fix #2153: Restrict EOS project spaces sharing permissions to admins and writers
- Fix #2179: Fix the returned permissions for webdav uploads
- Fix #2177: Retrieve the full path of a share when setting as
- Chg #2479: Make apps able to work with public shares
- Enh #2203: Add alerting webhook to SiteAcc service
- Enh #2190: Update CODEOWNERS
- Enh #2174: Inherit ACLs for files from parent directories
- Enh #2152: Add a reference parameter to the getQuota request
- Enh #2171: Add optional claim parameter to machine auth
- Enh #2163: Nextcloud-based share manager for pkg/ocm/share
- Enh #2135: Nextcloud test improvements
- Enh #2180: Remove OCDAV options namespace parameter
- Enh #2117: Add ocs cache warmup strategy for first request from the user
- Enh #2170: Handle propfind requests for existing files
- Enh #2165: Allow access to recycle bin for arbitrary paths outside homes
- Enh #2193: Filter root paths according to user agent
- Enh #2162: Implement the UpdateStorageSpace method
- Enh #2189: Add user setting capability
-
Bugfix #2168: Override provider if was previously registered
Previously if an AppProvider registered himself two times, for example after a failure, the mime types supported by the provider contained multiple times the same provider. Now this has been fixed, overriding the previous one.
-
Bugfix #2173: Fix archiver max size reached error
Previously in the total size count of the files being archived, the folders were taken into account, and this could cause a false max size reached error because the size of a directory is recursive-computed, causing the archive to be truncated. Now in the size count, the directories are skipped.
-
Bugfix #2167: Handle nil quota in decomposedfs
Do not nil pointer derefenrence when sending nil quota to decomposedfs
-
Bugfix #2153: Restrict EOS project spaces sharing permissions to admins and writers
-
Bugfix #2179: Fix the returned permissions for webdav uploads
We've fixed the returned permissions for webdav uploads. It did not consider shares and public links for the permission calculation, but does so now.
-
Bugfix #2177: Retrieve the full path of a share when setting as
Accepted or on shared by me
-
Change #2479: Make apps able to work with public shares
Public share receivers were not possible to use apps in public shares because the apps couldn't load the files in the public shares. This has now been made possible by changing the scope checks for public shares.
-
Enhancement #2203: Add alerting webhook to SiteAcc service
To integrate email alerting with the monitoring pipeline, a Prometheus webhook has been added to the SiteAcc service. Furthermore account settings have been extended/modified accordingly.
-
Enhancement #2190: Update CODEOWNERS
-
Enhancement #2174: Inherit ACLs for files from parent directories
-
Enhancement #2152: Add a reference parameter to the getQuota request
Implementation of cs3org/cs3apis#147
Make the cs3apis accept a Reference in the getQuota Request to limit the call to a specific storage space.
-
Enhancement #2171: Add optional claim parameter to machine auth
-
Enhancement #2163: Nextcloud-based share manager for pkg/ocm/share
Note that pkg/ocm/share is very similar to pkg/share, but it deals with cs3/sharing/ocm whereas pkg/share deals with cs3/sharing/collaboration
-
Enhancement #2135: Nextcloud test improvements
-
Enhancement #2180: Remove OCDAV options namespace parameter
We dropped the namespace parameter, as it is not used in the options handler.
-
Enhancement #2117: Add ocs cache warmup strategy for first request from the user
-
Enhancement #2170: Handle propfind requests for existing files
-
Enhancement #2165: Allow access to recycle bin for arbitrary paths outside homes
-
Enhancement #2193: Filter root paths according to user agent
Adds a new rule setting in the storage registry ("allowed_user_agents"), that allows a user to specify which storage provider shows according to the user agent that made the request.
-
Enhancement #2162: Implement the UpdateStorageSpace method
Added the UpdateStorageSpace method to the decomposedfs.
-
Enhancement #2189: Add user setting capability
We've added a capability to communicate the existance of a user settings service to clients.
The following sections list the changes in reva 1.14.0 relevant to reva users. The changes are ordered by importance.
- Fix #2103: AppProvider: propagate back errors reported by WOPI
- Fix #2149: Remove excess info from the http list app providers endpoint
- Fix #2114: Add as default app while registering and skip unset mimetypes
- Fix #2095: Fix app open when multiple app providers are present
- Fix #2135: Make TUS capabilities configurable
- Fix #2076: Fix chi routing
- Fix #2077: Fix concurrent registration of mimetypes
- Fix #2154: Return OK when trying to delete a non existing reference
- Fix #2078: Fix nil pointer exception in stat
- Fix #2073: Fix opening a readonly filetype with WOPI
- Fix #2140: Map GRPC error codes to REVA errors
- Fix #2147: Follow up of #2138: this is the new expected format
- Fix #2116: Differentiate share types when retrieving received shares in sql driver
- Fix #2074: Fix Stat() for EOS storage provider
- Fix #2151: Fix return code for webdav uploads when the token expired
- Chg #2121: Sharemanager API change
- Enh #2090: Return space name during list storage spaces
- Enh #2138: Default AppProvider on top of the providers list
- Enh #2137: Revamp app registry and add parameter to control file creation
- Enh #145: UI improvements for the AppProviders
- Enh #2088: Add archiver and app provider to ocs capabilities
- Enh #2537: Add maximum files and size to archiver capabilities
- Enh #2100: Add support for resource id to the archiver
- Enh #2158: Augment the Id of new spaces
- Enh #2085: Make encoding user groups in access tokens configurable
- Enh #146: Filter the denial shares (permission = 0) out of
- Enh #2141: Use golang v1.17
- Enh #2053: Safer defaults for TLS verification on LDAP connections
- Enh #2115: Reduce code duplication in LDAP related drivers
- Enh #1989: Add redirects from OC10 URL formats
- Enh #2479: Limit publicshare and resourceinfo scope content
- Enh #2071: Implement listing favorites via the dav report API
- Enh #2091: Nextcloud share managers
- Enh #2070: More unit tests for the Nextcloud storage provider
- Enh #2087: More unit tests for the Nextcloud auth and user managers
- Enh #2075: Make owncloudsql leverage existing filecache index
- Enh #2050: Add a share types filter to the OCS API
- Enh #2134: Use space Type from request
- Enh #2132: Align local tests with drone setup
- Enh #2095: Whitelisting for apps
- Enh #2155: Pass an extra query parameter to WOPI /openinapp with a
-
Bugfix #2103: AppProvider: propagate back errors reported by WOPI
On /app/open and return base64-encoded fileids on /app/new
-
Bugfix #2149: Remove excess info from the http list app providers endpoint
We've removed excess info from the http list app providers endpoint. The app provider section contained all mime types supported by a certain app provider, which led to a very big JSON payload and since they are not used they have been removed again. Mime types not on the mime type configuration list always had
application/octet-streamas a file extension andAPPLICATION/OCTET-STREAM fileas name and description. Now these information are just omitted. -
Bugfix #2114: Add as default app while registering and skip unset mimetypes
We fixed that app providers will be set as default app while registering if configured. Also we changed the behaviour that listing supported mimetypes only displays allowed / configured mimetypes.
-
Bugfix #2095: Fix app open when multiple app providers are present
We've fixed the gateway behavior, that when multiple app providers are present, it always returned that we have duplicate names for app providers. This was due the call to GetAllProviders() without any subsequent filtering by name. Now this filter mechanism is in place and the duplicate app providers error will only appear if a real duplicate is found.
-
Bugfix #2135: Make TUS capabilities configurable
We've fixed the configuration for the TUS capabilities, which will now take the given configuration instead of always using hardcoded defaults.
-
Bugfix #2076: Fix chi routing
Chi routes based on the URL.RawPath, which is not updated by the shiftPath based routing used in reva. By setting the RawPath to an empty string chi will fall pack to URL.Path, allowing it to match percent encoded path segments, e.g. when trying to match emails or multibyte characters.
-
Bugfix #2077: Fix concurrent registration of mimetypes
We fixed registering mimetypes in the mime package when starting multiple storage providers in the same process.
-
Bugfix #2154: Return OK when trying to delete a non existing reference
When the gateway declines a share we can ignore a non existing reference.
-
Bugfix #2078: Fix nil pointer exception in stat
-
Bugfix #2073: Fix opening a readonly filetype with WOPI
This change fixes the opening of filetypes that are only supported to be viewed and not to be edited by some WOPI compliant office suites.
-
Bugfix #2140: Map GRPC error codes to REVA errors
We've fixed the error return behaviour in the gateway which would return GRPC error codes from the auth middleware. Now it returns REVA errors which other parts of REVA are also able to understand.
-
Bugfix #2147: Follow up of #2138: this is the new expected format
For the mime types configuration for the AppRegistry.
-
Bugfix #2116: Differentiate share types when retrieving received shares in sql driver
-
Bugfix #2074: Fix Stat() for EOS storage provider
This change fixes the convertion between the eosclient.FileInfo to ResourceInfo, in which the field ArbitraryMetadata was missing. Moreover, to be consistent with SetArbitraryMetadata() EOS implementation, all the "user." prefix are stripped out from the xattrs.
-
Bugfix #2151: Fix return code for webdav uploads when the token expired
We've fixed the behavior webdav uploads when the token expired before the final stat. Previously clients would receive a http 500 error which is wrong, because the file was successfully uploaded and only the stat couldn't be performed. Now we return a http 200 ok and the clients will fetch the file info in a separate propfind request.
Also we introduced the upload expires header on the webdav/TUS and datagateway endpoints, to signal clients how long an upload can be performed.
-
Change #2121: Sharemanager API change
This PR updates reva to reflect the share manager CS3 API changes.
-
Enhancement #2090: Return space name during list storage spaces
In the decomposedfs we return now the space name in the response which is stored in the extended attributes.
-
Enhancement #2138: Default AppProvider on top of the providers list
For each mime type
Now for each mime type, when asking for the list of mime types, the default AppProvider, set both using the config and the SetDefaultProviderForMimeType method, is always in the top of the list of AppProviders. The config for the Providers and Mime Types for the AppRegistry changed, using a list instead of a map. In fact the list of mime types returned by ListSupportedMimeTypes is now ordered according the config.
-
Enhancement #2137: Revamp app registry and add parameter to control file creation
-
Enhancement #145: UI improvements for the AppProviders
Mime types and their friendly names are now handled in the /app/list HTTP endpoint, and an additional /app/new endpoint is made available to create new files for apps.
-
Enhancement #2088: Add archiver and app provider to ocs capabilities
The archiver and app provider has been added to the ocs capabilities.
-
Enhancement #2537: Add maximum files and size to archiver capabilities
We added the maximum files count and maximum archive size of the archiver to the capabilities endpoint. Clients can use this to generate warnings before the actual archive creation fails.
-
Enhancement #2100: Add support for resource id to the archiver
Before the archiver only supported resources provided by a path. Now also the resources ID are supported in order to specify the content of the archive to download. The parameters accepted by the archiver are two: an optional list of
path(containing the paths of the resources) and an optional list ofid(containing the resources IDs of the resources). -
Enhancement #2158: Augment the Id of new spaces
Newly created spaces were missing the Root reference and the storage id in the space id.
-
Enhancement #2085: Make encoding user groups in access tokens configurable
-
Enhancement #146: Filter the denial shares (permission = 0) out of
The Shared-with-me UI view. Also they work regardless whether they are accepted or not, therefore there's no point to expose them.
-
Enhancement #2141: Use golang v1.17
-
Enhancement #2053: Safer defaults for TLS verification on LDAP connections
The LDAP client connections were hardcoded to ignore certificate validation errors. Now verification is enabled by default and a new config parameter 'insecure' is introduced to override that default. It is also possible to add trusted Certificates by using the new 'cacert' config paramter.
-
Enhancement #2115: Reduce code duplication in LDAP related drivers
-
Enhancement #1989: Add redirects from OC10 URL formats
Added redirectors for ownCloud 10 URLs. This allows users to continue to use their bookmarks from ownCloud 10 in ocis.
-
Enhancement #2479: Limit publicshare and resourceinfo scope content
We changed the publicshare and resourceinfo scopes to contain only necessary values. This reduces the size of the resulting token and also limits the amount of data which can be leaked.
-
Enhancement #2071: Implement listing favorites via the dav report API
Added filter-files to the dav REPORT API. This enables the listing of favorites.
-
Enhancement #2091: Nextcloud share managers
Share manager that uses Nextcloud as a backend
-
Enhancement #2070: More unit tests for the Nextcloud storage provider
Adds more unit tests for the Nextcloud storage provider.
-
Enhancement #2087: More unit tests for the Nextcloud auth and user managers
Adds more unit tests for the Nextcloud auth manager and the Nextcloud user manager
-
Enhancement #2075: Make owncloudsql leverage existing filecache index
When listing folders the SQL query now uses an existing index on the filecache table.
-
Enhancement #2050: Add a share types filter to the OCS API
Added a filter to the OCS API to filter the received shares by type.
-
Enhancement #2134: Use space Type from request
In the decomposedfs we now use the space type from the request when creating a new space.
-
Enhancement #2132: Align local tests with drone setup
We fixed running the tests locally and align it with the drone setup.
-
Enhancement #2095: Whitelisting for apps
AppProvider supported mime types are now overridden in its configuration. A friendly name, a description, an extension, an icon and a default app, can be configured in the AppRegistry for each mime type.
-
Enhancement #2155: Pass an extra query parameter to WOPI /openinapp with a
Unique and consistent over time user identifier. The Reva token used so far is not consistent (it's per session) and also too long.
The following sections list the changes in reva 1.13.0 relevant to reva users. The changes are ordered by importance.
- Fix #2024: Fixes for http appprovider endpoints
- Fix #2054: Fix the response after deleting a share
- Fix #2026: Fix moving of a shared file
- Fix #2047: Do not truncate logs on restart
- Fix #1605: Allow to expose full paths in OCS API
- Fix #2033: Fix the storage id of shares
- Fix #2059: Remove "Got registration for user manager" print statements
- Fix #2051: Remove malformed parameters from WOPI discovery URLs
- Fix #2055: Fix uploads of empty files
- Fix #1991: Remove share references when declining shares
- Fix #2030: Fix superfluous WriteHeader on file upload
- Enh #2034: Fail initialization of a WOPI AppProvider if
- Enh #1968: Use a URL object in OpenInAppResponse
- Enh #1698: Implement folder download as archive
- Enh #2042: Escape ldap filters
- Enh #2028: Machine auth provider
- Enh #2043: Nextcloud user backend
- Enh #2006: Move ocs API to go-chi/chi based URL routing
- Enh #1994: Add owncloudsql driver for the userprovider
- Enh #1971: Add documentation for runtime-plugins
- Enh #2044: Add utility methods for creating share filters
- Enh #2065: New sharing role Manager
- Enh #2015: Add spaces to the list of capabilities
- Enh #2041: Create operations for Spaces
- Enh #2029: Tracing agent configuration
-
Bugfix #2024: Fixes for http appprovider endpoints
-
Bugfix #2054: Fix the response after deleting a share
Added the deleted share to the response after deleting it.
-
Bugfix #2026: Fix moving of a shared file
As the share receiver, moving a shared file to another share was not possible.
-
Bugfix #2047: Do not truncate logs on restart
This change fixes the way log files were opened. Before they were truncated and now the log file will be open in append mode and created it if it does not exist.
-
Bugfix #1605: Allow to expose full paths in OCS API
Before this fix a share file_target was always harcoded to use a base path. This fix provides the possiblity to expose full paths in the OCIS API and asymptotically in OCIS web.
-
Bugfix #2033: Fix the storage id of shares
The storageid in the share object contained an incorrect value.
-
Bugfix #2059: Remove "Got registration for user manager" print statements
Removed the "Got registration for user manager" print statements which spams the log output without respecting any log level.
-
Bugfix #2051: Remove malformed parameters from WOPI discovery URLs
This change fixes the parsing of WOPI discovery URLs for MSOffice /hosting/discovery endpoint. This endpoint is known to contain malformed query paramters and therefore this fix removes them.
-
Bugfix #2055: Fix uploads of empty files
This change fixes upload of empty files. Previously this was broken and only worked for the owncloud filesystem as it bypasses the semantics of the InitiateFileUpload call to touch a local file.
-
Bugfix #1991: Remove share references when declining shares
Implemented the removal of share references when a share gets declined. Now when a user declines a share it will no longer be listed in their
Sharesdirectory. -
Bugfix #2030: Fix superfluous WriteHeader on file upload
Removes superfluous Writeheader on file upload and therefore removes the error message "http: superfluous response.WriteHeader call from github.com/cs3org/reva/internal/http/interceptors/log.(*responseLogger).WriteHeader (log.go:154)"
-
Enhancement #2034: Fail initialization of a WOPI AppProvider if
The underlying app is not WOPI-compliant nor it is supported by the WOPI bridge extensions
-
Enhancement #1968: Use a URL object in OpenInAppResponse
-
Enhancement #1698: Implement folder download as archive
Adds a new http service which will create an archive (platform dependent, zip in windows and tar in linux) given a list of file.
-
Enhancement #2042: Escape ldap filters
Added ldap filter escaping to increase the security of reva.
-
Enhancement #2028: Machine auth provider
Adds a new authentication method used to impersonate users, using a shared secret, called api-key.
-
Enhancement #2043: Nextcloud user backend
Adds Nextcloud as a user backend (Nextcloud drivers for 'auth' and 'user'). Also adds back the Nextcloud storage integration tests.
-
Enhancement #2006: Move ocs API to go-chi/chi based URL routing
-
Enhancement #1994: Add owncloudsql driver for the userprovider
We added a new backend for the userprovider that is backed by an owncloud 10 database. By default the
user_idcolumn is used as the reva user username and reva user opaque id. When settingjoin_username=truethe reva user username is joined from theoc_preferencestable (appid='core' AND configkey='username') instead. When settingjoin_ownclouduuid=truethe reva user opaqueid is joined from theoc_preferencestable (appid='core' AND configkey='ownclouduuid') instead. This allows more flexible migration strategies. It also supports aenable_medial_searchconfig option when searching users that will enclose the query with%. -
Enhancement #1971: Add documentation for runtime-plugins
-
Enhancement #2044: Add utility methods for creating share filters
Updated the CS3 API to include the new share grantee filter and added utility methods for creating share filters. This will help making the code more concise.
-
Enhancement #2065: New sharing role Manager
The new Manager role is equivalent to a Co-Owner with the difference that a Manager can create grants on the root of the Space. This means inviting a user to a space will not require an action from them, as the Manager assigns the grants.
-
Enhancement #2015: Add spaces to the list of capabilities
In order for clients to be aware of the new spaces feature we need to enable the
spacesflag on the capabilities' endpoint. -
Enhancement #2041: Create operations for Spaces
DecomposedFS is aware now of the concept of Spaces, and supports for creating them.
-
Enhancement #2029: Tracing agent configuration
Earlier we could only use the collector URL directly, but since an agent can be deployed as a sidecar process it makes much more sense to use it instead of the collector directly.
The following sections list the changes in reva 1.12.0 relevant to reva users. The changes are ordered by importance.
- Fix #1819: Disable notifications
- Fix #2000: Fix dependency on tests
- Fix #1957: Fix etag propagation on deletes
- Fix #1960: Return the updated share after updating
- Fix #1993: Fix owncloudsql GetMD
- Fix #1954: Fix response format of the sharees API
- Fix #1965: Fix the file target of user and group shares
- Fix #1956: Fix trashbin listing with depth 0
- Fix #1987: Fix windows build
- Fix #1990: Increase oc10 compatibility of owncloudsql
- Fix #1978: Owner type is optional
- Fix #1980: Propagate the etag after restoring a file version
- Fix #1985: Add quota stubs
- Fix #1992: Check if symlink exists instead of spamming the console
- Fix #1913: Logic to restore files to readonly nodes
- Chg #1982: Move user context methods into a separate
userctxpackage - Enh #1946: Add share manager that connects to oc10 databases
- Enh #1983: Add Codacy unit test coverage
- Enh #1803: Introduce new webdav spaces endpoint
- Enh #1998: Initial version of the Nextcloud storage driver
- Enh #1984: Replace OpenCensus with OpenTelemetry
- Enh #1861: Add support for runtime plugins
- Enh #2008: Site account extensions
-
Bugfix #1819: Disable notifications
The presence of the key
notificationsin the capabilities' response would cause clients to attempt to poll the notifications endpoint, which is not yet supported. To prevent the unnecessary bandwidth we are disabling this altogether. -
Bugfix #2000: Fix dependency on tests
The Nextcloud storage driver depended on a mock http client from the tests/ folder This broke the Docker build The dependency was removed A check was added to test the Docker build on each PR
-
Bugfix #1957: Fix etag propagation on deletes
When deleting a file the etag propagation would skip the parent of the deleted file.
-
Bugfix #1960: Return the updated share after updating
When updating the state of a share in the in-memory share manager the old share state was returned instead of the updated state.
-
Bugfix #1993: Fix owncloudsql GetMD
The GetMD call internally was not prefixing the path when looking up resources by id.
-
Bugfix #1954: Fix response format of the sharees API
The sharees API wasn't returning the users and groups arrays correctly.
-
Bugfix #1965: Fix the file target of user and group shares
In some cases the file target of user and group shares was not properly prefixed.
-
Bugfix #1956: Fix trashbin listing with depth 0
The trashbin API handled requests with depth 0 the same as request with a depth of 1.
-
Bugfix #1987: Fix windows build
Add the necessary
golang.org/x/sys/windowspackage import toowncloudandowncloudsqlstorage drivers. -
Bugfix #1990: Increase oc10 compatibility of owncloudsql
We added a few changes to the owncloudsql storage driver to behave more like oc10.
-
Bugfix #1978: Owner type is optional
When reading the user from the extended attributes the user type might not be set, in this case we now return a user with an invalid type, which correctly reflects the state on disk.
-
Bugfix #1980: Propagate the etag after restoring a file version
The decomposedfs didn't propagate after restoring a file version.
-
Bugfix #1985: Add quota stubs
The
owncloudandowncloudsqldrivers now read the available quota from disk to no longer always return 0, which causes the web UI to disable uploads. -
Bugfix #1992: Check if symlink exists instead of spamming the console
The logs have been spammed with messages like
could not create symlink for ...when using the decomposedfs, eg. with the oCIS storage. We now check if the link exists before trying to create it. -
Bugfix #1913: Logic to restore files to readonly nodes
This impacts solely the DecomposedFS. Prior to these changes there was no validation when a user tried to restore a file from the trashbin to a share location (i.e any folder under
/Shares).With this patch if the user restoring the resource has write permissions on the share, restore is possible.
-
Change #1982: Move user context methods into a separate
userctxpackage -
Enhancement #1946: Add share manager that connects to oc10 databases
-
Enhancement #1983: Add Codacy unit test coverage
This PR adds unit test coverage upload to Codacy.
-
Enhancement #1803: Introduce new webdav spaces endpoint
Clients can now use a new webdav endpoint
/dav/spaces/<storagespaceid>/relative/path/to/fileto directly access storage spaces.The
<storagespaceid>can be retrieved using the ListStorageSpaces CS3 api call. -
Enhancement #1998: Initial version of the Nextcloud storage driver
This is not usable yet in isolation, but it's a first component of https://github.com/pondersource/sciencemesh-nextcloud
-
Enhancement #1984: Replace OpenCensus with OpenTelemetry
OpenTelemetry](https://opentelemetry.io/docs/concepts/what-is-opentelemetry/) is an open standard a sandbox CNCF project and it was formed through a merger of the OpenTracing and OpenCensus.
OpenCensus and OpenTracing have merged to form OpenTelemetry, which serves as the next major version of OpenCensus and OpenTracing. OpenTelemetry will offer backwards compatibility with existing OpenCensus integrations, and we will continue to make security patches to existing OpenCensus libraries for two years.
There is a lot of outdated documentation as a result of this merger, and we will be better off adopting the latest standard and libraries.
-
Enhancement #1861: Add support for runtime plugins
This PR introduces a new plugin package, that allows loading external plugins into Reva at runtime. The hashicorp go-plugin framework was used to facilitate the plugin loading and communication.
-
Enhancement #2008: Site account extensions
This PR heavily extends the site accounts service: * Extended the accounts information (not just email and name) * Accounts now have a password * Users can now "log in" to their accounts and edit it * Ability to grant access to the GOCDB
Furthermore, these accounts can now be used to authenticate for logging in to our customized GOCDB. More use cases for these accounts are also planned.
The following sections list the changes in reva 1.11.0 relevant to reva users. The changes are ordered by importance.
- Fix #1899: Fix chunked uploads for new versions
- Fix #1906: Fix copy over existing resource
- Fix #1891: Delete Shared Resources as Receiver
- Fix #1907: Error when creating folder with existing name
- Fix #1937: Do not overwrite more specific matches when finding storage providers
- Fix #1939: Fix the share jail permissions in the decomposedfs
- Fix #1932: Numerous fixes to the owncloudsql storage driver
- Fix #1912: Fix response when listing versions of another user
- Fix #1910: Get user groups recursively in the cbox rest user driver
- Fix #1904: Set Content-Length to 0 when swallowing body in the datagateway
- Fix #1911: Fix version order in propfind responses
- Fix #1926: Trash Bin in oCIS Storage Operations
- Fix #1901: Fix response code when folder doesnt exist on upload
- Enh #1785: Extend app registry with AddProvider method and mimetype filters
- Enh #1938: Add methods to get and put context values
- Enh #1798: Add support for a deny-all permission on references
- Enh #1916: Generate updated protobuf bindings for EOS GRPC
- Enh #1887: Add "a" and "l" filter for grappa queries
- Enh #1919: Run gofmt before building
- Enh #1927: Implement RollbackToVersion for eosgrpc (needs a newer EOS MGM)
- Enh #1944: Implement listing supported mime types in app registry
- Enh #1870: Be defensive about wrongly quoted etags
- Enh #1940: Reduce memory usage when uploading with S3ng storage
- Enh #1888: Refactoring of the webdav code
- Enh #1900: Check for illegal names while uploading or moving files
- Enh #1925: Refactor listing and statting across providers for virtual views
-
Bugfix #1899: Fix chunked uploads for new versions
Chunked uploads didn't create a new version, when the file to upload already existed.
-
Bugfix #1906: Fix copy over existing resource
When the target of a copy already exists, the existing resource will be moved to the trashbin before executing the copy.
-
Bugfix #1891: Delete Shared Resources as Receiver
It is now possible to delete a shared resource as a receiver and not having the data ending up in the receiver's trash bin, causing a possible leak.
-
Bugfix #1907: Error when creating folder with existing name
When a user tried to create a folder with the name of an existing file or folder the service didn't return a response body containing the error.
-
Bugfix #1937: Do not overwrite more specific matches when finding storage providers
Depending on the order of rules in the registry it could happend that more specific matches (e.g. /home/Shares) were overwritten by more general ones (e.g. /home). This PR makes sure that the registry always returns the most specific match.
-
Bugfix #1939: Fix the share jail permissions in the decomposedfs
The share jail should be not writable
-
Bugfix #1932: Numerous fixes to the owncloudsql storage driver
The owncloudsql storage driver received numerous bugfixes and cleanups.
-
Bugfix #1912: Fix response when listing versions of another user
The OCS API returned the wrong response when a user tried to list the versions of another user's file.
-
Bugfix #1910: Get user groups recursively in the cbox rest user driver
-
Bugfix #1904: Set Content-Length to 0 when swallowing body in the datagateway
When swallowing the body the Content-Lenght needs to be set to 0 to prevent proxies from reading the body.
-
Bugfix #1911: Fix version order in propfind responses
The order of the file versions in propfind responses was incorrect.
-
Bugfix #1926: Trash Bin in oCIS Storage Operations
Support for restoring a target folder nested deep inside the trash bin in oCIS storage. The use case is:
MOVE -H 'Destination: https://localhost:9200/remote.php/dav/files/einstein/destination' ``` The previous command creates the `destination` folder and moves the contents of `/trash-bin/einstein/f1/f2` onto it. Retro-compatibility in the response code with ownCloud 10. Restoring a collection to a non-existent nested target is not supported and MUST return `409`. The use case is: ```console curl 'https://localhost:9200/remote.php/dav/trash-bin/einstein/f1/f2' -X MOVE -H 'Destination: https://localhost:9200/remote.php/dav/files/einstein/this/does/not/exist' ``` The previous command used to return `404` instead of the expected `409` by the clients. https://github.com/cs3org/reva/pull/1926
-
Bugfix #1901: Fix response code when folder doesnt exist on upload
When a new file was uploaded to a non existent folder the response code was incorrect.
-
Enhancement #1785: Extend app registry with AddProvider method and mimetype filters
-
Enhancement #1938: Add methods to get and put context values
Added
GetKeyValuesandPutKeyValuesmethods to fetch/put values from/to context. -
Enhancement #1798: Add support for a deny-all permission on references
And implement it on the EOS storage
-
Enhancement #1916: Generate updated protobuf bindings for EOS GRPC
-
Enhancement #1887: Add "a" and "l" filter for grappa queries
This PR adds the namespace filters "a" and "l" for grappa queries. With no filter will look into primary and e-groups, with "a" will look into primary/secondary/service/e-groups and with "l" will look into lightweight accounts.
-
Enhancement #1919: Run gofmt before building
-
Enhancement #1927: Implement RollbackToVersion for eosgrpc (needs a newer EOS MGM)
-
Enhancement #1944: Implement listing supported mime types in app registry
-
Enhancement #1870: Be defensive about wrongly quoted etags
When ocdav renders etags it will now try to correct them to the definition as quoted strings which do not contain
". This prevents double or triple quoted etags on the webdav api. -
Enhancement #1940: Reduce memory usage when uploading with S3ng storage
The memory usage could be high when uploading files using the S3ng storage. By providing the actual file size when triggering
PutObject, the overall memory usage is reduced. -
Enhancement #1888: Refactoring of the webdav code
Refactored the webdav code to make it reusable.
-
Enhancement #1900: Check for illegal names while uploading or moving files
The code was not checking for invalid file names during uploads and moves.
-
Enhancement #1925: Refactor listing and statting across providers for virtual views
The following sections list the changes in reva 1.10.0 relevant to reva users. The changes are ordered by importance.
- Fix #1883: Pass directories with trailing slashes to eosclient.GenerateToken
- Fix #1878: Improve the webdav error handling in the trashbin
- Fix #1884: Do not send body on failed range request
- Enh #1744: Add support for lightweight user types
-
Bugfix #1883: Pass directories with trailing slashes to eosclient.GenerateToken
-
Bugfix #1878: Improve the webdav error handling in the trashbin
The trashbin handles errors better now on the webdav endpoint.
-
Bugfix #1884: Do not send body on failed range request
Instead of send the error in the body of a 416 response we log it. This prevents the go reverse proxy from choking on it and turning it into a 502 Bad Gateway response.
-
Enhancement #1744: Add support for lightweight user types
This PR adds support for assigning and consuming user type when setting/reading users. On top of that, support for lightweight users is added. These users have to be restricted to accessing only shares received by them, which is accomplished by expanding the existing RBAC scope.
The following sections list the changes in reva 1.9.1 relevant to reva users. The changes are ordered by importance.
- Fix #1843: Correct Dockerfile path for the reva CLI and alpine3.13 as builder
- Fix #1835: Cleanup owncloudsql driver
- Fix #1868: Minor fixes to the grpc/http plugin: checksum, url escaping
- Fix #1885: Fix template in eoshomewrapper to use context user rather than resource
- Fix #1833: Properly handle name collisions for deletes in the owncloud driver
- Fix #1874: Use the original file mtime during upload
- Fix #1854: Add the uid/gid to the url for eos
- Fix #1848: Fill in missing gid/uid number with nobody
- Fix #1831: Make the ocm-provider endpoint in the ocmd service unprotected
- Fix #1808: Use empty array in OCS Notifications endpoints
- Fix #1825: Raise max grpc message size
- Fix #1828: Send a proper XML header with error messages
- Chg #1828: Remove the oidc provider in order to upgrad mattn/go-sqlite3 to v1.14.7
- Enh #1834: Add API key to Mentix GOCDB connector
- Enh #1855: Minor optimization in parsing EOS ACLs
- Enh #1873: Update the EOS image tag to be for revad-eos image
- Enh #1802: Introduce list spaces
- Enh #1849: Add readonly interceptor
- Enh #1875: Simplify resource comparison
- Enh #1827: Support trashbin sub paths in the recycle API
-
Bugfix #1843: Correct Dockerfile path for the reva CLI and alpine3.13 as builder
This was introduced on https://github.com/cs3org/reva/commit/117adad while porting the configuration on .drone.yml to starlark.
Force golang:alpine3.13 as base image to prevent errors from Make when running on Docker <20.10 as it happens on Drone ref.https://gitlab.alpinelinux.org/alpine/aports/-/issues/12396
-
Bugfix #1835: Cleanup owncloudsql driver
Use
owncloudsqlstring when returning errors and removed copyMD as it does not need to copy metadata from files. -
Bugfix #1868: Minor fixes to the grpc/http plugin: checksum, url escaping
-
Bugfix #1885: Fix template in eoshomewrapper to use context user rather than resource
-
Bugfix #1833: Properly handle name collisions for deletes in the owncloud driver
In the owncloud storage driver when we delete a file we append the deletion time to the file name. If two fast consecutive deletes happened, the deletion time would be the same and if the two files had the same name we ended up with only one file in the trashbin.
-
Bugfix #1874: Use the original file mtime during upload
The decomposedfs was not using the original file mtime during uploads.
-
Bugfix #1854: Add the uid/gid to the url for eos
-
Bugfix #1848: Fill in missing gid/uid number with nobody
When an LDAP server does not provide numeric uid or gid properties for a user we now fall back to a configurable
nobodyid (default 99). -
Bugfix #1831: Make the ocm-provider endpoint in the ocmd service unprotected
-
Bugfix #1808: Use empty array in OCS Notifications endpoints
-
Bugfix #1825: Raise max grpc message size
As a workaround for listing larger folder we raised the
MaxCallRecvMsgSizeto 10MB. This should be enough for ~15k files. The proper fix is implementing ListContainerStream in the gateway, but we needed a way to test the web ui with larger collections. -
Bugfix #1828: Send a proper XML header with error messages
-
Change #1828: Remove the oidc provider in order to upgrad mattn/go-sqlite3 to v1.14.7
In order to upgrade mattn/go-sqlite3 to v1.14.7, the odic provider service is removed, which is possible because it is not used anymore
-
Enhancement #1834: Add API key to Mentix GOCDB connector
The PI (programmatic interface) of the GOCDB will soon require an API key; this PR adds the ability to configure this key in Mentix.
-
Enhancement #1855: Minor optimization in parsing EOS ACLs
-
Enhancement #1873: Update the EOS image tag to be for revad-eos image
-
Enhancement #1802: Introduce list spaces
The ListStorageSpaces call now allows listing all user homes and shared resources using a storage space id. The gateway will forward requests to a specific storage provider when a filter by id is given. Otherwise it will query all storage providers. Results will be deduplicated. Currently, only the decomposed fs storage driver implements the necessary logic to demonstrate the implmentation. A new
/dav/spacesWebDAV endpoint to directly access a storage space is introduced in a separate PR. -
Enhancement #1849: Add readonly interceptor
The readonly interceptor could be used to configure a storageprovider in readonly mode. This could be handy in some migration scenarios.
-
Enhancement #1875: Simplify resource comparison
We replaced ResourceEqual with ResourceIDEqual where possible.
-
Enhancement #1827: Support trashbin sub paths in the recycle API
The recycle API could only act on the root items of the trashbin. Meaning if you delete a deep tree, you couldn't restore just one file from that tree but you had to restore the whole tree. Now listing, restoring and purging work also for sub paths in the trashbin.
The following sections list the changes in reva 1.9.0 relevant to reva users. The changes are ordered by importance.
- Fix #1815: Drone CI - patch the 'store-dev-release' job to fix malformed requests
- Fix #1765: 'golang:alpine' as base image & CGO_ENABLED just for the CLI
- Chg #1721: Absolute and relative references
- Enh #1810: Add arbitrary metadata support to EOS
- Enh #1774: Add user ID cache warmup to EOS storage driver
- Enh #1471: EOEGrpc progress. Logging discipline and error handling
- Enh #1811: Harden public shares signing
- Enh #1793: Remove the user id from the trashbin key
- Enh #1795: Increase trashbin restore API compatibility
- Enh #1516: Use UidNumber and GidNumber fields in User objects
- Enh #1820: Tag v1.9.0
-
Bugfix #1815: Drone CI - patch the 'store-dev-release' job to fix malformed requests
Replace the backquotes that were used for the date component of the URL with the POSIX-confirmant command substitution '$()'.
-
Bugfix #1765: 'golang:alpine' as base image & CGO_ENABLED just for the CLI
Some of the dependencies used by revad need CGO to be enabled in order to work. We also need to install the 'mime-types' in alpine to correctly detect them on the storage-providers.
The CGO_ENABLED=0 flag was added to the docker build flags so that it will produce a static build. This allows usage of the 'scratch' image for reduction of the docker image size (e.g. the reva cli).
-
Change #1721: Absolute and relative references
We unified the
Reference_IdendReference_Pathtypes to a combinedReferencethat contains both: - aresource_idproperty that can identify a node using astorage_idand anopaque_id- apathproperty that can be used to represent absolute paths as well as paths relative to the id based properties. While this is a breaking change it allows passing both: absolute as well as relative references. -
Enhancement #1810: Add arbitrary metadata support to EOS
-
Enhancement #1774: Add user ID cache warmup to EOS storage driver
-
Enhancement #1471: EOEGrpc progress. Logging discipline and error handling
-
Enhancement #1811: Harden public shares signing
Makes golangci-lint happy as well
-
Enhancement #1793: Remove the user id from the trashbin key
We don't want to use the users uuid outside of the backend so I removed the id from the trashbin file key.
-
Enhancement #1795: Increase trashbin restore API compatibility
- The precondition were not checked before doing a trashbin restore in the ownCloud dav API.
Without the checks the API would behave differently compared to the oC10 API. * The restore
response was missing HTTP headers like
ETag* Update the name when restoring the file from trashbin to a new target name
- The precondition were not checked before doing a trashbin restore in the ownCloud dav API.
Without the checks the API would behave differently compared to the oC10 API. * The restore
response was missing HTTP headers like
-
Enhancement #1516: Use UidNumber and GidNumber fields in User objects
Update instances where CS3API's
Userobjects are created and used to useGidNumber, andUidNumberfields instead of storing them inOpaquemap. -
Enhancement #1820: Tag v1.9.0
Bump release number to v1.9.0 as it contains breaking changes related to changing the reference type.
The following sections list the changes in reva 1.8.0 relevant to reva users. The changes are ordered by importance.
- Fix #1779: Set Content-Type header correctly for ocs requests
- Fix #1650: Allow fetching shares as the grantee
- Fix #1693: Fix move in owncloud storage driver
- Fix #1666: Fix public file shares
- Fix #1541: Allow for restoring recycle items to different locations
- Fix #1718: Use the -static ldflag only for the 'build-ci' target
- Enh #1719: Application passwords CLI
- Enh #1719: Application passwords management
- Enh #1725: Create transfer type share
- Enh #1755: Return file checksum available from the metadata for the EOS driver
- Enh #1673: Deprecate using errors.New and fmt.Errorf
- Enh #1723: Open in app workflow using the new API
- Enh #1655: Improve json marshalling of share protobuf messages
- Enh #1694: User profile picture capability
- Enh #1649: Add reliability calculations support to Mentix
- Enh #1509: Named Service Registration
- Enh #1643: Cache resources from share getter methods in OCS
- Enh #1664: Add cache warmup strategy for OCS resource infos
- Enh #1710: Owncloudsql storage driver
- Enh #1705: Reduce the size of all the container images built on CI
- Enh #1669: Mint scope-based access tokens for RBAC
- Enh #1683: Filter created shares based on type in OCS
- Enh #1763: Sort share entries alphabetically
- Enh #1758: Warn user for not recommended go version
- Enh #1747: Add checksum headers to tus preflight responses
- Enh #1685: Add share to update response
-
Bugfix #1779: Set Content-Type header correctly for ocs requests
Before this fix the
Content-Typeheader was guessed byw.WritebecauseWriteHeaderwas called to early. Now theContent-Typeis set correctly and to the same values as in ownCloud 10 -
Bugfix #1650: Allow fetching shares as the grantee
The json backend now allows a grantee to fetch a share by id.
-
Bugfix #1693: Fix move in owncloud storage driver
When moving a file or folder (includes renaming) the filepath in the cache didn't get updated which caused subsequent requests to
getpathto fail. -
Bugfix #1666: Fix public file shares
Fixed stat requests and propfind responses for publicly shared files.
-
Bugfix #1541: Allow for restoring recycle items to different locations
The CS3 APIs specify a way to restore a recycle item to a different location than the original by setting the
restore_pathfield in theRestoreRecycleItemRequest. This field had not been considered until now. -
Bugfix #1718: Use the -static ldflag only for the 'build-ci' target
It is not intended to statically link the generated binaries for local development workflows. This resulted on segmentation faults and compiller warnings.
-
Enhancement #1719: Application passwords CLI
This PR adds the CLI commands
token-list,token-createandtoken-removeto manage tokens with limited scope on behalf of registered users. -
Enhancement #1719: Application passwords management
This PR adds the functionality to generate authentication tokens with limited scope on behalf of registered users. These can be used in third party apps or in case primary user credentials cannot be submitted to other parties.
-
Enhancement #1725: Create transfer type share
transfer-createcreates a share of type transfer. -
Enhancement #1755: Return file checksum available from the metadata for the EOS driver
-
Enhancement #1673: Deprecate using errors.New and fmt.Errorf
Previously we were using errors.New and fmt.Errorf to create errors. Now we use the errors defined in the errtypes package.
-
Enhancement #1723: Open in app workflow using the new API
This provides a new
open-in-appcommand for the CLI and the implementation on the appprovider gateway service for the new API, including the option to specify the appplication to use, thus overriding the preconfigured one. -
Enhancement #1655: Improve json marshalling of share protobuf messages
Protobuf oneof fields cannot be properly handled by the native json marshaller, and the protojson package can only handle proto messages. Previously, we were using a workaround of storing these oneof fields separately, which made the code inelegant. Now we marshal these messages as strings before marshalling them via the native json package.
-
Enhancement #1694: User profile picture capability
Based on feedback in the new ownCloud web frontend we want to omit trying to render user avatars images / profile pictures based on the backend capabilities. Now the OCS communicates a corresponding value.
-
Enhancement #1649: Add reliability calculations support to Mentix
To make reliability calculations possible, a new exporter has been added to Mentix that reads scheduled downtimes from the GOCDB and exposes it through Prometheus metrics.
-
Enhancement #1509: Named Service Registration
Move away from hardcoding service IP addresses and rely upon name resolution instead. It delegates the address lookup to a static in-memory service registry, which can be re-implemented in multiple forms.
-
Enhancement #1643: Cache resources from share getter methods in OCS
In OCS, once we retrieve the shares from the shareprovider service, we stat each of those separately to obtain the required info, which introduces a lot of latency. This PR introduces a resoource info cache in OCS, which would prevent this latency.
-
Enhancement #1664: Add cache warmup strategy for OCS resource infos
Recently, a TTL cache was added to OCS to store statted resource infos. This PR adds an interface to define warmup strategies and also adds a cbox specific strategy which starts a goroutine to initialize the cache with all the valid shares present in the system.
-
Enhancement #1710: Owncloudsql storage driver
This PR adds a storage driver which connects to a oc10 storage backend (storage + database). This allows for running oc10 and ocis with the same backend in parallel.
-
Enhancement #1705: Reduce the size of all the container images built on CI
Previously, all images were based on golang:1.16 which is built from Debian. Using 'scratch' as base, reduces the size of the artifacts well as the attack surface for all the images, plus copying the binary from the build step ensures that only the strictly required software is present on the final image. For the revad images tagged '-eos', eos-slim is used instead. It is still large but it updates the environment as well as the EOS version.
-
Enhancement #1669: Mint scope-based access tokens for RBAC
Primarily, this PR is meant to introduce the concept of scopes into our tokens. At the moment, it addresses those cases where we impersonate other users without allowing the full scope of what the actual user has access to.
A short explanation for how it works for public shares: - We get the public share using the token provided by the client. - In the public share, we know the resource ID, so we can add this to the allowed scope, but not the path. - However, later OCDav tries to access by path as well. Now this is not allowed at the moment. However, from the allowed scope, we have the resource ID and we're allowed to stat that. We stat the resource ID, get the path and if the path matches the one passed by OCDav, we allow the request to go through.
-
Enhancement #1683: Filter created shares based on type in OCS
-
Enhancement #1763: Sort share entries alphabetically
When showing the list of shares to the end-user, the list was not sorted alphabetically. This PR sorts the list of users and groups.
-
Enhancement #1758: Warn user for not recommended go version
This PR adds a warning while an user is building the source code, if he is using a go version not recommended.
-
Enhancement #1747: Add checksum headers to tus preflight responses
Added
checksumto the headerTus-Extensionand added theTus-Checksum-Algorithmheader. -
Enhancement #1685: Add share to update response
After accepting or rejecting a share the API includes the updated share in the response.
The following sections list the changes in reva 1.7.0 relevant to reva users. The changes are ordered by importance.
- Fix #1619: Fixes for enabling file sharing in EOS
- Fix #1576: Fix etag changing only once a second
- Fix #1634: Mentix site authorization status changes
- Fix #1625: Make local file connector more error tolerant
- Fix #1526: Fix webdav file versions endpoint bugs
- Fix #1457: Cloning of internal mesh data lost some values
- Fix #1597: Check for ENOTDIR on readlink error
- Fix #1636: Skip file check for OCM data transfers
- Fix #1552: Fix a bunch of trashbin related issues
- Fix #1: Bump meshdirectory-web to 1.0.2
- Chg #1562: Modularize api token management in GRAPPA drivers
- Chg #1452: Separate blobs from metadata in the ocis storage driver
- Enh #1514: Add grpc test suite for the storage provider
- Enh #1466: Add integration tests for the s3ng driver
- Enh #1521: Clarify expected failures
- Enh #1624: Add wrappers for EOS and EOS Home storage drivers
- Enh #1563: Implement cs3.sharing.collaboration.v1beta1.Share.ShareType
- Enh #1411: Make InsecureSkipVerify configurable
- Enh #1106: Make command to run litmus tests
- Enh #1502: Bump meshdirectory-web to v1.0.4
- Enh #1502: New MeshDirectory HTTP service UI frontend with project branding
- Enh #1405: Quota querying and tree accounting
- Enh #1527: Add FindAcceptedUsers method to OCM Invite API
- Enh #1149: Add CLI Commands for OCM invitation workflow
- Enh #1629: Implement checksums in the owncloud storage
- Enh #1528: Port drone pipeline definition to starlark
- Enh #110: Add signature authentication for public links
- Enh #1495: SQL driver for the publicshare service
- Enh #1588: Make the additional info attribute for shares configurable
- Enh #1595: Add site account registration panel
- Enh #1506: Site Accounts service for API keys
- Enh #116: Enhance storage registry with virtual views and regular expressions
- Enh #1513: Add stubs for storage spaces manipulation
-
Bugfix #1619: Fixes for enabling file sharing in EOS
-
Bugfix #1576: Fix etag changing only once a second
We fixed a problem with the owncloud storage driver only considering the mtime with a second resolution for the etag calculation.
-
Bugfix #1634: Mentix site authorization status changes
If a site changes its authorization status, Mentix did not update its internal data to reflect this change. This PR fixes this issue.
-
Bugfix #1625: Make local file connector more error tolerant
The local file connector caused Reva to throw an exception if the local file for storing site data couldn't be loaded. This PR changes this behavior so that only a warning is logged.
-
Bugfix #1526: Fix webdav file versions endpoint bugs
Etag and error code related bugs have been fixed for the webdav file versions endpoint and removed from the expected failures file.
-
Bugfix #1457: Cloning of internal mesh data lost some values
This update fixes a bug in Mentix that caused some (non-critical) values to be lost during data cloning that happens internally.
-
Bugfix #1597: Check for ENOTDIR on readlink error
The deconstructed storage driver now handles ENOTDIR errors when
node.Child()is called for a path containing a path segment that is actually a file. -
Bugfix #1636: Skip file check for OCM data transfers
-
Bugfix #1552: Fix a bunch of trashbin related issues
Fixed these issues:
- Complete: Deletion time in trash bin shows a wrong date - Complete: shared trash status code - Partly: invalid webdav responses for unauthorized requests. - Partly: href in trashbin PROPFIND response is wrong
Complete means there are no expected failures left. Partly means there are some scenarios left.
-
Bugfix #1: Bump meshdirectory-web to 1.0.2
Updated meshdirectory-web mod to version 1.0.2 that contains fixes for OCM invite API links generation.
-
Change #1562: Modularize api token management in GRAPPA drivers
This PR moves the duplicated api token management methods into a seperate utils package
-
Change #1452: Separate blobs from metadata in the ocis storage driver
We changed the ocis storage driver to keep the file content separate from the metadata by storing the blobs in a separate directory. This allows for using a different (potentially faster) storage for the metadata.
Note This change makes existing ocis storages incompatible with the new code.
We also streamlined the ocis and the s3ng drivers so that most of the code is shared between them.
-
Enhancement #1514: Add grpc test suite for the storage provider
A new test suite has been added which tests the grpc interface to the storage provider. It currently runs against the ocis and the owncloud storage drivers.
-
Enhancement #1466: Add integration tests for the s3ng driver
We extended the integration test suite to also run all tests against the s3ng driver.
-
Enhancement #1521: Clarify expected failures
Some features, while covered by the ownCloud 10 acceptance tests, will not be implmented for now: - blacklisted / ignored files, because ocis/reva don't need to blacklist
.htaccessfiles -OC-LazyOpssupport was removed from the clients. We are thinking about a state machine for uploads to properly solve that scenario and also list the state of files in progress in the web ui. The expected failures files now have a dedicated Won't fix section for these items. -
Enhancement #1624: Add wrappers for EOS and EOS Home storage drivers
For CERNBox, we need the mount ID to be configured according to the owner of a resource. Setting this in the storageprovider means having different instances of this service to cater to different users, which does not scale. This driver forms a wrapper around the EOS driver and sets the mount ID according to a configurable mapping based on the owner of the resource.
-
Enhancement #1563: Implement cs3.sharing.collaboration.v1beta1.Share.ShareType
Interface method Share() in pkg/ocm/share/share.go now has a share type parameter.
-
Enhancement #1411: Make InsecureSkipVerify configurable
Add
InsecureSkipVerifyfield tometrics.Configstruct and update examples to include it. -
Enhancement #1106: Make command to run litmus tests
This updates adds an extra make command to run litmus tests via make.
make litmus-testexecutes the tests. -
Enhancement #1502: Bump meshdirectory-web to v1.0.4
Updated meshdirectory-web version to v.1.0.4 bringing multiple UX improvements in provider list and map.
cs3org#1502 sciencemesh/meshdirectory-web#2 sciencemesh/meshdirectory-web#3
-
Enhancement #1502: New MeshDirectory HTTP service UI frontend with project branding
We replaced the temporary version of web frontend of the mesh directory http service with a new redesigned & branded one. Because the new version is a more complex Vue SPA that contains image, css and other assets, it is now served from a binary package distribution that was generated using the github.com/rakyll/statik package. The
http.services.meshdirectory.staticconfig option was obsoleted by this change. -
Enhancement #1405: Quota querying and tree accounting
The ocs api now returns the user quota for the users home storage. Furthermore, the ocis storage driver now reads the quota from the extended attributes of the user home or root node and implements tree size accounting. Finally, ocdav PROPFINDS now handle the
DAV:quota-used-bytesandDAV:quote-available-bytesproperties. -
Enhancement #1527: Add FindAcceptedUsers method to OCM Invite API
-
Enhancement #1149: Add CLI Commands for OCM invitation workflow
This adds a couple of CLI commands,
ocm-invite-generateandocm-invite-forwardto generate and forward ocm invitation tokens respectively. -
Enhancement #1629: Implement checksums in the owncloud storage
Implemented checksums in the owncloud storage driver.
-
Enhancement #1528: Port drone pipeline definition to starlark
Having the pipeline definition as a starlark script instead of plain yaml greatly improves the flexibility and allows for removing lots of duplicated definitions.
-
Enhancement #110: Add signature authentication for public links
Implemented signature authentication for public links in addition to the existing password authentication. This allows web clients to efficiently download files from password protected public shares.
-
Enhancement #1495: SQL driver for the publicshare service
-
Enhancement #1588: Make the additional info attribute for shares configurable
AdditionalInfoAttribute can be configured via the
additional_info_attributekey in the form of a Go template string. If not explicitly set, the default value is{{.Mail}} -
Enhancement #1595: Add site account registration panel
This PR adds a site account registration panel to the site accounts service. It also removes site registration from the xcloud metrics driver.
-
Enhancement #1506: Site Accounts service for API keys
This update adds a new service to Reva that handles site accounts creation and management. Registered sites can be assigned an API key through a simple web interface which is also part of this service. This API key can then be used to identify a user and his/her associated (vendor or partner) site.
Furthermore, Mentix was extended to make use of this new service. This way, all sites now have a stable and unique site ID that not only avoids ID collisions but also introduces a new layer of security (i.e., sites can only be modified or removed using the correct API key).
-
Enhancement #116: Enhance storage registry with virtual views and regular expressions
Add the functionality to the storage registry service to handle user requests for references which can span across multiple storage providers, particularly useful for cases where directories are sharded across providers or virtual views are expected.
-
Enhancement #1513: Add stubs for storage spaces manipulation
This PR adds stubs for the storage space CRUD methods in the storageprovider service and makes the expired shares janitor configureable in the publicshares SQL driver.
The following sections list the changes in reva 1.6.0 relevant to reva users. The changes are ordered by importance.
- Fix #1425: Align href URL encoding with oc10
- Fix #1461: Fix public link webdav permissions
- Fix #1457: Cloning of internal mesh data lost some values
- Fix #1429: Purge non-empty dirs from trash-bin
- Fix #1408: Get error status from trash-bin response
- Enh #1451: Render additional share with in ocs sharing api
- Enh #1424: We categorized the list of expected failures
- Enh #1434: CERNBox REST driver for groupprovider service
- Enh #1400: Checksum support
- Enh #1431: Update npm packages to fix vulnerabilities
- Enh #1415: Indicate in EOS containers that TUS is not supported
- Enh #1402: Parse EOS sys ACLs to generate CS3 resource permissions
- Enh #1477: Set quota when creating home directory in EOS
- Enh #1416: Use updated etag of home directory even if it is cached
- Enh #1478: Enhance error handling for grappa REST drivers
- Enh #1453: Add functionality to share resources with groups
- Enh #99: Add stubs and manager for groupprovider service
- Enh #1462: Hash public share passwords
- Enh #1464: LDAP driver for the groupprovider service
- Enh #1430: Capture non-deterministic behavior on storages
- Enh #1456: Fetch user groups in OIDC and LDAP backend
- Enh #1429: Add s3ng storage driver, storing blobs in a s3-compatible blobstore
- Enh #1467: Align default location for xrdcopy binary
-
Bugfix #1425: Align href URL encoding with oc10
We now use the same percent encoding for URLs in WebDAV href properties as ownCloud 10.
owncloud/ocis#1120 owncloud/ocis#1296 owncloud/ocis#1307 cs3org#1425 cs3org#1472
-
Bugfix #1461: Fix public link webdav permissions
We now correctly render
oc:permissionson the root collection of a publicly shared folder when it has more than read permissions. -
Bugfix #1457: Cloning of internal mesh data lost some values
This update fixes a bug in Mentix that caused some (non-critical) values to be lost during data cloning that happens internally.
-
Bugfix #1429: Purge non-empty dirs from trash-bin
This wasn't possible before if the directory was not empty
-
Bugfix #1408: Get error status from trash-bin response
Previously the status code was gathered from the wrong response.
-
Enhancement #1451: Render additional share with in ocs sharing api
Recipients can now be distinguished by their email, which is rendered as additional info in the ocs api for share and file owners as well as share recipients.
-
Enhancement #1424: We categorized the list of expected failures
We categorized all expected failures into File (Basic file management like up and download, move, copy, properties, trash, versions and chunking), Sync (Synchronization features like etag propagation, setting mtime and locking files), Share (File and sync features in a shared scenario), User management (User and group management features) and Other (API, search, favorites, config, capabilities, not existing endpoints, CORS and others). The Review and fix the tests that have sharing step to work with ocis reference has been removed, as we now have the sharing category
-
Enhancement #1434: CERNBox REST driver for groupprovider service
-
Enhancement #1400: Checksum support
We now support checksums on file uploads and PROPFIND results. On uploads, the ocdav service now forwards the
OC-Checksum(and the similar TUSUpload-Checksum) header to the storage provider. We added an internal http status code that allows storage drivers to return checksum errors. On PROPFINDs, ocdav now renders the<oc:checksum>header in a bug compatible way for oc10 backward compatibility with existing clients. Finally, GET and HEAD requests now return theOC-Checksumheader.owncloud/ocis#1291 owncloud/ocis#1316 cs3org#1400 owncloud/core#38304
-
Enhancement #1431: Update npm packages to fix vulnerabilities
-
Enhancement #1415: Indicate in EOS containers that TUS is not supported
The OCDAV propfind response previously hardcoded the TUS headers due to which clients such as phoenix used the TUS protocol for uploads, which EOS doesn't support. Now we pass this property as an opaque entry in the containers metadata.
-
Enhancement #1402: Parse EOS sys ACLs to generate CS3 resource permissions
-
Enhancement #1477: Set quota when creating home directory in EOS
-
Enhancement #1416: Use updated etag of home directory even if it is cached
We cache the home directory and shares folder etags as calculating these is an expensive process. But if these directories were updated after the previously calculated etag was cached, we can ignore this calculation and directly return the new one.
-
Enhancement #1478: Enhance error handling for grappa REST drivers
-
Enhancement #1453: Add functionality to share resources with groups
-
Enhancement #99: Add stubs and manager for groupprovider service
Recently, there was a separation of concerns with regard to users and groups in CS3APIs. This PR adds the required stubs and drivers for the group manager.
-
Enhancement #1462: Hash public share passwords
The share passwords were only base64 encoded. Added hashing using bcrypt with configurable hash cost.
-
Enhancement #1464: LDAP driver for the groupprovider service
-
Enhancement #1430: Capture non-deterministic behavior on storages
As a developer creating/maintaining a storage driver I want to be able to validate the atomicity of all my storage driver operations. * Test for: Start 2 uploads, pause the first one, let the second one finish first, resume the first one at some point in time. Both uploads should finish. Needs to result in 2 versions, last finished is the most recent version. * Test for: Start 2 MKCOL requests with the same path, one needs to fail.
-
Enhancement #1456: Fetch user groups in OIDC and LDAP backend
-
Enhancement #1429: Add s3ng storage driver, storing blobs in a s3-compatible blobstore
We added a new storage driver (s3ng) which stores the file metadata on a local filesystem (reusing the decomposed filesystem of the ocis driver) and the actual content as blobs in any s3-compatible blobstore.
-
Enhancement #1467: Align default location for xrdcopy binary
The following sections list the changes in reva 1.5.1 relevant to reva users. The changes are ordered by importance.
- Fix #1401: Use the user in request for deciding the layout for non-home DAV requests
- Fix #1413: Re-include the '.git' dir in the Docker images to pass the version tag
- Fix #1399: Fix ocis trash-bin purge
- Enh #1397: Bump the Copyright date to 2021
- Enh #1398: Support site authorization status in Mentix
- Enh #1393: Allow setting favorites, mtime and a temporary etag
- Enh #1403: Support remote cloud gathering metrics
-
Bugfix #1401: Use the user in request for deciding the layout for non-home DAV requests
For the incoming /dav/files/userID requests, we have different namespaces depending on whether the request is for the logged-in user's namespace or not. Since in the storage drivers, we specify the layout depending only on the user whose resources are to be accessed, this fails when a user wants to access another user's namespace when the storage provider depends on the logged in user's namespace. This PR fixes that.
For example, consider the following case. The owncloud fs uses a layout {{substr 0 1 .Id.OpaqueId}}/{{.Id.OpaqueId}}. The user einstein sends a request to access a resource shared with him, say /dav/files/marie/abcd, which should be allowed. However, based on the way we applied the layout, there's no way in which this can be translated to /m/marie/.
-
Bugfix #1413: Re-include the '.git' dir in the Docker images to pass the version tag
And git SHA to the release tool.
-
Bugfix #1399: Fix ocis trash-bin purge
Fixes the empty trash-bin functionality for ocis-storage
-
Enhancement #1397: Bump the Copyright date to 2021
-
Enhancement #1398: Support site authorization status in Mentix
This enhancement adds support for a site authorization status to Mentix. This way, sites registered via a web app can now be excluded until authorized manually by an administrator.
Furthermore, Mentix now sets the scheme for Prometheus targets. This allows us to also support monitoring of sites that do not support the default HTTPS scheme.
-
Enhancement #1393: Allow setting favorites, mtime and a temporary etag
We now let the ocis driver persist favorites, set temporary etags and the mtime as arbitrary metadata.
-
Enhancement #1403: Support remote cloud gathering metrics
The current metrics package can only gather metrics either from json files. With this feature, the metrics can be gathered polling the http endpoints exposed by the owncloud/nextcloud sciencemesh apps.
The following sections list the changes in reva 1.5.0 relevant to reva users. The changes are ordered by importance.
- Fix #1385: Run changelog check only if there are changes in the code
- Fix #1333: Delete sdk unit tests
- Fix #1342: Dav endpoint routing to home storage when request is remote.php/dav/files
- Fix #1338: Fix fd leaks
- Fix #1343: Fix ocis move
- Fix #551: Fix purging deleted files with the ocis storage
- Fix #863: Fix dav api for trashbin
- Fix #204: Fix the ocs share with me response
- Fix #1351: Fix xattr.Remove error check for macOS
- Fix #1320: Do not panic on remote.php/dav/files/
- Fix #1379: Make Jaeger agent usable
- Fix #1331: Fix capabilities response for multiple client versions
- Fix #1281: When sharing via ocs look up user by username
- Fix #1334: Handle removal of public shares by token or ID
- Chg #990: Replace the user uuid with the username in ocs share responses
- Enh #1350: Add auth protocol based on user agent
- Enh #1362: Mark 'store-dev-release' CI step as failed on 4XX/5XX errors
- Enh #1364: Remove expired Link on Get
- Enh #1340: Add cache to store UID to UserID mapping in EOS
- Enh #1154: Add support for the protobuf interface to eos metadata
- Enh #1154: Merge-rebase from master 10/11/2020
- Enh #1359: Add cache for calculated etags for home and shares directory
- Enh #1321: Add support for multiple data transfer protocols
- Enh #1324: Log expected errors with debug level
- Enh #1351: Map errtypes to status
- Enh #1347: Support property to enable health checking on a service
- Enh #1332: Add import support to Mentix
- Enh #1371: Use self-hosted Drone CI
- Enh #1354: Map bad request and unimplement to http status codes
- Enh #929: Include share types in ocs propfind responses
- Enh #1328: Add CLI commands for public shares
- Enh #1388: Support range header in GET requests
- Enh #1361: Remove expired Link on Access
- Enh #1386: Docker image for cs3org/revad:VERSION-eos
- Enh #1368: Calculate and expose actual file permission set
-
Bugfix #1385: Run changelog check only if there are changes in the code
-
Bugfix #1333: Delete sdk unit tests
These depend on a remote server running reva and thus fail in case of version mismatches.
-
Bugfix #1342: Dav endpoint routing to home storage when request is remote.php/dav/files
There was a regression in which we were not routing correctly to the right storage depending on the url.
-
Bugfix #1338: Fix fd leaks
There were some left over open file descriptors on simple.go.
-
Bugfix #1343: Fix ocis move
Use the old node id to build the target path for xattr updates.
-
Bugfix #551: Fix purging deleted files with the ocis storage
The ocis storage could load the owner information of a deleted file. This caused the storage to not be able to purge deleted files.
-
Bugfix #863: Fix dav api for trashbin
The api was comparing the requested username to the userid.
-
Bugfix #204: Fix the ocs share with me response
The path of the files shared with me was incorrect.
-
Bugfix #1351: Fix xattr.Remove error check for macOS
Previously, we checked the xattr.Remove error only for linux systems. Now macOS is checked also
-
Bugfix #1320: Do not panic on remote.php/dav/files/
Currently requests to /remote.php/dav/files/ result in panics since we cannot longer strip the user + destination from the url. This fixes the server response code and adds an error body to the response.
-
Bugfix #1379: Make Jaeger agent usable
Previously, you could not use tracing with jaeger agent because the tracing connector is always used instead of the tracing endpoint.
This PR removes the defaults for collector and tracing endpoint.
-
Bugfix #1331: Fix capabilities response for multiple client versions
-
Bugfix #1281: When sharing via ocs look up user by username
The ocs api returns usernames when listing share recipients, so the lookup when creating the share needs to search the usernames and not the userid.
-
Bugfix #1334: Handle removal of public shares by token or ID
Previously different drivers handled removing public shares using different means, either the token or the ID. Now, both the drivers support both these methods.
-
Change #990: Replace the user uuid with the username in ocs share responses
The ocs api should not send the users uuid. Replaced the uuid with the username.
-
Enhancement #1350: Add auth protocol based on user agent
Previously, all available credential challenges are given to the client, for example, basic auth, bearer token, etc ... Different clients have different priorities to use one method or another, and before it was not possible to force a client to use one method without having a side effect on other clients.
This PR adds the functionality to target a specific auth protocol based on the user agent HTTP header.
-
Enhancement #1362: Mark 'store-dev-release' CI step as failed on 4XX/5XX errors
Prevent the errors while storing new 'daily' releases from going unnoticed on the CI.
-
Enhancement #1364: Remove expired Link on Get
There is the scenario in which a public link has expired but ListPublicLink has not run, accessing a technically expired public share is still possible.
-
Enhancement #1340: Add cache to store UID to UserID mapping in EOS
Previously, we used to send an RPC to the user provider service for every lookup of user IDs from the UID stored in EOS. This PR adds an in-memory lock-protected cache to store this mapping.
-
Enhancement #1154: Add support for the protobuf interface to eos metadata
-
Enhancement #1154: Merge-rebase from master 10/11/2020
-
Enhancement #1359: Add cache for calculated etags for home and shares directory
Since we store the references in the shares directory instead of actual resources, we need to calculate the etag on every list/stat call. This is rather expensive so adding a cache would help to a great extent with regard to the performance.
-
Enhancement #1321: Add support for multiple data transfer protocols
Previously, we had to configure which data transfer protocol to use in the dataprovider service. A previous PR added the functionality to redirect requests to different handlers based on the request method but that would lead to conflicts if multiple protocols don't support mutually exclusive sets of requests. This PR adds the functionality to have multiple such handlers simultaneously and the client can choose which protocol to use.
-
Enhancement #1324: Log expected errors with debug level
While trying to download a non existing file and reading a non existing attribute are technically an error they are to be expected and nothing an admin can or even should act upon.
-
Enhancement #1351: Map errtypes to status
When mapping errtypes to grpc statuses we now also map bad request and not implemented / unsupported cases in the gateway storageprovider.
-
Enhancement #1347: Support property to enable health checking on a service
This update introduces a new service property called
ENABLE_HEALTH_CHECKSthat must be explicitly set totrueif a service should be checked for its health status. This allows us to only enable these checks for partner sites only, skipping vendor sites. -
Enhancement #1332: Add import support to Mentix
This update adds import support to Mentix, transforming it into a Mesh Entity Exchanger. To properly support vendor site management, a new connector that works on a local file has been added as well.
-
Enhancement #1371: Use self-hosted Drone CI
Previously, we used the drone cloud to run the CI for the project. Due to unexpected and sudden stop of the service for the cs3org we decided to self-host it.
-
Enhancement #1354: Map bad request and unimplement to http status codes
We now return a 400 bad request when a grpc call fails with an invalid argument status and a 501 not implemented when it fails with an unimplemented status. This prevents 500 errors when a user tries to add resources to the Share folder or a storage does not implement an action.
-
Enhancement #929: Include share types in ocs propfind responses
Added the share types to the ocs propfind response when a resource has been shared.
-
Enhancement #1328: Add CLI commands for public shares
-
Enhancement #1388: Support range header in GET requests
To allow resuming a download we now support GET requests with a range header.
-
Enhancement #1361: Remove expired Link on Access
Since there is no background jobs scheduled to wipe out expired resources, for the time being public links are going to be removed on a "on demand" basis, meaning whenever there is an API call that access the list of shares for a given resource, we will check whether the share is expired and delete it if so.
-
Enhancement #1386: Docker image for cs3org/revad:VERSION-eos
Based on eos:c8_4.8.15 (Centos8, version 4.8.15). To be used when the Reva daemon needs IPC with xrootd/eos via stdin/out.
-
Enhancement #1368: Calculate and expose actual file permission set
Instead of hardcoding the permissions set for every file and folder to ListContainer:true, CreateContainer:true and always reporting the hardcoded string WCKDNVR for the WebDAV permissions we now aggregate the actual cs3 resource permission set in the storage drivers and correctly map them to ocs permissions and webdav permissions using a common role struct that encapsulates the mapping logic.
owncloud/ocis#552 owncloud/ocis#762 owncloud/ocis#763 owncloud/ocis#893 owncloud/ocis#1126 https://github.com/owncloud/ocis-reva/issues/47 https://github.com/owncloud/ocis-reva/issues/315 https://github.com/owncloud/ocis-reva/issues/316 owncloud/product#270 cs3org#1368
The following sections list the changes in reva 1.4.0 relevant to reva users. The changes are ordered by importance.
- Fix #1316: Fix listing shares for nonexisting path
- Fix #1274: Let the gateway filter invalid references
- Fix #1269: Handle more eos errors
- Fix #1297: Check the err and the response status code
- Fix #1260: Fix file descriptor leak on ocdav put handler
- Fix #1253: Upload file to storage provider after assembling chunks
- Fix #1264: Fix etag propagation in ocis driver
- Fix #1255: Check current node when iterating over path segments
- Fix #1265: Stop setting propagation xattr on new files
- Fix #260: Filter share with me requests
- Fix #1317: Prevent nil pointer when listing shares
- Fix #1259: Fix propfind response code on forbidden files
- Fix #1294: Fix error type in read node when file was not found
- Fix #1258: Update share grants on share update
- Enh #1257: Add a test user to all sites
- Enh #1234: Resolve a WOPI bridge appProviderURL by extracting its redirect
- Enh #1239: Add logic for finding groups to user provider service
- Enh #1280: Add a Reva SDK
- Enh #1237: Setup of grpc transfer service and cli
- Enh #1224: Add SQL driver for share manager
- Enh #1285: Refactor the uploading files workflow from various clients
- Enh #1233: Add support for custom CodiMD mimetype
-
Bugfix #1316: Fix listing shares for nonexisting path
When trying to list shares for a not existing file or folder the ocs sharing implementation no longer responds with the wrong status code and broken xml.
-
Bugfix #1274: Let the gateway filter invalid references
We now filter deleted and unshared entries from the response when listing the shares folder of a user.
-
Bugfix #1269: Handle more eos errors
We now treat E2BIG, EACCES as a permission error, which occur, eg. when acl checks fail and return a permission denied error.
-
Bugfix #1297: Check the err and the response status code
The publicfile handler needs to check the response status code to return proper not pound and permission errors in the webdav api.
-
Bugfix #1260: Fix file descriptor leak on ocdav put handler
File descriptors on the ocdav service, especially on the put handler was leaking http connections. This PR addresses this.
-
Bugfix #1253: Upload file to storage provider after assembling chunks
In the PUT handler for chunked uploads in ocdav, we store the individual chunks in temporary file but do not write the assembled file to storage. This PR fixes that.
-
Bugfix #1264: Fix etag propagation in ocis driver
We now use a new synctime timestamp instead of trying to read the mtime to avoid race conditions when the stat request happens too quickly.
-
Bugfix #1255: Check current node when iterating over path segments
When checking permissions we were always checking the leaf instead of using the current node while iterating over path segments.
-
Bugfix #1265: Stop setting propagation xattr on new files
We no longer set the propagation flag on a file because it is only evaluated for folders anyway.
-
Bugfix #260: Filter share with me requests
The OCS API now properly filters share with me requests by path and by share status (pending, accepted, rejected, all)
https://github.com/owncloud/ocis-reva/issues/260 https://github.com/owncloud/ocis-reva/issues/311 cs3org#1301
-
Bugfix #1317: Prevent nil pointer when listing shares
We now handle cases where the grpc connection failed correctly by no longer trying to access the response status.
-
Bugfix #1259: Fix propfind response code on forbidden files
When executing a propfind to a resource owned by another user the service would respond with a HTTP 403. In ownCloud 10 the response was HTTP 207. This change sets the response code to HTTP 207 to stay backwards compatible.
-
Bugfix #1294: Fix error type in read node when file was not found
The method ReadNode in the ocis storage didn't return the error type NotFound when a file was not found.
-
Bugfix #1258: Update share grants on share update
When a share was updated the share information in the share manager was updated but the grants set by the storage provider were not.
-
Enhancement #1257: Add a test user to all sites
For health monitoring of all mesh sites, we need a special user account that is present on every site. This PR adds such a user to each users-*.json file so that every site will have the same test user credentials.
-
Enhancement #1234: Resolve a WOPI bridge appProviderURL by extracting its redirect
Applications served by the WOPI bridge (CodiMD for the time being) require an extra redirection as the WOPI bridge itself behaves like a user app. This change returns to the client the redirected URL from the WOPI bridge, which is the real application URL.
-
Enhancement #1239: Add logic for finding groups to user provider service
To create shares with user groups, the functionality for searching for these based on a pattern is needed. This PR adds that.
-
Enhancement #1280: Add a Reva SDK
A Reva SDK has been added to make working with a remote Reva instance much easier by offering a high-level API that hides all the underlying details of the CS3API.
-
Enhancement #1237: Setup of grpc transfer service and cli
The grpc transfer service and cli for it.
-
Enhancement #1224: Add SQL driver for share manager
This PR adds an SQL driver for the shares manager which expects a schema equivalent to the one used in production for CERNBox.
-
Enhancement #1285: Refactor the uploading files workflow from various clients
Previously, we were implementing the tus client logic in the ocdav service, leading to restricting the whole of tus logic to the internal services. This PR refactors that workflow to accept incoming requests following the tus protocol while using simpler transmission internally.
-
Enhancement #1233: Add support for custom CodiMD mimetype
The new mimetype is associated with the
.zmdfile extension. The corresponding configuration is associated with the storageprovider.
The following sections list the changes in reva 1.3.0 relevant to reva users. The changes are ordered by importance.
- Fix #1140: Call the gateway stat method from appprovider
- Fix #1170: Up and download of file shares
- Fix #1177: Fix ocis move
- Fix #1178: Fix litmus failing on ocis storage
- Fix #237: Fix missing quotes on OCIS-Storage
- Fix #1210: No longer swallow permissions errors in the gateway
- Fix #1183: Handle eos EPERM as permission denied
- Fix #1206: No longer swallow permissions errors
- Fix #1207: No longer swallow permissions errors in ocdav
- Fix #1161: Cache display names in ocs service
- Fix #1216: Add error handling for invalid references
- Enh #1205: Allow using the username when accessing the users home
- Enh #1131: Use updated cato to display nested package config in parent docs
- Enh #1213: Check permissions in ocis driver
- Enh #1202: Check permissions in owncloud driver
- Enh #1228: Add GRPC stubs for CreateSymlink method
- Enh #1174: Add logic in EOS FS for maintaining same inode across file versions
- Enh #1142: Functionality to map home directory to different storage providers
- Enh #1190: Add Blackbox Exporter support to Mentix
- Enh #1229: New gateway datatx service
- Enh #1225: Allow setting the owner when using the ocis driver
- Enh #1180: Introduce ocis driver treetime accounting
- Enh #1208: Calculate etags on-the-fly for shares directory and home folder
-
Bugfix #1140: Call the gateway stat method from appprovider
The appprovider service used to directly pass the stat request to the storage provider bypassing the gateway, which resulted in errors while handling share children as they are resolved in the gateway path.
-
Bugfix #1170: Up and download of file shares
The shared folder logic in the gateway storageprovider was not allowing file up and downloads for single file shares. We now check if the reference is actually a file to determine if up / download should be allowed.
-
Bugfix #1177: Fix ocis move
When renaming a file we updating the name attribute on the wrong node, causing the path construction to use the wrong name. This fixes the litmus move_coll test.
-
Bugfix #1178: Fix litmus failing on ocis storage
We now ignore the
no data availableerror when removing a non existing metadata attribute, which is ok because we are trying to delete it anyway. -
Bugfix #237: Fix missing quotes on OCIS-Storage
Etags have to be enclosed in quotes ". Return correct etags on OCIS-Storage.
-
Bugfix #1210: No longer swallow permissions errors in the gateway
The gateway is no longer ignoring permissions errors. It will now check the status for
rpc.Code_CODE_PERMISSION_DENIEDcodes and report them properly usingstatus.NewPermissionDeniedorstatus.NewInternalinstead of reusing the original response status. -
Bugfix #1183: Handle eos EPERM as permission denied
We now treat EPERM errors, which occur, eg. when acl checks fail and return a permission denied error.
-
Bugfix #1206: No longer swallow permissions errors
The storageprovider is no longer ignoring permissions errors. It will now report them properly using
status.NewPermissionDenied(...)instead ofstatus.NewInternal(...) -
Bugfix #1207: No longer swallow permissions errors in ocdav
The ocdav api is no longer ignoring permissions errors. It will now check the status for
rpc.Code_CODE_PERMISSION_DENIEDcodes and report them properly usinghttp.StatusForbiddeninstead ofhttp.StatusInternalServerError -
Bugfix #1161: Cache display names in ocs service
The ocs list shares endpoint may need to fetch the displayname for multiple different users. We are now caching the lookup fo 60 seconds to save redundant RPCs to the users service.
-
Bugfix #1216: Add error handling for invalid references
-
Enhancement #1205: Allow using the username when accessing the users home
We now allow using the userid and the username when accessing the users home on the
/dev/filesendpoint. -
Enhancement #1131: Use updated cato to display nested package config in parent docs
Previously, in case of nested packages, we just had a link pointing to the child package. Now we copy the nested package's documentation to the parent itself to make it easier for devs.
-
Enhancement #1213: Check permissions in ocis driver
We are now checking grant permissions in the ocis storage driver.
-
Enhancement #1202: Check permissions in owncloud driver
We are now checking grant permissions in the owncloud storage driver.
-
Enhancement #1228: Add GRPC stubs for CreateSymlink method
-
Enhancement #1174: Add logic in EOS FS for maintaining same inode across file versions
This PR adds the functionality to maintain the same inode across various versions of a file by returning the inode of the version folder which remains constant. It requires extra metadata operations so a flag is provided to disable it.
-
Enhancement #1142: Functionality to map home directory to different storage providers
We hardcode the home path for all users to /home. This forbids redirecting requests for different users to multiple storage providers. This PR provides the option to map the home directories of different users using user attributes.
-
Enhancement #1190: Add Blackbox Exporter support to Mentix
This update extends Mentix to export a Prometheus SD file specific to the Blackbox Exporter which will be used for initial health monitoring. Usually, Prometheus requires its targets to only consist of the target's hostname; the BBE though expects a full URL here. This makes exporting two distinct files necessary.
-
Enhancement #1229: New gateway datatx service
Represents the CS3 datatx module in the gateway.
-
Enhancement #1225: Allow setting the owner when using the ocis driver
To support the metadata storage we allow setting the owner of the root node so that subsequent requests with that owner can be used to manage the storage.
-
Enhancement #1180: Introduce ocis driver treetime accounting
We added tree time accounting to the ocis storage driver which is modeled after eos synctime accounting. It can be enabled using the new
treetime_accountingoption, which defaults tofalseThetmtimeis stored in an extended attributeuser.ocis.tmtime. The treetime accounting is enabled for nodes which have theuser.ocis.propagationextended attribute set to"1". Currently, propagation is in sync. -
Enhancement #1208: Calculate etags on-the-fly for shares directory and home folder
We create references for accepted shares in the shares directory, but these aren't updated when the original resource is modified. This PR adds the functionality to generate the etag for the shares directory and correspondingly, the home directory, based on the actual resources which the references point to, enabling the sync functionality.
The following sections list the changes in reva 1.2.1 relevant to reva users. The changes are ordered by importance.
- Fix #1124: Do not swallow 'not found' errors in Stat
- Enh #1125: Rewire dav files to the home storage
- Enh #559: Introduce ocis storage driver
- Enh #1118: Metrics module can be configured to retrieve metrics data from file
-
Bugfix #1124: Do not swallow 'not found' errors in Stat
Webdav needs to determine if a file exists to return 204 or 201 response codes. When stating a non existing resource the NOT_FOUND code was replaced with an INTERNAL error code. This PR passes on a NOT_FOUND status code in the gateway.
-
Enhancement #1125: Rewire dav files to the home storage
If the user specified in the dav files URL matches the current one, rewire it to use the webDavHandler which is wired to the home storage.
This fixes path mapping issues.
-
Enhancement #559: Introduce ocis storage driver
We introduced a now storage driver
ocisthat deconstructs a filesystem and uses a node first approach to implement an efficient lookup of files by path as well as by file id. -
Enhancement #1118: Metrics module can be configured to retrieve metrics data from file
- Export site metrics in Prometheus #698
The following sections list the changes in reva 1.2.0 relevant to reva users. The changes are ordered by importance.
- Fix #1099: Do not restore recycle entry on purge
- Fix #1091: Allow listing the trashbin
- Fix #1103: Restore and delete trash items via ocs
- Fix #1090: Ensure ignoring public stray shares
- Fix #1064: Ensure ignoring stray shares
- Fix #1082: Minor fixes in reva cmd, gateway uploads and smtpclient
- Fix #1115: Owncloud driver - propagate mtime on RemoveGrant
- Fix #1111: Handle redirection prefixes when extracting destination from URL
- Enh #1101: Add UID and GID in ldap auth driver
- Enh #1077: Add calens check to verify changelog entries in CI
- Enh #1072: Refactor Reva CLI with prompts
- Enh #1079: Get file info using fxids from EOS
- Enh #1088: Update LDAP user driver
- Enh #1114: System information metrics cleanup
- Enh #1071: System information included in Prometheus metrics
- Enh #1094: Add logic for resolving storage references over webdav
-
Bugfix #1099: Do not restore recycle entry on purge
This PR fixes a bug in the EOSFS driver that was restoring a deleted entry when asking for its permanent purge. EOS does not have the functionality to purge individual files, but the whole recycle of the user.
-
Bugfix #1091: Allow listing the trashbin
The trashbin endpoint expects the userid, not the username.
-
Bugfix #1103: Restore and delete trash items via ocs
The OCS api was not passing the correct key and references to the CS3 API. Furthermore, the owncloud storage driver was constructing the wrong target path when restoring.
-
Bugfix #1090: Ensure ignoring public stray shares
When using the json public shares manager, it can be the case we found a share with a resource_id that no longer exists.
-
Bugfix #1064: Ensure ignoring stray shares
When using the json shares manager, it can be the case we found a share with a resource_id that no longer exists. This PR aims to address his case by changing the contract of getPath and return the result of the STAT call instead of a generic error, so we can check the cause.
-
Bugfix #1082: Minor fixes in reva cmd, gateway uploads and smtpclient
-
Bugfix #1115: Owncloud driver - propagate mtime on RemoveGrant
When removing a grant the mtime change also needs to be propagated. Only affectsn the owncluod storage driver.
-
Bugfix #1111: Handle redirection prefixes when extracting destination from URL
The move function handler in ocdav extracts the destination path from the URL by removing the base URL prefix from the URL path. This would fail in case there is a redirection prefix. This PR takes care of that and it also allows zero-size uploads for localfs.
-
Enhancement #1101: Add UID and GID in ldap auth driver
The PR cs3org#1088 added the functionality to lookup UID and GID from the ldap user provider. This PR adds the same to the ldap auth manager.
-
Enhancement #1077: Add calens check to verify changelog entries in CI
-
Enhancement #1072: Refactor Reva CLI with prompts
The current CLI is a bit cumbersome to use with users having to type commands containing all the associated config with no prompts or auto-completes. This PR refactors the CLI with these functionalities.
-
Enhancement #1079: Get file info using fxids from EOS
This PR supports getting file information from EOS using the fxid value.
-
Enhancement #1088: Update LDAP user driver
The LDAP user driver can now fetch users by a single claim / attribute. Use an
attributefilterlike(&(objectclass=posixAccount)({{attr}}={{value}}))in the driver section.It also adds the uid and gid to the users opaque properties so that eos can use them for chown and acl operations.
-
Enhancement #1114: System information metrics cleanup
The system information metrics are now based on OpenCensus instead of the Prometheus client library. Furthermore, its initialization was moved out of the Prometheus HTTP service to keep things clean.
-
Enhancement #1071: System information included in Prometheus metrics
System information is now included in the main Prometheus metrics exposed at
/metrics. -
Enhancement #1094: Add logic for resolving storage references over webdav
This PR adds the functionality to resolve webdav references using the ocs webdav service by passing the resource's owner's token. This would need to be changed in production.
The following sections list the changes in reva 1.1.0 relevant to reva users. The changes are ordered by importance.
- Fix #1069: Pass build time variables while compiling
- Fix #1047: Fix missing idp check in GetUser of demo userprovider
- Fix #1038: Do not stat shared resources when downloading
- Fix #1034: Fixed some error reporting strings and corresponding logs
- Fix #1046: Fixed resolution of fileid in GetPathByID
- Fix #1052: Ocfs: Lookup user to render template properly
- Fix #1024: Take care of trailing slashes in OCM package
- Fix #1025: Use lower-case name for changelog directory
- Fix #1042: List public shares only created by the current user
- Fix #1051: Disallow sharing the shares directory
- Enh #1035: Refactor AppProvider workflow
- Enh #1059: Improve timestamp precision while logging
- Enh #1037: System information HTTP service
- Enh #995: Add UID and GID to the user object from user package
-
Bugfix #1069: Pass build time variables while compiling
We provide the option of viewing various configuration and version options in both reva CLI as well as the reva daemon, but we didn't actually have these values in the first place. This PR adds that info at compile time.
-
Bugfix #1047: Fix missing idp check in GetUser of demo userprovider
We've added a check for matching idp in the GetUser function of the demo userprovider
-
Bugfix #1038: Do not stat shared resources when downloading
Previously, we statted the resources in all download requests resulting in failures when downloading references. This PR fixes that by statting only in case the resource is not present in the shares folder. It also fixes a bug where we allowed uploading to the mount path, resulting in overwriting the user home directory.
-
Bugfix #1034: Fixed some error reporting strings and corresponding logs
-
Bugfix #1046: Fixed resolution of fileid in GetPathByID
Following refactoring of fileid generations in the local storage provider, this ensures fileid to path resolution works again.
-
Bugfix #1052: Ocfs: Lookup user to render template properly
Currently, the username is used to construct paths, which breaks when mounting the
owncloudstorage driver at/ocand then expecting paths that use the username like/oc/einstein/footo work, because they will mismatch the path that is used from propagation which uses/oc/u-u-i-das the root, giving aninternal path outside rooterror -
Bugfix #1024: Take care of trailing slashes in OCM package
Previously, we assumed that the OCM endpoints would have trailing slashes, failing in case they didn't. This PR fixes that.
-
Bugfix #1025: Use lower-case name for changelog directory
When preparing a new release, the changelog entries need to be copied to the changelog folder under docs. In a previous change, all these folders were made to have lower case names, resulting in creation of a separate folder.
-
Bugfix #1042: List public shares only created by the current user
When running ocis, the public links created by a user are visible to all the users under the 'Shared with others' tab. This PR fixes that by returning only those links which are created by a user themselves.
-
Bugfix #1051: Disallow sharing the shares directory
Previously, it was possible to create public links for and share the shares directory itself. However, when the recipient tried to accept the share, it failed. This PR prevents the creation of such shares in the first place.
-
Enhancement #1035: Refactor AppProvider workflow
Simplified the app-provider configuration: storageID is worked out automatically and UIURL is suppressed for now. Implemented the new gRPC protocol from the gateway to the appprovider.
-
Enhancement #1059: Improve timestamp precision while logging
Previously, the timestamp associated with a log just had the hour and minute, which made debugging quite difficult. This PR increases the precision of the associated timestamp.
-
Enhancement #1037: System information HTTP service
This service exposes system information via an HTTP endpoint. This currently only includes Reva version information but can be extended easily. The information are exposed in the form of Prometheus metrics so that we can gather these in a streamlined way.
-
Enhancement #995: Add UID and GID to the user object from user package
Currently, the UID and GID for users need to be read from the local system which requires local users to be present. This change retrieves that information from the user and auth packages and adds methods to retrieve it.
The following sections list the changes in reva 1.0.0 relevant to reva users. The changes are ordered by importance.
- Fix #941: Fix initialization of json share manager
- Fix #1006: Check if SMTP credentials are nil
- Chg #965: Remove protocol from partner domains to match gocdb config
- Enh #986: Added signing key capability
- Enh #922: Add tutorial for deploying WOPI and Reva locally
- Enh #979: Skip changelog enforcement for bot PRs
- Enh #965: Enforce adding changelog in make and CI
- Enh #1016: Do not enforce changelog on release
- Enh #969: Allow requests to hosts with unverified certificates
- Enh #914: Make httpclient configurable
- Enh #972: Added a site locations exporter to Mentix
- Enh #1000: Forward share invites to the provider selected in meshdirectory
- Enh #1002: Pass the link to the meshdirectory service in token mail
- Enh #1008: Use proper logging for ldap auth requests
- Enh #970: Add required headers to SMTP client to prevent being tagged as spam
- Enh #996: Split LDAP user filters
- Enh #1007: Update go-tus version
- Enh #1004: Update github.com/go-ldap/ldap to v3
- Enh #974: Add functionality to create webdav references for OCM shares
-
Bugfix #941: Fix initialization of json share manager
When an empty shares.json file existed the json share manager would fail while trying to unmarshal the empty file.
-
Bugfix #1006: Check if SMTP credentials are nil
Check if SMTP credentials are nil before passing them to the SMTPClient, causing it to crash.
-
Change #965: Remove protocol from partner domains to match gocdb config
Minor changes for OCM cross-partner testing.
-
Enhancement #986: Added signing key capability
The ocs capabilities can now hold the boolean flag to indicate url signing endpoint and middleware are available
-
Enhancement #922: Add tutorial for deploying WOPI and Reva locally
Add a new tutorial on how to run Reva and Wopiserver together locally
-
Enhancement #979: Skip changelog enforcement for bot PRs
Skip changelog enforcement for bot PRs.
-
Enhancement #965: Enforce adding changelog in make and CI
When adding a feature or fixing a bug, a changelog needs to be specified, failing which the build wouldn't pass.
-
Enhancement #1016: Do not enforce changelog on release
While releasing a new version of Reva, make release was failing because it was enforcing a changelog entry.
-
Enhancement #969: Allow requests to hosts with unverified certificates
Allow OCM to send requests to other mesh providers with the option of skipping certificate verification.
-
Enhancement #914: Make httpclient configurable
- Introduce Options for the httpclient (#914)
-
Enhancement #972: Added a site locations exporter to Mentix
Mentix now offers an endpoint that exposes location information of all sites in the mesh. This can be used in Grafana's world map view to show the exact location of every site.
-
Enhancement #1000: Forward share invites to the provider selected in meshdirectory
Added a share invite forward OCM endpoint to the provider links (generated when a user picks a target provider in the meshdirectory service web interface), together with an invitation token and originating provider domain passed to the service via query params.
-
Enhancement #1002: Pass the link to the meshdirectory service in token mail
Currently, we just forward the token and the original user's domain when forwarding an OCM invite token and expect the user to frame the forward invite URL. This PR instead passes the link to the meshdirectory service, from where the user can pick the provider they want to accept the invite with.
-
Enhancement #1008: Use proper logging for ldap auth requests
Instead of logging to stdout we now log using debug level logging or error level logging in case the configured system user cannot bind to LDAP.
-
Enhancement #970: Add required headers to SMTP client to prevent being tagged as spam
Mails being sent through the client, specially through unauthenticated SMTP were being tagged as spam due to missing headers.
-
Enhancement #996: Split LDAP user filters
The current LDAP user and auth filters only allow a single
%sto be replaced with the relevant string. The currentuserfilteris used to lookup a single user, search for share recipients and for login. To make each use case more flexible we split this in three and introduced templates.For the
userfilterwe moved to filter templates that can use the CS3 user id properties{{.OpaqueId}}and{{.Idp}}: ``` userfilter = "(&(objectclass=posixAccount)(|(ownclouduuid={{.OpaqueId}})(cn={{.OpaqueId}})))"We introduced a new `findfilter` that is used when searching for users. Use it like this: ``` findfilter = "(&(objectclass=posixAccount)(|(cn={{query}}*)(displayname={{query}}*)(mail={{query}}*)))"Furthermore, we also introduced a dedicated login filter for the LDAP auth manager:
loginfilter = "(&(objectclass=posixAccount)(|(cn={{login}})(mail={{login}})))"These filter changes are backward compatible:
findfilterandloginfilterwill be derived from theuserfilterby replacing%swith{{query}}and{{login}}respectively. Theuserfilterreplaces%swith{{.OpaqueId}}Finally, we changed the default attribute for the immutable uid of a user to
ms-DS-ConsistencyGuid. See https://docs.microsoft.com/en-us/azure/active-directory/hybrid/plan-connect-design-concepts for the background. You can fall back toobjectguidor evensamaccountnamebut you will run into trouble when user names change. You have been warned. -
Enhancement #1007: Update go-tus version
The lib now uses go mod which should help golang to sort out dependencies when running
go mod tidy. -
Enhancement #1004: Update github.com/go-ldap/ldap to v3
In the current version of the ldap lib attribute comparisons are case sensitive. With v3
GetEqualFoldAttributeValueis introduced, which allows a case insensitive comparison. Which AFAICT is what the spec says: see go-ldap/ldap#129 (comment) -
Enhancement #974: Add functionality to create webdav references for OCM shares
Webdav references will now be created in users' shares directory with the target set to the original resource's location in their mesh provider.
The following sections list the changes in reva 0.1.0 relevant to reva users. The changes are ordered by importance.
- Enh #402: Build daily releases
- Enh #416: Improve developer experience
- Enh #468: remove vendor support
- Enh #545: simplify configuration
- Enh #561: improve the documentation
- Enh #562: support home storages
-
Enhancement #402: Build daily releases
Reva was not building releases of commits to the master branch. Thanks to @zazola.
Commit-based released are generated every time a PR is merged into master. These releases are available at: https://reva-releases.web.cern.ch
-
Enhancement #416: Improve developer experience
Reva provided the option to be run with a single configuration file by using the -c config flag.
This PR adds the flag -dev-dir than can point to a directory containing multiple config files. The reva daemon will launch a new process per configuration file.
Kudos to @refs.
-
Enhancement #468: remove vendor support
Because @dependabot cannot update in a clean way the vendor dependecies Reva removed support for vendored dependencies inside the project.
Dependencies will continue to be versioned but they will be downloaded when compiling the artefacts.
-
Enhancement #545: simplify configuration
Reva configuration was difficul as many of the configuration parameters were not providing sane defaults. This PR and the related listed below simplify the configuration.
-
Enhancement #561: improve the documentation
Documentation has been improved and can be consulted here: https://reva.link
-
Enhancement #562: support home storages
Reva did not have any functionality to handle home storages. These PRs make that happen.
cs3org#562 cs3org#510 cs3org#493 cs3org#476 cs3org#469 cs3org#436 cs3org#571
The following sections list the changes in reva 0.0.1 relevant to reva users. The changes are ordered by importance.
- Enh #334: Create release procedure for Reva
-
Enhancement #334: Create release procedure for Reva
Reva did not have any procedure to release versions. This PR brings a new tool to release Reva versions (tools/release) and prepares the necessary files for artefact distributed made from Drone into Github pages.