Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-DCConditionalAccessPolicyDesignReport: Guests inclusion and exclusions missing #36

Open
Sl1m1l0ude opened this issue Oct 19, 2023 · 0 comments

Comments

@Sl1m1l0ude
Copy link

Hi,

I noticed that your module is missing the Guests and External accounts inclusions and exclusions from the CA rules. I think that is due to a recent change on MS side as I can see in the if statement that you created an exception for it,

I think you should include something like this in your module:

        # includeGuestUsers
        $GuestUsers = foreach ($GuestUser in $Policy.conditions.users.IncludeGuestsOrExternalUsers) {
            
                $GuestUser
            
        }

        $CustomObject | Add-Member -MemberType NoteProperty -Name "includeGuestUsers" -Value (Out-String -InputObject $GuestUsers)

        # excludeGuestUsers
        $GuestUsers = foreach ($GuestUser in $Policy.conditions.users.ExcludeGuestsOrExternalUsers) {
            
                $GuestUser
            
        }

        $CustomObject | Add-Member -MemberType NoteProperty -Name "excludeGuestUsers" -Value (Out-String -InputObject $GuestUsers)

Thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant