Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-batch disk-type error #301

Open
rivershah opened this issue Dec 29, 2024 · 1 comment
Open

google-batch disk-type error #301

rivershah opened this issue Dec 29, 2024 · 1 comment

Comments

@rivershah
Copy link

Trying to use n4-standard-* machines. These require hyperdisk-balanced. This is being set in command line via:
--disk-type hyperdisk-balanced however job fails with:

Job gets non-retryable information Batch Error: code - CODE_GCE_INVALID_FIELD_VALUE, description - Invalid value for field 'operation': ''. No zone supports all of the provided instance templates. The following errors detail the failure. [pd-standard, n4-standard-2] features are not compatible for creating instance..

@rivershah rivershah changed the title batch ignores disk-type batch provider disk-type error Dec 29, 2024
@rivershah
Copy link
Author

I noticed that if we allow google batch to automatically pick, then the issue goes away. Specifying disk types for newer machines such as n4-standard or a3-highgpu breaks otherwise

diff --git a/dsub/providers/google_batch_operations.py b/dsub/providers/google_batch_operations.py
index 5bba01d..3375edf 100644
--- a/dsub/providers/google_batch_operations.py
+++ b/dsub/providers/google_batch_operations.py
@@ -364,7 +364,7 @@ def build_persistent_disk(
     size_gb: int, disk_type: str
 ) -> batch_v1.types.AllocationPolicy.Disk:
   disk = batch_v1.AllocationPolicy.Disk()
-  disk.type = disk_type
+  # disk.type = disk_type
   disk.size_gb = size_gb
   return disk

@rivershah rivershah changed the title batch provider disk-type error google-batch disk-type error Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant