Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sendable in OTSpan #1440

Open
muukii opened this issue Aug 26, 2023 · 5 comments
Open

Support sendable in OTSpan #1440

muukii opened this issue Aug 26, 2023 · 5 comments
Assignees

Comments

@muukii
Copy link
Contributor

muukii commented Aug 26, 2023

The thing

in some cases, potentially moving between threads(actors)

@ganeshnj
Copy link
Contributor

Thanks for opening the issue @muukii

We have not looked into supporting Swift concurrency features but this is interesting use case. Conforming OTSpan to Sendable will not be trivial because of DDSpan which opens up all other types. Hence, we have to figure out a strategy for conformation.

Let me discuss with the team and will get back to you.

@muukii
Copy link
Contributor Author

muukii commented Aug 30, 2023

Okay, thanks for replying.

In Swift6, swift-concurrency will be enhanced, and errors when it comes to using UNSAFE multi-threading programming.
It boils down to supporting swift-concurrency attributes such as Sendable to prevent errors.
I probably help this project.

@maxep maxep added the feature label Sep 5, 2023
@ganeshnj
Copy link
Contributor

We discussed this internally and created a backlog item for prioritization. The use case mentioned makes sense where we want SDK's public types to be thread safe even if the SDK doesn't use any Swift concurrency features.

Keep an eye on this issue for further updates.

@jaredsinclair
Copy link
Contributor

@ganeshnj Do ya'll have a target date by which you plan to be ready for Swift 6 and strict concurrency?

@ganeshnj
Copy link
Contributor

ganeshnj commented Apr 4, 2024

We have bumped the priority of the backlog item to highest. Unfortunately, we don't have date to share as it would require some significant changes how we handle things.

We will keep the issue updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants