From 767938cea64558544cf641cf4e5668be40af983e Mon Sep 17 00:00:00 2001 From: Mikayla Toffler Date: Tue, 1 Oct 2024 15:44:27 -0400 Subject: [PATCH] Fix defaultErrorCode naming --- contrib/internal/httptrace/config.go | 4 ++-- contrib/net/http/option.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/internal/httptrace/config.go b/contrib/internal/httptrace/config.go index 21c605c2fa..23ee0113d5 100644 --- a/contrib/internal/httptrace/config.go +++ b/contrib/internal/httptrace/config.go @@ -43,7 +43,7 @@ func newConfig() config { queryString: !internal.BoolEnv(envQueryStringDisabled, false), queryStringRegexp: defaultQueryStringRegexp, traceClientIP: internal.BoolEnv(envTraceClientIPEnabled, false), - isStatusError: defaultErrorCodes, + isStatusError: isServerError, } v := os.Getenv(envServerErrorStatuses) if fn := GetErrorCodesFromInput(v); fn != nil { @@ -62,7 +62,7 @@ func newConfig() config { return c } -func defaultErrorCodes(statusCode int) bool { +func isServerError(statusCode int) bool { return statusCode >= 500 && statusCode < 600 } diff --git a/contrib/net/http/option.go b/contrib/net/http/option.go index 398a0a46f6..22e63ee3b0 100644 --- a/contrib/net/http/option.go +++ b/contrib/net/http/option.go @@ -175,7 +175,7 @@ func newRoundTripperConfig() *roundTripperConfig { spanNamer: defaultSpanNamer, ignoreRequest: func(_ *http.Request) bool { return false }, queryString: internal.BoolEnv(envClientQueryStringEnabled, true), - isStatusError: defaultErrorCodes, + isStatusError: isClientError, } v := os.Getenv(envClientErrorStatuses) if fn := httptrace.GetErrorCodesFromInput(v); fn != nil { @@ -283,6 +283,6 @@ func RTWithErrorCheck(fn func(err error) bool) RoundTripperOption { } } -func defaultErrorCodes(statusCode int) bool { +func isClientError(statusCode int) bool { return statusCode >= 400 && statusCode < 500 }