Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valkey-go support #2920

Open
jalaziz opened this issue Oct 9, 2024 · 1 comment
Open

valkey-go support #2920

jalaziz opened this issue Oct 9, 2024 · 1 comment
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval proposal/accepted Accepted proposals proposal more in depth change that requires full team approval

Comments

@jalaziz
Copy link

jalaziz commented Oct 9, 2024

With Valkey gaining popularity and AWS recently announcing support for managed Valkey, it would be great if native support for valkey-go could be added.

There is a hook mechanism that can be used for adding instrumentation. There is also existing otel support that could be used as inspiration.

The valkey-go library is forked off rueidis, so it may be possible to add support for rueidis as well.
@jalaziz jalaziz added the enhancement quick change/addition that does not need full team approval label Oct 9, 2024
@github-actions github-actions bot added the needs-triage New issues that have not yet been triaged label Oct 9, 2024
@rarguelloF rarguelloF added proposal more in depth change that requires full team approval proposal/accepted Accepted proposals apm:ecosystem contrib/* related feature requests or bugs and removed needs-triage New issues that have not yet been triaged labels Oct 15, 2024
@rarguelloF
Copy link
Contributor

rarguelloF commented Oct 15, 2024 •
edited
Loading

Hey @jalaziz, supporting valkey-go sounds like a great addition, so please consider this proposal accepted.

PRs are more than welcome, but if you want us to tackle the work feel free to reach out Datadog Support so we prioritize accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval proposal/accepted Accepted proposals proposal more in depth change that requires full team approval
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jalaziz @rarguelloF