-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture tracing when a specific header is passed in an HTTP request #3660
Comments
We're doing something similar but closer to the controller...
This works on all except one application route (I ended up here because I'm trying to figure out why that one controller doesn't keep its traces!) Hope this helps. |
Mark, that is super helpful, thanks for sharing! |
👋, this is they're likely happening because when dd-trace-rb/lib/datadog/tracing.rb Line 85 in 7de5392
In your original example, you can guarantee that the trace is created before choosing a sampling decision ( def call(env)
if env["HTTP_FORCE_DATADOG_TRACE"]
# Keeps the active trace
Tracing.continue_trace!(nil) do
Datadog::Tracing.keep!
@app.call(env)
end
else
@app.call(env)
end
end This is the cleanest way in my opinion, and it doesn't require you to create a dummy span ( Let me know if this works! |
We currently trace at a low sample rate (1%) in our web app. Sometimes, a trace would be really helpful in tracking down a problem for a specific user. I'd like to be able to add a special HTTP header (for example, "FORCE_DATADOG_TRACE" or something) to an HTTP request, have my rails app notice that, and trace that specific request, so that I can use the trace for debugging purposes. I tried doing this with a Rails middleware, like this:
(in
config/application.rb
)I debugged this locally and I see the
Datadog::Tracing.keep!
line of code is being executed when that header is passed, but I'm not getting those "forced" traces to show up in the DataDog UI. I'm not sure if this is because there is no active trace at the time, or if I'm just going down the wrong path here. Has anyone else tried to accomplish something similar?The text was updated successfully, but these errors were encountered: