Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line for patch #1

Open
bogenschlag opened this issue May 23, 2017 · 1 comment
Open

Line for patch #1

bogenschlag opened this issue May 23, 2017 · 1 comment
Labels

Comments

@bogenschlag
Copy link

bogenschlag commented May 23, 2017

Regarding the necessity to patch the WAC: In ILIAS 5.2 that seems to be exactly line 1460.

But wouldn’t it be better to include a patch file, that simply inserts a whole “block” like

case "xvid":
	$obj_id = $id;
	break;

into the class file, with the plugin?

@gvollbach
Copy link
Contributor

In my opinion not really, as you can see the lines move since this is actively maintained code, the long term goal is to not require the patch anymore. But for this I must remove all remaining uses of the ilObjMediaObject class.

The Interactive Video Plugin already has a registration for the WebAccessChecker in Version 2, so there is only the "little" work of removing the ilObjMediaObject video type from the plugin sources and migrate all old usages to a new plugin video object type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants