Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reports] extract non-d3 vizconfig options #1293

Closed
4 tasks
jhmullen opened this issue Dec 1, 2021 · 1 comment
Closed
4 tasks

[reports] extract non-d3 vizconfig options #1293

jhmullen opened this issue Dec 1, 2021 · 1 comment
Assignees
Milestone

Comments

@jhmullen
Copy link
Collaborator

jhmullen commented Dec 1, 2021

A number of hacky CMS-level configs are overloading the pure d3plus config, including:

  • Tabs
  • Mini vs Large

We also want some new ones, like:

During the next database change, add a configuration column to handle these configurations, and move them OUT of the d3plus configs (but maintain backwards compatibility)

@jhmullen
Copy link
Collaborator Author

A js-only escape hatch has been added to block settings, which properly saves and executes. It still needs to be implemented (Viz needs to act on them) and be given a UI mode (for non-js setting). These are tracked in #1338 and #1339 respectively.

jhmullen added a commit that referenced this issue Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant