From dfbb8d9742e9e5cc2a29ce78153633abefaab429 Mon Sep 17 00:00:00 2001 From: Dave Skender <8432125+DaveSkender@users.noreply.github.com> Date: Sun, 31 Dec 2023 07:35:24 -0500 Subject: [PATCH 01/12] add To Donote only Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com> --- .github/workflows/test-performance.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-performance.yml b/.github/workflows/test-performance.yml index d323c0a1a..75a6046a3 100644 --- a/.github/workflows/test-performance.yml +++ b/.github/workflows/test-performance.yml @@ -11,6 +11,10 @@ jobs: runs-on: ubuntu-latest steps: + + # TODO: update run title and output summary + # with semantic version + - name: Checkout repository uses: actions/checkout@v4 @@ -33,4 +37,4 @@ jobs: - name: Publish summary working-directory: tests/performance/BenchmarkDotNet.Artifacts/results - run: cat Tests.Performance.IndicatorPerformance-report-github.md >$GITHUB_STEP_SUMMARY \ No newline at end of file + run: cat Tests.Performance.IndicatorPerformance-report-github.md >$GITHUB_STEP_SUMMARY From 86437a668f035bf194424c282c0e02d3ccf5b601 Mon Sep 17 00:00:00 2001 From: Dave Skender <8432125+DaveSkender@users.noreply.github.com> Date: Wed, 3 Jan 2024 03:04:23 -0500 Subject: [PATCH 02/12] update release scripts --- .github/workflows/deploy-package.yml | 4 +++- .github/workflows/{deploy-docs.yml => docs-deploy.yml} | 0 2 files changed, 3 insertions(+), 1 deletion(-) rename .github/workflows/{deploy-docs.yml => docs-deploy.yml} (100%) diff --git a/.github/workflows/deploy-package.yml b/.github/workflows/deploy-package.yml index 680ce9d2b..93a3e2d61 100644 --- a/.github/workflows/deploy-package.yml +++ b/.github/workflows/deploy-package.yml @@ -158,7 +158,9 @@ jobs: uses: ncipollo/release-action@v1 if: inputs.environment == 'nuget' with: - body: "We’ve released a new Stock Indicators for .NET NuGet package. See [Skender.Stock.Indicators @ NuGet.org](${{ vars.NUGET_DOWNLOAD_PREFIX }}${{ needs.build.outputs.version }}) for more information." + body: | + "We’ve released a new Stock Indicators for .NET NuGet package. + See [Skender.Stock.Indicators @ NuGet.org](${{ vars.NUGET_DOWNLOAD_PREFIX }}${{ needs.build.outputs.version }}) for more information." generateReleaseNotes: true draft: true makeLatest: ${{ !inputs.preview }} diff --git a/.github/workflows/deploy-docs.yml b/.github/workflows/docs-deploy.yml similarity index 100% rename from .github/workflows/deploy-docs.yml rename to .github/workflows/docs-deploy.yml From 1978a376ebcfb178b8f61061d413bfe453b6113a Mon Sep 17 00:00:00 2001 From: Dave Skender <8432125+DaveSkender@users.noreply.github.com> Date: Wed, 3 Jan 2024 03:05:31 -0500 Subject: [PATCH 03/12] remove quotes --- .github/workflows/deploy-package.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deploy-package.yml b/.github/workflows/deploy-package.yml index 93a3e2d61..c4f78e5b2 100644 --- a/.github/workflows/deploy-package.yml +++ b/.github/workflows/deploy-package.yml @@ -159,8 +159,8 @@ jobs: if: inputs.environment == 'nuget' with: body: | - "We’ve released a new Stock Indicators for .NET NuGet package. - See [Skender.Stock.Indicators @ NuGet.org](${{ vars.NUGET_DOWNLOAD_PREFIX }}${{ needs.build.outputs.version }}) for more information." + We’ve released a new Stock Indicators for .NET NuGet package. + See [Skender.Stock.Indicators @ NuGet.org](${{ vars.NUGET_DOWNLOAD_PREFIX }}${{ needs.build.outputs.version }}) for more information. generateReleaseNotes: true draft: true makeLatest: ${{ !inputs.preview }} From 772d52e8571210e56fc3f7cbc316d162ef5ca573 Mon Sep 17 00:00:00 2001 From: Dave Skender <8432125+DaveSkender@users.noreply.github.com> Date: Thu, 4 Jan 2024 02:40:53 -0500 Subject: [PATCH 04/12] rename actions files --- .github/workflows/{build-codeql.yml => build-scan-codeql.yml} | 0 .../workflows/{build-indicators.yml => built-test-indicators.yml} | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{build-codeql.yml => build-scan-codeql.yml} (100%) rename .github/workflows/{build-indicators.yml => built-test-indicators.yml} (100%) diff --git a/.github/workflows/build-codeql.yml b/.github/workflows/build-scan-codeql.yml similarity index 100% rename from .github/workflows/build-codeql.yml rename to .github/workflows/build-scan-codeql.yml diff --git a/.github/workflows/build-indicators.yml b/.github/workflows/built-test-indicators.yml similarity index 100% rename from .github/workflows/build-indicators.yml rename to .github/workflows/built-test-indicators.yml From e0bbbdd171308d927c4c95c1888f8cc96356912c Mon Sep 17 00:00:00 2001 From: Dave Skender <8432125+DaveSkender@users.noreply.github.com> Date: Thu, 4 Jan 2024 02:54:15 -0500 Subject: [PATCH 05/12] attempt 1: perf benchmark custom name --- .github/workflows/test-performance.yml | 28 ++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-performance.yml b/.github/workflows/test-performance.yml index 75a6046a3..89680439d 100644 --- a/.github/workflows/test-performance.yml +++ b/.github/workflows/test-performance.yml @@ -1,4 +1,5 @@ name: Benchmark performance +run-name: Deploy NuGet package v$COMPOSED_VERSION concurrency: group: test-performance @@ -14,10 +15,33 @@ jobs: # TODO: update run title and output summary # with semantic version - + - name: Checkout repository uses: actions/checkout@v4 + - name: Install GitVersion + uses: gittools/actions/gitversion/setup@v0 + with: + versionSpec: "5.x" + preferLatestVersion: true + + - name: Determine version + id: gitversion + uses: gittools/actions/gitversion/execute@v0 + with: + updateAssemblyInfo: true + useConfigFile: true + configFilePath: gitversion.yml + + - name: Compose version + id: compose + run: | + COMPOSED_VERSION=$GITVERSION_MAJORMINORPATCH${{ inputs.preview && '-preview-' || '' }}${{ inputs.preview && github.run_id || '' }} + echo "version=$COMPOSED_VERSION" >> "$GITHUB_OUTPUT" + echo "COMPOSED_VERSION=$COMPOSED_VERSION" >> "$GITHUB_ENV" + echo "Composed version is:" + echo $COMPOSED_VERSION + - name: Install .NET SDK uses: actions/setup-dotnet@v3 with: @@ -33,7 +57,7 @@ jobs: - name: Benchmark indicators working-directory: tests/performance - run: dotnet run -c Release + run: dotnet run -c Release --filter *.GetEma - name: Publish summary working-directory: tests/performance/BenchmarkDotNet.Artifacts/results From 4def9fbbb93acf0280f10fc09c1dc2d2f024f0f6 Mon Sep 17 00:00:00 2001 From: Dave Skender <8432125+DaveSkender@users.noreply.github.com> Date: Thu, 4 Jan 2024 02:56:35 -0500 Subject: [PATCH 06/12] attempt 2 --- .github/workflows/test-performance.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-performance.yml b/.github/workflows/test-performance.yml index 89680439d..5002a8a9c 100644 --- a/.github/workflows/test-performance.yml +++ b/.github/workflows/test-performance.yml @@ -13,11 +13,10 @@ jobs: steps: - # TODO: update run title and output summary - # with semantic version - - name: Checkout repository uses: actions/checkout@v4 + with: + fetch-depth: 0 - name: Install GitVersion uses: gittools/actions/gitversion/setup@v0 From fa021d126b2ed47d2b4448a46461c696a9aab417 Mon Sep 17 00:00:00 2001 From: Dave Skender <8432125+DaveSkender@users.noreply.github.com> Date: Thu, 4 Jan 2024 03:06:26 -0500 Subject: [PATCH 07/12] attempt 3 --- .github/workflows/test-performance.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-performance.yml b/.github/workflows/test-performance.yml index 5002a8a9c..ae3cd2883 100644 --- a/.github/workflows/test-performance.yml +++ b/.github/workflows/test-performance.yml @@ -1,5 +1,4 @@ name: Benchmark performance -run-name: Deploy NuGet package v$COMPOSED_VERSION concurrency: group: test-performance @@ -60,4 +59,6 @@ jobs: - name: Publish summary working-directory: tests/performance/BenchmarkDotNet.Artifacts/results - run: cat Tests.Performance.IndicatorPerformance-report-github.md >$GITHUB_STEP_SUMMARY + run: | + { echo "Package v$COMPOSED_VERSION" } >> $GITHUB_STEP_SUMMARY + cat Tests.Performance.IndicatorPerformance-report-github.md >> $GITHUB_STEP_SUMMARY From 2d195531b6b148ea17cc0f8354bb7934bd4fb54e Mon Sep 17 00:00:00 2001 From: Dave Skender <8432125+DaveSkender@users.noreply.github.com> Date: Thu, 4 Jan 2024 03:15:22 -0500 Subject: [PATCH 08/12] update gitversion feature label --- gitversion.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gitversion.yml b/gitversion.yml index 4cb24ba14..94e8fae58 100644 --- a/gitversion.yml +++ b/gitversion.yml @@ -9,3 +9,5 @@ no-bump-message: '\+semver:\s?(none|skip)' branches: pull-request: tag: preview. + feature: + tag: preview. From a823354b1b770dbfb726c42fb93b36e06fd348da Mon Sep 17 00:00:00 2001 From: Dave Skender <8432125+DaveSkender@users.noreply.github.com> Date: Thu, 4 Jan 2024 03:20:17 -0500 Subject: [PATCH 09/12] different syntax --- .github/workflows/test-performance.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-performance.yml b/.github/workflows/test-performance.yml index ae3cd2883..2d60b128d 100644 --- a/.github/workflows/test-performance.yml +++ b/.github/workflows/test-performance.yml @@ -59,6 +59,6 @@ jobs: - name: Publish summary working-directory: tests/performance/BenchmarkDotNet.Artifacts/results - run: | + run: > { echo "Package v$COMPOSED_VERSION" } >> $GITHUB_STEP_SUMMARY cat Tests.Performance.IndicatorPerformance-report-github.md >> $GITHUB_STEP_SUMMARY From 330aeac7f2092a071e9d2186a7ffd5c063d2fd8a Mon Sep 17 00:00:00 2001 From: Dave Skender <8432125+DaveSkender@users.noreply.github.com> Date: Thu, 4 Jan 2024 03:27:08 -0500 Subject: [PATCH 10/12] attempt 5 --- .github/workflows/test-performance.yml | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/.github/workflows/test-performance.yml b/.github/workflows/test-performance.yml index 2d60b128d..72b112145 100644 --- a/.github/workflows/test-performance.yml +++ b/.github/workflows/test-performance.yml @@ -31,15 +31,6 @@ jobs: useConfigFile: true configFilePath: gitversion.yml - - name: Compose version - id: compose - run: | - COMPOSED_VERSION=$GITVERSION_MAJORMINORPATCH${{ inputs.preview && '-preview-' || '' }}${{ inputs.preview && github.run_id || '' }} - echo "version=$COMPOSED_VERSION" >> "$GITHUB_OUTPUT" - echo "COMPOSED_VERSION=$COMPOSED_VERSION" >> "$GITHUB_ENV" - echo "Composed version is:" - echo $COMPOSED_VERSION - - name: Install .NET SDK uses: actions/setup-dotnet@v3 with: @@ -55,10 +46,10 @@ jobs: - name: Benchmark indicators working-directory: tests/performance - run: dotnet run -c Release --filter *.GetEma + run: dotnet run -c Release - name: Publish summary working-directory: tests/performance/BenchmarkDotNet.Artifacts/results - run: > - { echo "Package v$COMPOSED_VERSION" } >> $GITHUB_STEP_SUMMARY + run: | + echo "Package v$GITVERSION_FULLSEMVER" >> $GITHUB_STEP_SUMMARY cat Tests.Performance.IndicatorPerformance-report-github.md >> $GITHUB_STEP_SUMMARY From bfa70fda196bd73e68f62f7fe1d562d87591c88b Mon Sep 17 00:00:00 2001 From: Dave Skender <8432125+DaveSkender@users.noreply.github.com> Date: Thu, 4 Jan 2024 03:27:31 -0500 Subject: [PATCH 11/12] add back temp filter --- .github/workflows/test-performance.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-performance.yml b/.github/workflows/test-performance.yml index 72b112145..d6ecb65b5 100644 --- a/.github/workflows/test-performance.yml +++ b/.github/workflows/test-performance.yml @@ -46,7 +46,7 @@ jobs: - name: Benchmark indicators working-directory: tests/performance - run: dotnet run -c Release + run: dotnet run -c Release --filter *.GetEma - name: Publish summary working-directory: tests/performance/BenchmarkDotNet.Artifacts/results From 59bba5b0d99729b4f4b91e866e3c6c7e733d5d85 Mon Sep 17 00:00:00 2001 From: Dave Skender <8432125+DaveSkender@users.noreply.github.com> Date: Thu, 4 Jan 2024 03:33:18 -0500 Subject: [PATCH 12/12] final --- .github/workflows/test-performance.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-performance.yml b/.github/workflows/test-performance.yml index d6ecb65b5..da798f9cf 100644 --- a/.github/workflows/test-performance.yml +++ b/.github/workflows/test-performance.yml @@ -46,10 +46,10 @@ jobs: - name: Benchmark indicators working-directory: tests/performance - run: dotnet run -c Release --filter *.GetEma + run: dotnet run -c Release - name: Publish summary working-directory: tests/performance/BenchmarkDotNet.Artifacts/results run: | - echo "Package v$GITVERSION_FULLSEMVER" >> $GITHUB_STEP_SUMMARY + echo "### Package version $GITVERSION_FULLSEMVER" >> $GITHUB_STEP_SUMMARY cat Tests.Performance.IndicatorPerformance-report-github.md >> $GITHUB_STEP_SUMMARY