Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use yes/no for slave-read-only #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use yes/no for slave-read-only #238

wants to merge 1 commit into from

Conversation

schferbe
Copy link

I used this role to install a redis 5.0.8 master/slave setup. On the slave I got the following error in journalctl -u redis_6379:

Mär 25 13:59:02 *** redis-server[11357]: *** FATAL CONFIG FILE ERROR ***
Mär 25 13:59:02 *** redis-server[11357]: Reading the configuration file, at line 32
Mär 25 13:59:02 *** redis-server[11357]: >>> 'slave-read-only False'
Mär 25 13:59:02 *** redis-server[11357]: argument must be 'yes' or 'no'

This PR fixes the error.

@DavidWittman
Copy link
Owner

DavidWittman commented Apr 16, 2020 •
edited
Loading

Currently, these should be set to "yes" or "no" (with quotes) to avoid being interpreted by YAML as booleans and ending up as True/False in the config. While I think your proposed method is probably superior, it's likely to cause a breaking change for anyone currently using redis_slave_read_only: "no", which I think would evaluate to True.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schferbe @DavidWittman