Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension is completely broken! Error message: payload.data is not iterable when importing or exporting #15

Closed
jmoransi opened this issue Jun 18, 2024 · 6 comments
Closed

Extension is completely broken! Error message: payload.data is not iterable when importing or exporting #15

jmoransi opened this issue Jun 18, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@jmoransi
Copy link

Actual behaviour

When importing deck from Dueling book either using YDKE code or YDK file, an error message appears with the following message

payload.data is not iterable

image

Expected behaviour

  1. Import YDK file
  2. Deck should appear in official yugioh db

Browser, and version if you know

Microsoft Edge Version 126.0.2592.56 (Official build) (64-bit)

Operating system and version

Windows 11
@jmoransi jmoransi added the bug Something isn't working label Jun 18, 2024
@jmoransi
Copy link
Author

Same YDK file can be imported into YGOProdeck website

image

attaching YDK file
LabJack3.zip

@kevinlul
Copy link
Contributor

Thanks for reporting a bug! I have reproduced this issue and continue to investigate.
image

@kevinlul
Copy link
Contributor

This problem is caused by a change in behaviour in the YGOPRODECK API.
image

This breaks all functionality of this extension, import and export, and is not specific to the provided deck.

kevinlul added a commit that referenced this issue Jun 19, 2024
@kevinlul
Fix API rejecting all requests due to unrecognized query string param…
049d95e 
…eter

This recent behaviour change in the YGOPRODECK API breaks all extension functionality. Fixes #15
@kevinlul kevinlul mentioned this issue Jun 19, 2024
Closed
@kevinlul
Copy link
Contributor

I have reported this issue to the site owner, pending a response tomorrow. In the event that this change is behaviour is intended and permanent, I have also prepared a fix in the extension.

@kevinlul kevinlul changed the title payload.data is not iterable error mesage when importing ydk file or ydke code from dueling book Extension is completely broken! Error message: payload.data is not iterable when importing or exporting Jun 19, 2024
@kevinlul kevinlul pinned this issue Jun 19, 2024
@kevinlul kevinlul unpinned this issue Jun 19, 2024
@kevinlul
Copy link
Contributor

This should be resolved now.

@kevinlul
Copy link
Contributor

Fix reconfirmed. Thanks again for reporting this. I'm currently working on automated tests in #10 that would catch this kind of error sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@jmoransi @kevinlul