Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning installation #475

Closed
3 tasks done
gcroci2 opened this issue Sep 1, 2023 · 1 comment · Fixed by #491
Closed
3 tasks done

Cleaning installation #475

gcroci2 opened this issue Sep 1, 2023 · 1 comment · Fixed by #491
Assignees
@gcroci2

Comments

@gcroci2
Copy link
Collaborator

gcroci2 commented Sep 1, 2023 •
edited
Loading

I think it's time to clean the installation, which is very messy and causes issues very often.

  • remove redundancies, keep only toml file

  • On the CI, test build for python 3.10 and 3.11

  • add badges for python version and OSs supported

  • add CI for macOS as well

    • For now not implemented, see the PR for more details.
@gcroci2 gcroci2 self-assigned this Sep 1, 2023
@gcroci2 gcroci2 added the priority Solve this first label Sep 1, 2023
@DaniBodor
Copy link
Collaborator

Considerations:

  • poetry installation instead of pip/sh script
  • conda/mamba installation instead of pip/sh script
  • remove 3.9 support and only go for 3.10/3.11

@DaniBodor DaniBodor mentioned this issue Sep 4, 2023
Closed
@gcroci2 gcroci2 linked a pull request Sep 6, 2023 that will close this issue
build: improve installation making use of pyproject.toml file only and setuptools #491
Merged
@gcroci2 gcroci2 removed the priority Solve this first label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcroci2 gcroci2

Labels
None yet
Projects
Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: improve installation making use of pyproject.toml file only and setuptools DeepRank/deeprank2
2 participants
@DaniBodor @gcroci2