Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ruff settings to separate toml file #641

Closed
DaniBodor opened this issue Sep 6, 2024 · 0 comments · Fixed by #642
Closed

Move ruff settings to separate toml file #641

DaniBodor opened this issue Sep 6, 2024 · 0 comments · Fixed by #642
Assignees
@DaniBodor
Labels
CI continuous integration

Comments

@DaniBodor
Copy link
Collaborator

DaniBodor commented Sep 6, 2024 •
edited
Loading

Currently, these settings take p ~1/3 of the pyproject.toml file. I think it would be nice to keep these separate tom have things a bit more
orderly and transparent.

I would like to hold off on this until #636 is reviewed and finished, as that PR makes changes to the ruff settings.

blocked by #636
This was referenced Sep 6, 2024
Merged
Merged
@DaniBodor DaniBodor self-assigned this Sep 6, 2024
@DaniBodor DaniBodor linked a pull request Sep 6, 2024 that will close this issue
ci: move ruff settings to separate toml file #642
Merged
@DaniBodor DaniBodor added the CI continuous integration label Sep 6, 2024
@gcroci2 gcroci2 removed the blocked label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaniBodor DaniBodor

Labels
CI continuous integration
Projects
Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: move ruff settings to separate toml file DeepRank/deeprank2
2 participants
@DaniBodor @gcroci2