Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should be matched by "sub" claim when logging in with external OIDC provider. #741

Open
j-chmielewski opened this issue Aug 22, 2024 · 0 comments
Labels
bug Something isn't working enterprise

Comments

@j-chmielewski
Copy link
Contributor

j-chmielewski commented Aug 22, 2024

Currently when the user is logging in using external oidc provider, he's matched against defguard database by email from oidc token email claim. There are 2 issues with this:

  1. The email may change in defguard or external provider
  2. There is no guarantee that the email is unique in the provider system

To fix this, the user should be matched against the sub claim which is guaranteed to be unique across the system.

@j-chmielewski j-chmielewski added bug Something isn't working enterprise labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enterprise
Projects
Status: Refined & Ready
Development

No branches or pull requests

1 participant