Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the process for adding language, components, groups, and templates to the design system #2

Open
AlexJupiter opened this issue May 19, 2018 · 2 comments
Assignees
Labels
3 A complexity rating high priority

Comments

@AlexJupiter
Copy link
Member

No description provided.

@AlexJupiter AlexJupiter changed the title Define the process for adding components to the design system Define the process for adding components to the design system: 2 May 19, 2018
@AlexJupiter AlexJupiter added this to the Design System v1 milestone May 19, 2018
@AlexJupiter AlexJupiter added the 3 A complexity rating label May 29, 2018
@AlexJupiter AlexJupiter changed the title Define the process for adding components to the design system: 2 Define the process for adding language, components, groups, and templates to the design system May 29, 2018
@marikio marikio self-assigned this May 31, 2018
@marikio
Copy link
Collaborator

marikio commented Jun 5, 2018

Hey @AlexJupiter @agazima, could you both see if anything needs to be added to the process? I added some of the things we talked about during our last meeting. Thanks!

@AlexJupiter
Copy link
Member Author

@marikio I'm going to add any edits to what you put in Figma, in italics below. They're just suggestions :).

  1. Check the link at: https://github.com/DemocracyEarth/DesignSystem/projects/1
    for any open cards before you begin working. (not an edit, however just note that this link might change as we close one project board/milestone and then move onto another project board/milestone, which is the process we have in the dapp repo)

  2. If there is a card for the task you want to complete, drag it to the “In Progress” column and assign yourself to the card. If there is no card, create it making sure to include a clear header and a description if necessary. If the task is large please provide milestones sub-tasks as a checkbox list within the card. (All newly created cards should be reviewed by a Design Systems Core Team Member Manager before beginning work).

  3. After your card has been approved, you may proceed to work on that specific task. Conduct all work in the “Draft Version” of the design system, which is the bottom row of assets on this page.



4. After your first attempt at a card (or a major milestone) has been fully completed, ping a Design Systems Core Team Member to get it approved. This is done by finding the appropriate card on github and writing a comment tagging the appropriate manager team member. Continue revising and checking in with a manager team member until your card is fully approved.

  1. After a card is approved, add all the components into the Figma component library.

  2. Then drag all assets over to the final version and make sure that any components in your additions uses the base components so that the entire system is connected and editable from one central point.

  3. Move the card over to the “Done” column in Github and close that issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 A complexity rating high priority
Projects
None yet
Development

No branches or pull requests

2 participants