Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metamask] call contract vote() function #53

Closed
2 tasks done
virgile-dev opened this issue Apr 22, 2018 · 7 comments
Closed
2 tasks done

[Metamask] call contract vote() function #53

virgile-dev opened this issue Apr 22, 2018 · 7 comments
Assignees

Comments

@virgile-dev
Copy link
Member

virgile-dev commented Apr 22, 2018

When user selects chooses an option ( yes or no) and then clicks on the vote button it triggers a metamask transaction. Vote function parameters are vote(aremsg.sender, ballotId, voteOption)

  • implement API call with web3.js and construct transaction.
  • The UI should show the state of the transaction.
@virgile-dev virgile-dev changed the title call contract vote() function call contract vote() function [Metamask] Apr 22, 2018
@virgile-dev virgile-dev changed the title call contract vote() function [Metamask] call contract vote() function Apr 22, 2018
@virgile-dev virgile-dev changed the title call contract vote() function call contract vote() function [Metamask] Apr 22, 2018
@virgile-dev virgile-dev changed the title call contract vote() function [Metamask] [Metamask] call contract vote() function Apr 22, 2018
@virgile-dev
Copy link
Member Author

virgile-dev commented Apr 22, 2018

Transaction status:
capture d ecran 2018-04-22 a 14 11 51

@virgile-dev virgile-dev modified the milestones: Contracts v0.1.1, Dapp v0.2 Apr 22, 2018
@aecc
Copy link
Collaborator

aecc commented May 10, 2018

This was actually already implemented in #54. The UI still doesn't show the transaction progress. I'm not sure how to make that work @AlexJupiter @LucasIsasmendi

@aecc
Copy link
Collaborator

aecc commented May 14, 2018

@AlexJupiter @LucasIsasmendi should we leave the "transaction in progress" to be implemented in this issue?

@AlexJupiter
Copy link
Member

@aecc, I believe so yes. It isn't recorded in any other ticket.

@aecc
Copy link
Collaborator

aecc commented May 15, 2018

ok, I leave this to you guys because I have no idea how to do it. The ideal scenario would be that the modal is not blocking, and that after clicking "submit", the progress is in the background (meanwhile you can browse) and some kind of notification is obtained when the transaction is done (remember we are talking about minutes in the main net)
I wonder, is this how we envisioned it in the UX design initially? is this part of the scope of dapp 0.2 ?
Or should we do a "blocking" modal for this iteration?
I lean more towards the last option.

@AlexJupiter AlexJupiter removed this from the Dapp v0.2 milestone May 19, 2018
@AlexJupiter
Copy link
Member

Closing this issue, to celebrate that this task has been done, and then going to open a new issue just related to the transaction statuses.

@AlexJupiter
Copy link
Member

Related issue: DemocracyEarth/wallet#90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants