Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local translate to tamil #333

Closed
pravee42 opened this issue Oct 14, 2022 · 11 comments · Fixed by #334 or #338
Closed

Local translate to tamil #333

pravee42 opened this issue Oct 14, 2022 · 11 comments · Fixed by #334 or #338
Assignees
Labels
enhancement New feature or request

Comments

@pravee42
Copy link
Contributor

image

  1. I would like to contribute to translating the language to Tamil for users from Tamil Nadu
@pravee42 pravee42 added the enhancement New feature or request label Oct 14, 2022
@pravee42 pravee42 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2022
@pravee42 pravee42 reopened this Oct 14, 2022
@DenverCoder1
Copy link
Owner

It would be great to have you contribute. Feel free to take a look at #236 for additional details on contributing translations.

@pravee42 pravee42 mentioned this issue Oct 14, 2022
6 tasks
@DenverCoder1 DenverCoder1 linked a pull request Oct 15, 2022 that will close this issue
6 tasks
@pravee42
Copy link
Contributor Author

I have made the PR as per the issue you have mentioned but there is error in checks

@DenverCoder1
Copy link
Owner

I have made the PR as per the issue you have mentioned but there is error in checks

The error in checks is because of the extra spaces at the beginning of the line, and also that it was placed out of alphabetical order, at the end, rather than between ru and tr.

If you'd like to try fixing that, you may, although it's something that I can resolve quickly before merging if you prefer.

@pravee42
Copy link
Contributor Author

image

The responsiveness somewhat looks messy.

@DenverCoder1
Copy link
Owner

It seems like the font it is using for you is different than how it displays for me

@pravee42
Copy link
Contributor Author

It seems like the font it is using for you is different than how it displays for me

yes

@DenverCoder1
Copy link
Owner

I suppose it could be fixed by adding a newline ("\n") in the total contributions and removing the middle word from longest streak.

Something like this maybe.

    "ta" => [
        "Total Contributions" => "மொத்த\nபங்களிப்புகள்",
        "Current Streak" => "மிக சமீபத்திய பங்களிப்புகள்",
        "Longest Streak" => "நீண்ட பங்களிப்புகள்",
        "Present" => "இன்றுவரை",
    ],

image

Either works for me, but if you'd like, we can change it to make it look better on your computer.

If you'd like to open another pull request, feel free.

@pravee42
Copy link
Contributor Author

If there is any option to change the font here

@pravee42
Copy link
Contributor Author

image

I have edit the font size option here

@DenverCoder1
Copy link
Owner

Changing the font wouldn't be so simple, currently it uses the same font stack as GitHub. Maybe installing Segoe UI or Ubuntu could help, but I'm not sure.

Making the font size configurable might help. I wouldn't want to change it for every language since it already looks fine for most. Maybe an option for each language would be ok, similar to how we have "rtl" => true for right to left, there could be something like "size" => "14px" or similar. I'd rather the text just fit with the same font and size for everything if possible though.

@pravee42
Copy link
Contributor Author

i have opened the pull request as per your idea please check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants