Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Between Project Versions Gives HTTP 404 for all but Overview Tab #641

Closed
2 tasks done
msymons opened this issue Nov 5, 2023 · 3 comments · Fixed by #659
Closed
2 tasks done

Switch Between Project Versions Gives HTTP 404 for all but Overview Tab #641

msymons opened this issue Nov 5, 2023 · 3 comments · Fixed by #659
Labels
defect Something isn't working
Milestone

Comments

@msymons
Copy link
Member

msymons commented Nov 5, 2023

Current Behavior

Switching between project versions gives an HTTP 404 unless the current tab being viewed is "Overview".

Steps to Reproduce

  1. Navigate to project that has more than one version.
  2. On Overview tab, use version dropdown to switch to another version. Success.
  3. Click on any other tab. eg Components.
  4. Use version dropdown to switch to another version of project. HTTP 404.

image

Problem is that (using Components tab as example) switch should be from:

https://dependency-track.foo.bar.com/projects/xxx/components

to:

https://dependency-track.foo.bar.com/projects/yyy/components

...but is actually to:

https://dependency-track.foo.bar.com/projects/xxx/yyy

Tested on DT v4.9.1 and also on v4.10.0-SNAPSHOT

Expected Behavior

There should be no HTTP 404 errors when switching from one version of a project to another, no matter what tab is being viewed.

When switching, the tab should remain unchanged.

Dependency-Track Frontend Version

4.10.0-SNAPSHOT

Browser

Mozilla Firefox

Browser Version

119.0

Operating System

Windows

Checklist

@msymons msymons added defect Something isn't working in triage and removed in triage labels Nov 5, 2023
@rkg-mm
Copy link
Contributor

rkg-mm commented Dec 2, 2023

I actually just found this and fixed this in another PR #658

@nscuro
Copy link
Member

nscuro commented Dec 2, 2023

@rkg-mm Awesome! The whole of #658 will not make it into 4.10 anymore, but a fix for this bug we can still include. Would you be willing to split it into a separate, smaller PR?

rkg-mm added a commit to rkg-mm/dependency-track-frontend that referenced this issue Dec 2, 2023
@rkg-mm
Copy link
Contributor

rkg-mm commented Dec 2, 2023

@nscuro done

@nscuro nscuro added this to the 4.10 milestone Dec 3, 2023
nscuro added a commit that referenced this issue Dec 3, 2023
…ns-Gives-HTTP-404-for-all-but-Overview-Tab

Fix routing bug on version dropdown when not on Overview tab #641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants