Issues with display of wishlisted rolls in Armory tab

[Prometheus3375]

DIM Version

Version 8.51.0 (release), built on 16.12.2024, 05:39:31

Browser Details

Chrome 131.0.0.0

OS Details

Windows 10

Describe the bug

I generate my wishlist with Python code. Here is a snippet for Bitter/Sweet wish rolls:

class BitterSweet(RD):
    """
    Arc Power Grenade Launcher, Adaptive Frame
    https://www.light.gg/db/items/2599338625
    """
    item = Item(name='Bitter/Sweet', hash=2599338625)
    rolls = [
        Roll(
            'Damage dealing',
            [barrels.HardLaunch, AnyPerk],
            [magazines.SpikeGrenades, AnyPerk],
            [traits.EnviousArsenal],
            [traits.BaitAndSwitch],
            ),
        Roll(
            'High DPS',
            [barrels.QuickLaunch, AnyPerk],
            [magazines.SpikeGrenades, AnyPerk],
            [traits.EnviousArsenal],
            [traits.ExplosiveLight],
            ),
        ]

You may wonder what is AnyPerk. This is a special wildcard which means no selection for the column. The snippet above generates the next wishlist:

// Bitter/Sweet
//notes:Damage dealing
dimwishlist:item=2599338625&perks=981914802,3301904089,3987942396,3078487919
dimwishlist:item=2599338625&perks=981914802,3987942396,3078487919
dimwishlist:item=2599338625&perks=3301904089,3987942396,3078487919
dimwishlist:item=2599338625&perks=3987942396,3078487919

//notes:High DPS
dimwishlist:item=2599338625&perks=3525010810,3301904089,3987942396,3194351027
dimwishlist:item=2599338625&perks=3525010810,3987942396,3194351027
dimwishlist:item=2599338625&perks=3301904089,3987942396,3194351027
dimwishlist:item=2599338625&perks=3987942396,3194351027

Let's focus on Damage dealing as the second combo set has the same idea behind. Wish rolls for Damage dealing are defined in the following order:

1. Hard Launch, Spike Grenades, Envious Arsenal, Bait and Switch.
2. Hard Launch, Envious Arsenal, Bait and Switch.
3. Spike Grenades, Envious Arsenal, Bait and Switch.
4. Envious Arsenal, Bait and Switch.

Such order is by design. For any weapon/armor DIM seeks its present rolls in a wish list from the top to the bottom and stops once it finds. Thus, if Bitter/Sweet has all 4 perks, DIM stops at roll 1 and highlights them all. If only one of barrel and mag is present, then it stops on rolls 2 or 3. If no desired barrel and mag are present at all, DIM stops at roll 4.

Basically, rolls 1-3 are listed to highlight with 👍🏻 preferred barrels and mags if they are present on a weapon. DIM does it naturally without issues.

But technically, there are 8 wish rolls. I expect Armory tab to list all of them, but it lists only full rolls:

---

Another issue is with origin traits. They are added to the wish list with the same idea - to highlight with 👍🏻 preferred ones.

For example, Scintillation:

Origin trait is listed after batteries, not after other traits.

Similar with Rose, which have random grips instead of an origin trait:

Logs

No response

[bhollis]

Yet another issue with the Armory's wish list summarization that will go away when and if we adopt the new wish list format - your Python script can more or less also go away then.