Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 'Reset All' should reset all the values in the form fields #103

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix: 'Reset All' should reset all the values in the form fields #103

merged 1 commit into from
Dec 15, 2023

Conversation

arnavbhate
Copy link
Contributor

@arnavbhate arnavbhate commented Dec 13, 2023

Now clicking the 'Reset All' button will reload the CourseFinderFilterForm component after deleting the query string. This will reset the form to its default initial values.

React will re-render a component whenever a parameter changes, so the key parameter is changed to reload the component.

Fixes #40

Now clicking the 'Reset All' button will reload the CourseFinderFilterForm
component after deleting the query string. This will reset the form to
its default initial values.

React will re-render a component whenever a parameter changes, so the
key parameter is changed to reload the component.
@arnavbhate arnavbhate changed the title Fix: 'Reset All' should reset all the values in the form fields (#40) Fix: 'Reset All' should reset all the values in the form fields (Issue #40) Dec 13, 2023
@arnavbhate arnavbhate changed the title Fix: 'Reset All' should reset all the values in the form fields (Issue #40) Fix: 'Reset All' should reset all the values in the form fields Dec 13, 2023
@vk0812
Copy link
Collaborator

vk0812 commented Dec 14, 2023

Great Work, I reviewed the code, just make the PR to the DOPE branch and not the master branch and then I will merge

@arnavbhate arnavbhate changed the base branch from master to DOPE December 14, 2023 19:41
@arnavbhate
Copy link
Contributor Author

Great Work, I reviewed the code, just make the PR to the DOPE branch and not the master branch and then I will merge

Done

@vk0812 vk0812 merged commit 0876bba into DevCom-IITB:DOPE Dec 15, 2023
@arnavbhate arnavbhate deleted the issue-40 branch December 15, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CourseFinder Filter 'Reset All' does not work
2 participants