From 6553990a14637666516f2e7185baeecb60a66322 Mon Sep 17 00:00:00 2001 From: Alyar <> Date: Thu, 16 Jan 2025 16:12:25 +0200 Subject: [PATCH] Fix remarks --- .../grid_core/header_panel/m_header_panel.ts | 2 +- .../__snapshots__/widget.test.ts.snap | 1 + .../new/grid_core/inferno_wrappers/toolbar.ts | 5 +- ...view.test.ts.snap => options.test.ts.snap} | 134 ++----------- .../grids/new/grid_core/toolbar/controller.ts | 15 +- .../grids/new/grid_core/toolbar/defaults.tsx | 4 - .../new/grid_core/toolbar/options.test.ts | 152 +++++++++++++++ .../grids/new/grid_core/toolbar/types.ts | 3 +- .../grids/new/grid_core/toolbar/utils.test.ts | 72 ++++++- .../grids/new/grid_core/toolbar/utils.ts | 57 +++++- .../grids/new/grid_core/toolbar/view.test.ts | 177 ------------------ .../grids/new/grid_core/utils.test.ts | 68 ------- .../__internal/grids/new/grid_core/utils.ts | 52 ----- 13 files changed, 311 insertions(+), 431 deletions(-) rename packages/devextreme/js/__internal/grids/new/grid_core/toolbar/__snapshots__/{view.test.ts.snap => options.test.ts.snap} (55%) create mode 100644 packages/devextreme/js/__internal/grids/new/grid_core/toolbar/options.test.ts delete mode 100644 packages/devextreme/js/__internal/grids/new/grid_core/toolbar/view.test.ts delete mode 100644 packages/devextreme/js/__internal/grids/new/grid_core/utils.test.ts delete mode 100644 packages/devextreme/js/__internal/grids/new/grid_core/utils.ts diff --git a/packages/devextreme/js/__internal/grids/grid_core/header_panel/m_header_panel.ts b/packages/devextreme/js/__internal/grids/grid_core/header_panel/m_header_panel.ts index 7abde5743191..57b5dd0307ec 100644 --- a/packages/devextreme/js/__internal/grids/grid_core/header_panel/m_header_panel.ts +++ b/packages/devextreme/js/__internal/grids/grid_core/header_panel/m_header_panel.ts @@ -7,7 +7,7 @@ import type { Properties as ToolbarProperties } from '@js/ui/toolbar'; import Toolbar from '@js/ui/toolbar'; import type { EditingController } from '@ts/grids/grid_core/editing/m_editing'; import type { HeaderFilterController } from '@ts/grids/grid_core/header_filter/m_header_filter'; -import { normalizeToolbarItems } from '@ts/grids/new/grid_core/utils'; +import { normalizeToolbarItems } from '@ts/grids/new/grid_core/toolbar/utils'; import type { ModuleType } from '../m_types'; import { ColumnsView } from '../views/m_columns_view'; diff --git a/packages/devextreme/js/__internal/grids/new/card_view/__snapshots__/widget.test.ts.snap b/packages/devextreme/js/__internal/grids/new/card_view/__snapshots__/widget.test.ts.snap index b8a3b92dc104..d64f709fa54e 100644 --- a/packages/devextreme/js/__internal/grids/new/card_view/__snapshots__/widget.test.ts.snap +++ b/packages/devextreme/js/__internal/grids/new/card_view/__snapshots__/widget.test.ts.snap @@ -4,6 +4,7 @@ exports[`common initial render should be successfull 1`] = `
+ This is cardView
`; diff --git a/packages/devextreme/js/__internal/grids/new/grid_core/inferno_wrappers/toolbar.ts b/packages/devextreme/js/__internal/grids/new/grid_core/inferno_wrappers/toolbar.ts index c672e67e1a19..c9e2d216081e 100644 --- a/packages/devextreme/js/__internal/grids/new/grid_core/inferno_wrappers/toolbar.ts +++ b/packages/devextreme/js/__internal/grids/new/grid_core/inferno_wrappers/toolbar.ts @@ -29,8 +29,9 @@ export class Toolbar extends InfernoWrapper { }); } }); - const propsToUpdate = { ...props }; - delete propsToUpdate.items; + + const { items, ...propsToUpdate } = props; + super.updateComponentOptions(prevProps, propsToUpdate); } else { super.updateComponentOptions(prevProps, props); diff --git a/packages/devextreme/js/__internal/grids/new/grid_core/toolbar/__snapshots__/view.test.ts.snap b/packages/devextreme/js/__internal/grids/new/grid_core/toolbar/__snapshots__/options.test.ts.snap similarity index 55% rename from packages/devextreme/js/__internal/grids/new/grid_core/toolbar/__snapshots__/view.test.ts.snap rename to packages/devextreme/js/__internal/grids/new/grid_core/toolbar/__snapshots__/options.test.ts.snap index 939da92a941e..5fa658a56425 100644 --- a/packages/devextreme/js/__internal/grids/new/grid_core/toolbar/__snapshots__/view.test.ts.snap +++ b/packages/devextreme/js/__internal/grids/new/grid_core/toolbar/__snapshots__/options.test.ts.snap @@ -1,38 +1,6 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`Applying options when changing a visible to 'false' at runtime Toolbar should be hidden 1`] = ` -
- -
-`; - -exports[`Applying options when changing a visible to 'true' at runtime Toolbar should be visible 1`] = ` -
-