Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension assembly isolation #1430

Closed
veler opened this issue Oct 27, 2024 · 1 comment · Fixed by #1431
Closed

Extension assembly isolation #1430

veler opened this issue Oct 27, 2024 · 1 comment · Fixed by #1431
Assignees
Labels
app-kind:GUI bug Something isn't working

Comments

@veler
Copy link
Collaborator

veler commented Oct 27, 2024

Current behavior

DevToys relies on some dependencies, such as NuGet.Versioning, version 6.9.

If I create a DevToys extension that relies on a different version of NuGet.Versioning, such as 5.0 or 6.11, it is ignored, and instead, the version 6.9 is used.

This causes a major problem when an extension tries to invoke a feature from 6.11 that does not exist in 6.9.

See discussion here: #1333 (comment)

How to reproduce it (as minimally and precisely as possible)

Create a DevToys extension that uses Nuget.Versioning version 6.11.

Expected behavior

it should uses the NuGet version I used in my extension

Screenshots

image

image

Workaround

Use the same version than DevToys.

Affected platforms

No response

Affected DevToys kind

DevToys (app with GUI)

DevToys Version

2.0.5.0

Relevant Assets/Logs

No response

@jerone
Copy link
Contributor

jerone commented Nov 14, 2024

Sadly the fix was reverted in #1449 as it was not compatible for all platforms.

Can we reopen this issue and is there a potential different fix?

Is this even an issue for Mac?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-kind:GUI bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants