Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid_track_number_vinyl - Why Disable Automatic Upload? #18

Open
SellingEngland opened this issue Jan 29, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@SellingEngland
Copy link

When a vinyl with invalid track numbers is detected, why do you then set cmd.automatic_upload to false?

Looking at your main.rs, it will always run the prompt to fix the tags if invalid_track_number_vinyl is true, and the uploading portion of the code is below that.

Therefore, the user will get the prompt to fix the tags, and can answer either yes or no that the tags are fixed. If they answer yes, then I think automatic upload should proceed as normal. Unless I'm missing something.

@DevYukine DevYukine added the bug Something isn't working label Feb 6, 2024
@DevYukine
Copy link
Owner

This was done to ensure the user takes care of this issue themself as thats not something you can easily automate.

It actually doesn't asks the user to "fix the tags" but instead just goes to hash validation for torrents and then to spectogram analysis, this is why i originally disabled auto upload forcefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants