Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create icon from memory #20

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: Create icon from memory #20

wants to merge 7 commits into from

Conversation

sadespresso
Copy link

@sadespresso sadespresso commented Jul 18, 2023 •
edited
Loading

Status

READY

Breaking Changes

NO

Description

  • Adds memoryAsset option for enum ShortcutIconAsset
  • Adds new helper class ShortcutMemoryIcon that converts Uint8List to base64 string
  • Adds Java helper method setIconFromBase64StringCompat for creating icon from base64 formatted jpegs
  • Extend Java code to work with the change above
  • Bumped version to 1.4.0
  • Updated README.md, CHANGELOG.md

This PR closes #18 upon merge

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@sadespresso sadespresso requested a review from divshekhar as a code owner July 18, 2023 17:29
divshekhar
divshekhar reviewed Jul 20, 2023
View reviewed changes
README.md Show resolved Hide resolved
@sadespresso sadespresso requested a review from divshekhar August 19, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divshekhar divshekhar Awaiting requested review from divshekhar divshekhar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can i use Uint8List to create shortcut icon ?
2 participants
@sadespresso @divshekhar