Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary wrap on BatchNorm? #7

Open
johnnychen94 opened this issue Jul 18, 2020 · 0 comments
Open

unnecessary wrap on BatchNorm? #7

johnnychen94 opened this issue Jul 18, 2020 · 0 comments

Comments

@johnnychen94
Copy link
Contributor

johnnychen94 commented Jul 18, 2020

BatchNormWrap seems not necessary given that Conv requires 4D data as input:

UNet.jl/src/model.jl

Lines 1 to 5 in a5ac874

function BatchNormWrap(out_ch)
Chain(x->expand_dims(x,2),
BatchNorm(out_ch),
x->squeeze(x))
end

I guess I must misunderstand the idea here, can you explain it a bit why we need to unsqueeze the 4D input to 6D before feeding into BN? I didn't see this operation in other UNet implementations, for example, in pytorch-unet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant