Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conversion from string to DetectorSizeConstants in DetectorParams #717

Open
DominicOram opened this issue Jul 29, 2024 · 0 comments

Comments

@DominicOram
Copy link
Contributor

We used to need to be able to accept a string as DetectorSizeConstants as it was a parameter from GDA but this is now used as a constant in Hyperion so we can remove the need to derive it from a string.

Acceptance Criteria

  • Remove ability to specify DetectorSizeConstants as a string
  • DetectorParams still converts to json and back ok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant