You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Attempts to integrate I13-1 were hampered by its PVs having BL13J-... prefixes. Ideally we should be able to configure dodal so device_instantiation can pick this up from I13-1.
Since I04-1 and I20-1 are already in dodal and their PVs resolve to BL04I-... and BL20I-..., I assume those are the actual prefixes for those beamlines. I will check when able.
Acceptance Criteria
We can put some configuration in the i13_1 dodal module such that device_instantiation automatically inserts BL13J prefixes at the front of PV names
We can remove the bl_prefix=False argument currently present for all devices
There are regression tests to ensure we do not break existing beamlines
The text was updated successfully, but these errors were encountered:
Hmm... i20-1 and i04-1 are currently also broken because of this. It did work at one point and it's why BeamlinePrefix allows you to specify a suffix but clearly there was a regression. Running dodal connect i20-1 confirms that it's broken but annoyingly dodal connect i04-1 looks like it works because the hardware in dodal so far is the same for i04 and i04-1
Attempts to integrate I13-1 were hampered by its PVs having
BL13J-...
prefixes. Ideally we should be able to configure dodal sodevice_instantiation
can pick this up from I13-1.Since I04-1 and I20-1 are already in dodal and their PVs resolve to
BL04I-...
andBL20I-...
, I assume those are the actual prefixes for those beamlines. I will check when able.Acceptance Criteria
i13_1
dodal module such thatdevice_instantiation
automatically insertsBL13J
prefixes at the front of PV namesbl_prefix=False
argument currently present for all devicesThe text was updated successfully, but these errors were encountered: