Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support J and K beamline prefixes #760

Open
callumforrester opened this issue Aug 22, 2024 · 1 comment
Open

Support J and K beamline prefixes #760

callumforrester opened this issue Aug 22, 2024 · 1 comment
Labels
enhancement New feature or request i13-1

Comments

@callumforrester
Copy link
Contributor

Attempts to integrate I13-1 were hampered by its PVs having BL13J-... prefixes. Ideally we should be able to configure dodal so device_instantiation can pick this up from I13-1.

Since I04-1 and I20-1 are already in dodal and their PVs resolve to BL04I-... and BL20I-..., I assume those are the actual prefixes for those beamlines. I will check when able.

Acceptance Criteria

  • We can put some configuration in the i13_1 dodal module such that device_instantiation automatically inserts BL13J prefixes at the front of PV names
  • We can remove the bl_prefix=False argument currently present for all devices
  • There are regression tests to ensure we do not break existing beamlines
@callumforrester callumforrester added enhancement New feature or request i13-1 labels Aug 22, 2024
@DominicOram
Copy link
Contributor

Hmm... i20-1 and i04-1 are currently also broken because of this. It did work at one point and it's why BeamlinePrefix allows you to specify a suffix but clearly there was a regression. Running dodal connect i20-1 confirms that it's broken but annoyingly dodal connect i04-1 looks like it works because the hardware in dodal so far is the same for i04 and i04-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request i13-1
Projects
None yet
Development

No branches or pull requests

2 participants