Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move method-level import in GenericMethodWrapper.__init__() to module-level #451

Closed
yousefmoazzam opened this issue Sep 17, 2024 · 0 comments
Labels
minor Nice to do but not vital

Comments

@yousefmoazzam
Copy link
Collaborator

Very similar to #450 (in terms of the issue, and in terms of being needed for an integration test to go into #446), see that issue's description for details.

And similarly, any tests that attempt to patch import_module in generic.py via the following:

mocker.patch("importlib.import_module", return_value=FakeModule)

need to be changed to patch the import like so:

importmock = mocker.patch("httomo.method_wrappers.generic.import_module", return_value=FakeModule)
@yousefmoazzam yousefmoazzam added the minor Nice to do but not vital label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Nice to do but not vital
Projects
None yet
Development

No branches or pull requests

1 participant