Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Ticker can Propagate Messages Through a Variety of Complex Graphs #184

Open
callumforrester opened this issue Aug 30, 2023 · 2 comments
Labels
qa Testing, process, etc

Comments

@callumforrester
Copy link
Contributor

There should be a large suite of graphs, ranging from very simple A -> B to very complicated involving many nodes and near-loops. We should try to avoid propagation bugs such as that fixed by #180 from persisting long-term.

@abbiemery
Copy link
Collaborator

As stated in #183 .

The skipping of device updates that do not have deltas is fixed by #180 . It would be beneficial to have tests that attempt to propagate updates through a graph and ensure the full graph is skipped down wind of nodes which provide no updates, while also ensuring components do not get skipped incorrectly.

This would require running a scheduler and monitoring its tick, using the tickers propagate and checking the production of skips in schedule_possible_updates.

@callumforrester
Copy link
Contributor Author

Do you need a scheduler? Or can you just simulate one by prodding the appropriate methods on the ticker at the right time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa Testing, process, etc
Projects
None yet
Development

No branches or pull requests

2 participants