Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescale Window #2

Open
blakezim opened this issue May 3, 2017 · 1 comment
Open

Rescale Window #2

blakezim opened this issue May 3, 2017 · 1 comment

Comments

@blakezim
Copy link

blakezim commented May 3, 2017

When defining the window size (WinSize) in main.cpp, it is defined as Imagescale*Imagescale + 1, so essentially defined from the high resolution image. When that window is used in JBU.cpp on the low resolution image, the window is not scaled down. This makes the portion of the image that is covered by the window different in the high resolution image and the low resolution image.

I was running this on some test images (lowres = 50x50 and highres 500x500) and the window then compared all of the low resolution image to a small portion of the high resolution image, which caused artifacts as the range gaussian is entirely from the high resolution image.

It was very simple to fix this issue, I just scaled the 'j' and 'i' counters (line 51 and line 62, respectively, in JBU.cpp) by 'scale' and then that brought the window down to the appropriate size in the source image while keeping the same relative window size in the high resolution image.

Can you confirm that this considered an issue? If so, please let me know if you would like me to open a pull request or if the description above is sufficient enough to implement the change.

Thanks!

@Digital2Slave
Copy link
Owner

Dear BlakeZim,
Thanks for your issue. I'm very appreciate it.
Please feel free to open a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants