-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conan support #146
Comments
@AndreyMlashkin FYI, I've made a set of changes to make dependencies more flexible, take a look at #40. |
Ideally, there will be no need to use patches as CMake should be able to pick up any existing third-party libs and use them instead of submodules. I am almost sure that everything can now be achieved by just defining aliases where necessary in the top-level CMake, e.g (assuming that non-namespace targets are not defined - I don't know if they actually are). find_package(glslang REQUIRED CONFIG)
add_library(glslang ALIAS glslang::glslang)
add_library(OGLCompiler ALIAS glslang::OGLCompiler)
add_subdirectory(source_subfolder) |
@TheMostDiligent, in v2.5.2 it works really good for all libraries but glslang, there we have CMake Error at source_subfolder/ThirdParty/CMakeLists.txt:68 (add_subdirectory): |
This fixes my problem |
glslang's CMake file does not add namespace unless the targets are installed, so find_package(glslang REQUIRED CONFIG)
add_library(glslang ALIAS glslang::glslang)
add_library(OGLCompiler ALIAS glslang::OGLCompiler)
# And similar for other required targets
add_subdirectory(source_subfolder) |
Conan is a Package and Dependency Manager. It is a convenient tool to manage multiple dependencies.
It would be great to have a possibility to use DiligentEngine as a conan recipe.
conan-io/conan-center-index#1533
The text was updated successfully, but these errors were encountered: