Manually calling ViewModel.RefreshValues is causing issues in other mods

[adwitkow]

Bannerlord.Diplomacy/src/Bannerlord.Diplomacy/ViewModelMixin/EncyclopediaHeroPageVMMixin.cs

Line 40 in 9ac4a5c

vm.RefreshValues();

Mods running in the example (in that order):

• Diplomacy
• BannerKings
• Encyclopedia Extender Reforged

Diplomacy calling ViewModel.RefreshValues in its mixin constructor:

Diplomacy not calling ViewModel.RefreshValues in its mixin constructor:

The issue in reality in this case is caused by BannerKings hacking its way through the mixin (clearing the info section completely, re-applying vanilla values manually, doing weird checks if it's done it already but clearing the values anyway, it's really weird and I don't understand why it's the way it is) and Encyclopedia Extender not doing any checks if it's already applied its values or not, just adding everything when OnRefresh is called (causing it to apply twice). But in reality in my opinion if it's not necessary to call the RefreshValues method then it would be cleaner for everyone to just not call it.

Not sure about granting fiefs, but removing this line didn't break the messenger functionality for me.

[DAOWAce]

This is still an issue today.