Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like to contribute #43

Open
derwaldgeist opened this issue Aug 16, 2015 · 17 comments
Open

Would like to contribute #43

derwaldgeist opened this issue Aug 16, 2015 · 17 comments

Comments

@derwaldgeist
Copy link
Contributor

At the moment, the German translation is not 100% complete and sometimes a bit "strange" (no offense, but some of the wording could be better IMHO). Also, I've noticed some of the code samples seem to be outdated - yet I don't know if they've already been updated to the new syntax in the English version. So @SachaG: I'd like to contribute, if I may. Thanks, Tom.

@tiptronic
Copy link
Contributor

Welcome!

andy

Am 16.08.2015 um 22:29 schrieb Tom Brückner [email protected]:

@SachaG https://github.com/SachaG: At the moment, the German translation is not 100% complete and sometimes a bit "strange" (no offense, but some of the wording could be better IMHO). So I'd like to contribute, if I may. Thanks.


Reply to this email directly or view it on GitHub #43.

@derwaldgeist
Copy link
Contributor Author

Thanks for the quick reply, already got my invitation. Looking forward to contribute. KR, Tom

@derwaldgeist
Copy link
Contributor Author

A question: Is there any docs on the structure of these .erb files? I've noticed there are some special markups in there that seem to interact with the Discover Meteor page. Is this page really based on Ruby on Rails (seems a bit strange to me...)?

@tiptronic
Copy link
Contributor

These are common erb files with a couple of extensions as used by GitHub, etc... Sascha came up with this format in the original DM, so we stick with it since all other translations use this format as well.
Here are some 'official' guidelines: https://www.discovermeteor.com/guidelines
(Invitation was by me, btw ;))

@tiptronic
Copy link
Contributor

Btw. here's a somewhat general overview of .erb template syntax:
http://docs.puppetlabs.com/puppet/latest/reference/lang_template_erb.html

@derwaldgeist
Copy link
Contributor Author

Thanks, also for inviting me! KR, Tom

Von meinem iPad gesendet

Am 17.08.2015 um 11:13 schrieb Andy Fuchs [email protected]:

These are common erb files with a couple of extensions as used by GitHub, etc... Sascha came up with this format in the original DM, so we stick with it since all other translations use this format as well.
Here are some 'official' guidelines: https://www.discovermeteor.com/guidelines
(Invitation was by me, btw ;))


Reply to this email directly or view it on GitHub.

@derwaldgeist
Copy link
Contributor Author

Hi Andy, I translated the Advanced Reactivity chapter and commited the change yesterday, but it still does not show up on the official page. Do I have to trigger this myself somehow, or shall I just wait until one of the core maintainers performs a global update?

@tiptronic
Copy link
Contributor

If the commit was merged properly it should appear after the next update...

andy

Am 19.08.2015 um 00:12 schrieb Tom Brückner [email protected]:

Hi Andy, I translated the Advanced Reactivity chapter and commited the change yesterday, but it still does not show up on the official page. Do I have to trigger this myself somehow, or shall I just wait until one of the core maintainers performs a global update?


Reply to this email directly or view it on GitHub #43 (comment).

@derwaldgeist
Copy link
Contributor Author

Thanks!

Am 19.08.2015 um 01:45 schrieb Andy Fuchs [email protected]:

If the commit was merged properly it should appear after the next update...

andy

Am 19.08.2015 um 00:12 schrieb Tom Brückner [email protected]:

Hi Andy, I translated the Advanced Reactivity chapter and commited the change yesterday, but it still does not show up on the official page. Do I have to trigger this myself somehow, or shall I just wait until one of the core maintainers performs a global update?


Reply to this email directly or view it on GitHub #43 (comment).


Reply to this email directly or view it on GitHub #43 (comment).

@dnikl
Copy link

dnikl commented Sep 27, 2015

Would like to contribute as well. Saw some typo and code errors n chapter 05-routing.

@tiptronic
Copy link
Contributor

@dnikl: You're most welcome. Do you have some experience how to use git?

@dnikl
Copy link

dnikl commented Sep 27, 2015

Hi Andy

Let's say I start to get used to it...

I pulled the project. Made the changes. commited on a new tree called
Update_05-routing.md.erb and would be ready to push it.

Right now the permission is denied.
fatal: unable to access '
https://github.com/DiscoverMeteor/DiscoverMeteor_De.git/': The requested
URL returned error: 403

Greetings

Daniel

2015-09-28 0:48 GMT+02:00 Andy Fuchs [email protected]:

@dnikl https://github.com/dnikl: You're most welcome. Do you have some
experience how to use git?


Reply to this email directly or view it on GitHub
#43 (comment)
.

netlive IT AG
Postfach 246
9053 Teufen

Telefon: +41 78 602 00 45
Web: http://www.netlive.ch

Twitter: http://twitter.com/netliveit

TheCaliCamp
Surfcamp Kalifornien
Web: http://www.thecalicamp.com
FB: http://www.facebook.com/TheCaliCamp
PIN: http://pinterest.com/thecalicamp

@tiptronic
Copy link
Contributor

No more 403 ;)

@tiptronic
Copy link
Contributor

@dnikl Please don't create a branch for your changes. Either create a pull request or merge the changes directly (preferrably). We try to keep the repo as clean as possible.
thx
andy

@dnikl
Copy link

dnikl commented Oct 2, 2015

Hi Andy
Sorry. Next time I try better. But I ask myself how I should proceed. I did some of the next chapters and the translation has big troubles with different code on git hub and the manual, not working packages and code that does not look like good practice to me. I won't have the necessary time to be involved properly. In my opinion a beginner who tries this manual will be very frustrated and will fall in one trap after the other. That’s disappointing for a cool platform like Meteor.

Like every easy to learn language Meteor has a danger. As easy as it is there will be a lot of not so advanced developer and Meteor will be blamed for pure code they write. I’m coming from Coldfusion who went that road. Coldfusion got a bad reputation which it did not deserve.

As the German market is quit important if you are close to the Meteor guys it would be great if you ask them to think about investing some resources in a good translation to protect their framework. We all know the saying: “There is no second chance for a first impression”.

Cheers
Daniel

@tiptronic
Copy link
Contributor

Hi Daniel,

if you don't mind, please provide an example which illustrates the problem and I will try to find a solution (if any)...

thx

andy

Am 02.10.2015 um 23:50 schrieb Daniel Niklaus [email protected]:

Hi Andy
Sorry. Next time I try better. But I ask myself how I should proceed. I did some of the next chapters and the translation has big troubles with different code on git hub and the manual, not working packages and code that does not look like good practice to me. I won't have the necessary time to be involved properly. In my opinion a beginner who tries this manual will be very frustrated and will fall in one trap after the other. That’s disappointing for a cool platform like Meteor.

Like every easy to learn language Meteor has a danger. As easy as it is there will be a lot of not so advanced developer and Meteor will be blamed for pure code they write. I’m coming from Coldfusion who went that road. Coldfusion got a bad reputation which it did not deserve.

As the German market is quit important if you are close to the Meteor guys it would be great if you ask them to think about investing some resources in a good translation to protect their framework. We all know the saying: “There is no second chance for a first impression”.

Cheers
Daniel


Reply to this email directly or view it on GitHub #43 (comment).

@dnikl
Copy link

dnikl commented Oct 2, 2015

Hi Andy
Sure.

Old packages
If you follow the http://de.discovermeteor.com/chapters/adding-users/ you should install
$ meteor add accounts-ui-bootstrap-dropdown
But this is old and flaged as mrt
https://atmospherejs.com/mrt/accounts-ui-bootstrap-dropdown

Different code
If you look at the lib/router.js you see a Router.map in the manual

this.route('postSubmit', {path: '/submit'});
http://de.discovermeteor.com/chapters/creating-posts/

While on github the code uses

Router.route('/submit', {name: 'postSubmit'});
DiscoverMeteor/Microscope@chapter7-1

Pattern
If you look at lib/router.js on http://de.discovermeteor.com/chapters/creating-posts/ with the
Router.before(requireLogin, {only: 'postSubmit'});
I don't think that is the way Meteor wants us to code. It workes but it looks like spaghetti to me.

While the pattern is something you can debate the first two topics you need to re-write. This is a lot more work than just change some words or correcting some code. And there is more. Like one time it is using a message field witch you don’t see in later versions.

If you are a beginner I guess you have no chance to overcome this and even with some experience it makes it frustrating. O.k. if someone thinks this is a feature that you have to do your research then it is maybe a good idea to leave it the way it is ;-)

Hope that helps. Meteor deserves it chance.

Cheers
Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants