-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download Bundle #59
Comments
I'm on this one. |
@bbengfort and @rebeccabilbro, please check out my proposal below and let me know if anything is counter to project requirements. Proposal: There are a number of long term issues with the proposal below but it gets us closer to what we want. Some would require answering outstanding questions or perhaps unassigned/unidentified issues. S3 Buckets / Storage Question: Alternatively we could create Question: Should we keep bundles on a different bucket and use a UUID as folder name to obfuscate so that only those who have the link for a private dataset can download? Should we just use a UUID as the bundle name or is there a requirement that it be friendly filename in some way? Security Bundle generation User Interface |
|
Point on security: at the moment (I believe) the bucket requires a token to give up the goods, and that token is generated via boto through the Django Storages app. The token grants the user a download, and the link only lasts for 6 hours or something. Meaning that the link isn't created for a user who doesn't have permission. If this is not the case; then I must have manually edited the bucket for development reasons, and we should go back to the token method above. |
Also, I'm happy to store the bundles on S3 if that's what you think we should do. However, I was planning to generate the zip file on demand with the things that are in the database via the zipfile library and StringIO objects, sort of like Use compressed data directly – from ZIP files or gzip http response Maybe you're thinking this doesn't scale, which is fair; so bunldes/account/dataset-version.zip seems fine to me. All the rest of your proposal looks good to me. |
Current status: Todo: |
I like the idea of being able to download a dataset at previous versions - that will help with estimator reproducibility and a host of other items. |
Add bundle (as in Sckit-Learn bundle) download mechanism to the interface. This mechanism should export:
The text was updated successfully, but these errors were encountered: