-
-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance PCA Decomposition #476
Comments
Hey! i'm interested in tackling this. |
@rohit-ganapathy - that would be great, feel free to open a PR when you're ready for us to take a look. |
Can I start working on this,even if @rohit-ganapathy is assigned? |
Hello @naba7 — as we explained last week in response to your questions on #738 and #677, we do not "assign" issues or reserve issues for contributors. Anyone is welcome to submit a PR for a feature or bugfix they work on. However, given that you already have one PR open that still needs to be completed (#755), have started working on #615, and are new to working on Yellowbrick and still getting to know our API, we would really appreciate if you would focus on getting those first PRs across the finish line before starting anything new. We appreciate your enthusiasm about contributing to Yellowbrick. One of the most important lessons to learn is that open source is a marathon, not a sprint, so we hope you can be patient and enjoy the journey — we promise Yellowbrick isn't going away! |
It's so exciting and fun. I want to know and learn things quick. So,I am
asking questions to get assigned everywhere. Sorry I have noted this now.
…On Tue 19 Feb, 2019, 7:48 AM Rebecca Bilbro ***@***.*** wrote:
Hello @naba7 <https://github.com/Naba7> — as we explained last week in
response to your questions on #738
<#738> and #677
<#677>, we do not
"assign" issues or reserve issues for contributors. Anyone is welcome to
submit a PR for a feature or bugfix they work on.
However, given that you already have one PR open that still needs to be
completed (#755 <#755>),
have started working on #615
<#615>, and are new
to working on Yellowbrick and still getting to know our API, we would
*really* appreciate if you would focus on getting those first PRs across
the finish line before starting anything new.
We appreciate your enthusiasm about contributing to Yellowbrick. One of
the most important lessons to learn is that open source is a marathon, not
a sprint, so we hope you can be patient and enjoy the journey — we promise
Yellowbrick isn't going away!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#476 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AeGb9yDVmfn6QhUbUjh1no0PM6763S9eks5vO177gaJpZM4UoE6->
.
|
@naresh-bachwani has this issue been fixed by your work this summer? |
@bbengfort I think that explained variance charts are left! But that will be covered in decomposition, right? |
@naresh-bachwani |
@BrandonKMLee very possibly, it wouldn't hurt to try. I think what you'd have to do is change the You could also try passing an initialized |
@bbengfort |
@BrandonKMLee ok, that makes sense so potentially FastICA make not work unless we create a specialized manifold for them. |
We should enhance the
PCADecomposition
visualizer to provide many of the features theManifold
visualizer provides, including things like:See also #455 as another enhancement that might not be related to this enhancement.
The text was updated successfully, but these errors were encountered: