Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Hardcoded Values and Dead Code Smells in checkBuyableRc, checkSellableRc, and getCoinBudgets #132

Open
Tanya-ruby opened this issue Oct 3, 2024 · 0 comments

Comments

@Tanya-ruby
Copy link
Contributor

The functions checkBuyableRc and checkSellableRc currently return hardcoded values that automatically approve transactions, which should not be the case. Additionally, the getCoinBudgets function is returning hardcoded null values. These hardcoded values need to be either removed or commented out to ensure the correct logic is implemented.

Furthermore, these hardcoded values introduce dead code smells, as they do not contribute meaningfully to the program's functionality. Keeping such code can increase complexity and reduce maintainability. Removing or refactoring these sections will improve code quality and readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant