You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are currently working on breaking down our Rails monolith with some tools from the packs ecosystem. This led us to moving all our GraphQL code to a folder packages/web_graphql.
This clashes with the default Include and Exclude rules in this package, which often hardcode a graphql directory. Example:
If this was the only rule, then I wouldn't worry about it so much, and we did override it in our Rubocop config for now. But since there are several other, more specific rules also using similar constructs, I'm worried about quietly and unintentionally skipping a lot of valuable cops.
Would you be open to changing this to *graphql* to make it work with any directory containing the term "graphql"?
The text was updated successfully, but these errors were encountered:
*graphql* sounds reasonable, but I wonder if we could make it configurable in a single place (cause someone might want something else like gql). For instance, rules will have Include: "**/<gql_folder>/**/*", while somewhere else we'd have something like gql_folder: graphql or gql_folder: web_graphql . Not sure if it's possible though 🤔
Hi and thanks for the excellent package! 👏🏼
We are currently working on breaking down our Rails monolith with some tools from the packs ecosystem. This led us to moving all our GraphQL code to a folder
packages/web_graphql
.This clashes with the default
Include
andExclude
rules in this package, which often hardcode agraphql
directory. Example:rubocop-graphql/config/default.yml
Lines 3 to 4 in ca4506b
If this was the only rule, then I wouldn't worry about it so much, and we did override it in our Rubocop config for now. But since there are several other, more specific rules also using similar constructs, I'm worried about quietly and unintentionally skipping a lot of valuable cops.
Would you be open to changing this to
*graphql*
to make it work with any directory containing the term "graphql"?The text was updated successfully, but these errors were encountered: