Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timelines and mentions should only take user IDs, not usernames #587

Open
SamHames opened this issue Jan 10, 2022 · 1 comment
Open

Timelines and mentions should only take user IDs, not usernames #587

SamHames opened this issue Jan 10, 2022 · 1 comment

Comments

@SamHames
Copy link
Contributor

I think these two endpoints should only take user IDs, and not implicitly perform the lookup if a username is passed.

This would let us:

  • avoid the complexity of dealing with usernames that might also user ids (I think the current implementation has some weird edge cases - a username that doesn't exist will raise an error, but a user id that doesn't exist won't)
  • align the functionality with the Twitter API at the client, rather than doing an unexpected username -> user_id lookup

We'd probably need some supporting documentation to show how to convert usernames into user ids too?

@igorbrigadir
Copy link
Contributor

How about a twarc2 usernames input.txt output.txt command? Something like that?

It's convenient to use usernames - maybe we can still do this but only if explicitly set, to avoid checking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants