Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextLink: default CSS variable choice seems off #608

Open
scottlovegrove opened this issue Nov 15, 2021 · 0 comments
Open

TextLink: default CSS variable choice seems off #608

scottlovegrove opened this issue Nov 15, 2021 · 0 comments

Comments

@scottlovegrove
Copy link
Contributor

🐛 Bug report

Current behavior

When using the TextLink component, by default it is using --reactist-chromatic-content-blue for its color value, the problem with this is to override that to a different colour, you have to then put something like --reactist-chromatic-content-blue: red which seems counter intuitive.

I wonder if there should be a better CSS variable for this color that by default can use that variable, but overriding it means you wouldn't be overriding an existing colour value.

Steps to reproduce the bug

I just have

<TextLink href={selectedFilm.filmLink()} openInNewTab>
    Film details
</TextLink>

Which gives me the following css
image

I have overridden the blue value to be something else now, but it just seems odd that I have to override a blue value to be able to use some other colour.

Expected behavior

It should use a more sensibly named CSS variable.

Environment

  • @doist/reactist version: 11.0.0
  • react version: 17.0.2
  • Browser: Chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant