Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add short versions of ASCII arts #283

Open
hrw opened this issue Sep 9, 2024 · 5 comments
Open

Add short versions of ASCII arts #283

hrw opened this issue Sep 9, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@hrw
Copy link

hrw commented Sep 9, 2024

There is nearly no space for information:

[marcin@sbc ~]$ /tmp/cpufetch

                                                          SoC:          Rockchip
                                                          Technology:   8nm
                                                          CPU 1:
                                              ##            uArch:      Cortex-A
   ######                ##            ##                   Max Freq:   1.800 GH
  ##.  ### ##### #####  ## .## #####  ######. ##   #####    Cores:      4 cores
 #######. ##. # #.     #####  ##.    ###  ###  #     .##    Features:   NEON,SHA
##.  ###.  ####. #### ###  .## #### ###  ###   #.#####    CPU 2:
                                                ##          uArch:      Cortex-A
                                                            Max Freq:   2.400 GH
                                                            Cores:      4 cores
                                                            Features:   NEON,SHA
                                                          Peak Perf.:   211.20 G

@hrw hrw changed the title Rockchip logo is too wide logos are too wide Sep 9, 2024
@hrw
Copy link
Author

hrw commented Sep 9, 2024

                                          SoC:          Unknown
   #####  ##   # #####  ## ####  ######   Technology:   Unknown
 ###    ####   ###      ####  ###   ###   uArch:        Neoverse N2
###       ##   ###      ###    ##    ###  Max Freq:     ~960 MHz
 ###    ####   ###      ###    ##    ###  Cores:        4 cores
  ######  ##   ###      ###    ##    ###  Features:     NEON,SVE,SVE2,SHA1,SHA2,
                                          Peak Perf.:   61.44 GFLOP/s

'Features' field is cut.

@Dr-Noob
Copy link
Owner

Dr-Noob commented Sep 10, 2024

Rochckip logo is too big, I agree. Usually there is a long version of the logos and a short one (you show here the long Rockchip one and the ARM short one), but Rockchip has no logo version at the moment.

ARM short logo (the one you show) is not too wide in my opinion. Some space for the logo is needed.

If you believe you can design shorter versions without making them look ugly please feel free to open a PR, thanks.

@hrw
Copy link
Author

hrw commented Sep 10, 2024

I would rather add --no-logo argument.

No ANSI gfx skills

@Dr-Noob
Copy link
Owner

Dr-Noob commented Sep 11, 2024

I would have alias cpufetch --no-logo=lscpu (or any other tool).

One of the keys of cpufetch is the logo. Yes, in small terminals this can be an issue, but in general it fits nicely, except for vendors which do not have short logos like rockchip. But that can be solved with shorter logos, which is not a priority right now, but eventually they will be added as well.

@Dr-Noob Dr-Noob changed the title logos are too wide Add short versions of ASCII arts Sep 11, 2024
@Dr-Noob Dr-Noob added the enhancement New feature or request label Sep 11, 2024
@Dr-Noob
Copy link
Owner

Dr-Noob commented Sep 11, 2024

I'll have this issue as a remainder to work on this one day 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants