Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for $] comparison #131

Open
atoomic opened this issue Jul 15, 2019 · 2 comments
Open

Add unit test for $] comparison #131

atoomic opened this issue Jul 15, 2019 · 2 comments

Comments

@atoomic
Copy link
Member

atoomic commented Jul 15, 2019

Add test to cover the discussion from RT 134273 https://rt.perl.org/Ticket/Display.html?id=134273

also view patch/discussion from #128

@khwilliamson
Copy link
Member

I added some functions to generate version numbers into a file that could be made available to all .t's. It is similar to the macro the previous maintainers implemented so you could get unambiguous version numbers in C space, but this works from perl space. I'm thinking we should convert all uses of $] to be operated on by this function so that we can get integer versions, and then change the comparators to integers as well

@atoomic
Copy link
Member Author

atoomic commented Oct 14, 2019

This is a good idea, we can use this issue to track these changes, and replace all usages of $] with this new helper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants