-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on Scalar::Util #86
Comments
I filed an issue here which would be a better idea -- that is to have Sub::Util (which is in the suite of ::Util stuff) break off the XS for |
I'll happily take a PR for this @EvanCarroll |
@toddr I filed that bug in parallel on https://rt.cpan.org/Public/Bug/Display.html?id=129216 I think that's the right way to go. Then we could use set_prototype in Sub::Util without carrying the weight of List::Utils. However, I think you know why I was interested in this =) and I'm not sure this is still a pressing concern. I think we're unified now not caring about RSS. |
Update from IRC.
So what's wanted here is
The proposal for |
autodie
is currently usingFatal
which is usingScalar::Util
but just for access toset_prototype
.Scalar::Util
is simply grabbing that fromSub::Util
set_prototype
doesn't call any other files in that XS.If I'm reading this right if we broke about that XS file, or reimplemented it in autodie we wouldn't have to load List::Utils, or Scalar::Utils, and we would have joy?
What would
autodie
save? In minimal cases at the very least we wouldn't have to map in these three pages fromList/Util/Util.so
(we'd still have to map in one page from Util.so but we'd reduce that by 3).Perhaps we could get with Sub::Util, and have them break out the one function from the XS so Sub::Util doesn't require List::Util, and then we could update our own dependencies?
The text was updated successfully, but these errors were encountered: