Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--tmp-outdir-prefix /calrissian/tmp and /calrissian/tmp/ behave differently #171

Open
fabricebrito opened this issue Jul 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@fabricebrito
Copy link
Contributor

fabricebrito commented Jul 5, 2024

A trailing slash in the value of the --tmp-outdir-prefix CLI option provide different output results

image: ghcr.io/duke-gcb/calrissian/calrissian:0.16.0
          command: ["calrissian"]
          args:
            - --stdout 
            - /calrissian/results.json
            - --stderr 
            - /calrissian/app.log
            - --max-ram 
            - 4G
            - --max-cores 
            - "8"
            - --tmp-outdir-prefix 
            - /calrissian/tmp 
            - --outdir
            - /calrissian/results
            - --usage-report 
            - /calrissian/usage.json
            - --tool-logs-basepath 
            - /calrissian/logs
            - /app-package/app-package.cwl
            - /inputs/params.yaml

Without the trailing slash:

 "stac_catalog": {
        "location": "file:///calrissian/results/tmpblxy91p7",

With the trailing slash:

{
    "stac_catalog": {
        "location": "file:///calrissian/results/lvm_l4cj",

Using --tmp-outdir-prefix /calrissian/tmp-aaa we get:

{
    "stac_catalog": {
        "location": "file:///calrissian/results/tmp-aaabxuod1w_",

A trailing slash should not change the url "pattern" of a parameter taking a directory

@fabricebrito fabricebrito added the bug Something isn't working label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant