Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git operations like branch switch or reverts can cause mismatch between folder and file contents #677

Closed
aplteam opened this issue Oct 6, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@aplteam
Copy link
Contributor

aplteam commented Oct 6, 2024

When I delete a file on disk I expect Link to delete the associated APL object from the workspace, but that is not the case.

For example, if somebody believes the Link documentation, then she might think that switching git branches (while having a folder Linked) might be a safe thing to do, because Link would reflect all changes, then she be wrong because of this bug.

Dyalog  19.0.50061 64-bit Unicode, BuildID 87528164 
 OS      Windows 11 (10.0.22631) 64-bit              
 Link    4.0.17                                      
 SALT    2.915                                       
 UCMD    2.6                                         
 .NET    .NET Framework 4.8.9261.0                   
 WS      19.0                                        

(This my <02215>)

@aplteam aplteam added the bug Something isn't working label Oct 6, 2024
@mkromberg mkromberg changed the title Link does not delete an APL object when the associated file is deleted by other means Git operations like branch switch or reverts can cause mismatch between folder and file contents Oct 6, 2024
@mkromberg
Copy link
Contributor

In general, I don't think the first statement is true: If you delete a file, that typically does remove the object from the workspace. If you have an example of that failing, please log a separate issue.

However, Git (or other tool) operations which both delete and create the same file name in quick succession can cause problems.

PR #650 contains code which is close to fixing this, I need to find the time to integrate it with Link 4.0.

@aplteam
Copy link
Contributor Author

aplteam commented Oct 6, 2024

I deleted a file in the Windows File Explorer, and Link did not reflect that.

But it happened only once: when I tried to reproduce it, it always worked.
Feel free to close this.

The branch switch occurred to me as an example of why one might run into this because deleting is something I would do in APL anyway.

@abrudz
Copy link
Member

abrudz commented Dec 16, 2024

Feel free to close this.

@abrudz abrudz closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants