Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: YouTube API v1 #39

Open
DzenanJupic opened this issue Jul 23, 2021 · 5 comments
Open

Tracking issue: YouTube API v1 #39

DzenanJupic opened this issue Jul 23, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@DzenanJupic
Copy link
Owner

This is the tracking issue for adapting from /get_video_info to YouTube's API v1.

Related issues:

DzenanJupic added a commit that referenced this issue Jul 23, 2021
…38

This is just to fix the video download. Since we get a PlayerResponse in watch_html anyway, there's no need to get the video_info from other sources. This works for now. The long term solution is to adapt to YouTube's API v1 (tracking issue: #39).
@DzenanJupic DzenanJupic added the enhancement New feature or request label Jul 23, 2021
@DzenanJupic
Copy link
Owner Author

#38 (comment)

@ghost
Copy link

ghost commented Dec 23, 2021

@DzenanJupic Follow up from the 0.3.6 release. This package still fails to download. I don't know if there's a plan for this to be resolved soon.

---- tests::test_download stdout ----
thread 'tests::test_download' panicked at 'expect an OK(_) response: UnexpectedResponse("Could not acquire the player response from the watch html!\nNote, that this is usually no problem and just happens due to a temporary fix to adapt to the new YouTube API.\nFor more information checkout rustube#39 (https://github.com/DzenanJupic/rustube/issues/39).")', src/lib.rs:49:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

For more reference: ydl

@DzenanJupic
Copy link
Owner Author

Hey @nyanchor, thank you for mentioning this. 0.3.6 used to work, so I guess youtube changed their API once again. I'll have a look at this in the next few days.

@DzenanJupic
Copy link
Owner Author

@nyanchor the 0.3.7 release fixes the problem. See #42 for more information on the cause. Unfortunately, we are still fighting with slow download speeds.

@ghost
Copy link

ghost commented Dec 28, 2021

thanks issue fixed! @DzenanJupic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant